[05:12] <mborzecki> morning
[05:47] <mardy> mborzecki: hi!
[05:57] <mborzecki> mardy: heya
[06:40] <mborzecki> hmm hmm
[06:42] <zyga-mbp> good morning
[06:42] <zyga-mbp> mborzecki one thing I miss about spain is that at night, it's still 21C
[06:54] <mborzecki> meh, lp builds are unhappy about go module
[06:55] <mup> PR snapcraft#3578 opened: Fix: files starting with '.' are not organized and also not caught by filesets <Created by debdutdeb> <https://github.com/snapcore/snapcraft/pull/3578>
[06:58] <mborzecki> reproduced the build problem from lp at least :)
[07:00] <mvo> mborzecki: \o/
[07:01] <mvo> mborzecki: any more info yet?
[07:01] <mborzecki> mvo: hey, so i think we're missing this: https://paste.ubuntu.com/p/BkGRc5QQYW/
[07:01] <pstolowski> morning
[07:01] <mborzecki> mvo: also github.com/boltdb/... is listed in go.mod but does not really appear in vendor directory anywhere
[07:03] <mborzecki> mvo: do you remember why we have a fork of boltdb?
[07:03] <mvo> mborzecki: do you know why it started just now?
[07:03] <mvo> mborzecki: iirc to fix build problems on trusty, let me quickly check
[07:04] <mvo> mborzecki: build on 32bit systems and riscv
[07:04] <mvo> mborzecki: https://github.com/snapcore/bolt/commits/master
[07:04] <mborzecki> mvo: afaiu lp builders run with disabled network, our go.mod listst github.com/boltdb/.. and thus go build attempts to fetch the module
[07:05] <mvo> mborzecki: ohhhhh, that makes sense. wonder why it ever worked but maybe it never did inside a buildd
[07:05] <mborzecki> mvo: maybe we could just replace that bolt with our fork using https://golang.org/ref/mod#go-mod-file-replace for deb builds?
[07:05] <mvo> mborzecki: I think so, iirc ian had something like this
[07:06] <mvo> mborzecki: https://github.com/snapcore/snapd/pull/10559/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R36 <- looks like not for bolt but he looked at it for other things
[07:06] <mup> PR #10559: many: move to go modules  <⛔ Blocked> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/10559>
[07:06] <mvo> mborzecki: thanks *so* much for finding this
[07:06] <mborzecki> mvo: i'll open a pr in a bit
[07:17] <mup> PR snapd#10609 closed: interfaces/desktop: mount system fonts via app desktop slot <Created by MarcusTomlinson> <Closed by jhenstridge> <https://github.com/snapcore/snapd/pull/10609>
[07:17] <mup> PR snapd#10753 opened: interfaces/desktop: allow snaps to provide a desktop slot, granting access to system fonts <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/10753>
[07:30] <mardy> hi zyga-mbp, mvo, pstolowski 
[07:30] <zyga-mbp> hey :)
[07:30] <zyga-mbp> impish is close to release
[07:30] <zyga-mbp> I remember before snaps, everything was very stressful at this time
[07:31] <zyga-mbp> I guess now it's more of a mixed set, with some things still having to make it on time
[07:31] <zyga-mbp> but some things having the luxury of releasing on time when they are ready
[07:37] <mardy> do you guys see any value in this? https://github.com/snapcore/snapd/pull/10751 I started it yesterday, but today I seem to realize that it's already relatively easy to mock the snapd responses, so maybe I should drop it.
[07:37] <mup> PR #10751: client: turn the Client type into an interface <Created by mardy> <https://github.com/snapcore/snapd/pull/10751>
[07:56] <mborzecki> mvo: heh so not sure what to make of it, snapd imports snapcore/bolt which has some *_test.go files that improt boltdb/bolt and that makes it an indirect dependency, adding a replace directive confuses go as there are 2 modules doing the same now?
[07:56] <mborzecki> mvo: also, we're not setting GO111MDOULE so dh_golang defaults to GO111MODULE=off
[07:56] <mborzecki> but we do pass -mod vendor sometimes?
[08:04] <mvo> mborzecki: ohhh, maybe we need to just set go111module globally in the debian build rules then? 
[08:04] <mvo> mborzecki: sorry that I did not explore that, between the different dh-golang versions I got lost a bit but the env might be enough to give us the desired behavior
[08:06] <mvo> I wonder if we can somehow make the package build inside spread networkless, if there is a clever "nsenter" to archive that
[08:27] <mborzecki> mvo: yeah, that's what im doing right now, added unshare -n around all calls to rpmbuild/debuild/makepkg
[08:28] <mvo> mborzecki: \o/
[08:28] <mvo> mborzecki: should I fix the testfiles in boltdb ? or are you on it alredy?
[08:29] <mborzecki> mvo: added something like this locally: https://paste.ubuntu.com/p/Csg5JpZTZH/
[08:30] <mborzecki> mvo: but i guess the imports need to be fixed anyway as replace are package local iirc
[08:47] <mup> PR snapd#10754 opened: tests/lib/prepare-restore: make sure that package build is done without network access <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10754>
[08:48] <mborzecki> mvo: ^^
[08:48] <mvo> mborzecki: nice
[08:53] <sil2100> pstolowski, mvo: hey hey! Just poking around to see if there's any progress with the snapd focal riscv64 situation? Is there an upload planned for temporarily skipping the failing tests?
[08:54] <pstolowski> sil2100: my PR for disabling the failing suite on riscv landed yesterday in master
[08:57] <mup> PR snapd#10717 closed: tests: fix interfaces-libvirt test <Created by sergiocazzolato> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10717>
[08:58] <pstolowski> sil2100: it was https://github.com/snapcore/snapd/pull/10736
[08:58] <mup> PR #10736: tests: skip overlord tests on riscv64 due to timeouts <Simple 😃> <Skip spread> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/10736>
[09:00] <mardy> is it possible for a snap to control (stop, start, restart) its own services, without needing the user to be root? ("snapctl stop", for example, requires root)
[09:10] <sil2100> \o/
[09:24] <zyga-mbp> mardy IIRC yes
[09:24] <zyga-mbp> mardy snapctl is accessible from the inside of the snap
[09:29] <sil2100> pstolowski: do you know when this change will be uploaded to focal?
[09:30] <mborzecki> mvo: meh, as expected the deb builds are failing without network
[09:32] <zyga-mbp> mborzecki module "fun"?
[09:32] <pstolowski> sil2100: dunno, mvo may know
[09:32] <mborzecki> zyga-mbp: yeah unforunately
[09:33] <zyga-mbp> it's a really hard problem :/
[09:33] <zyga-mbp> I have a path to fix that in my yocto builds but nothing fixed yet
[09:33] <zyga-mbp> the complete module system is elaborate and complex
[09:33] <mborzecki> zyga-mbp: also dh-* is really getting into the way
[09:36] <zyga-mbp> hmm
[09:39] <mardy> zyga-mbp: there's a check there, and the stop, start and restart commands are allowed only for root: https://github.com/snapcore/snapd/blob/master/overlord/hookstate/ctlcmd/ctlcmd.go#L148-L150
[09:43] <mvo> sil2100: uh, right, sorry, I wanted to do it today/yesterday but 360 :(
[10:20] <zyga-mbp> uh
[10:20] <zyga-mbp> popsulem sobie system
[10:20] <zyga-mbp> pstolowski uzywasz czegos do kopii zapasowych wirtualek?
[10:21] <pstolowski> zyga-mbp: did you mean it for #snappy? ;)
[10:22] <zyga-mbp>  pstolowski bad channel :)
[10:22] <zyga-mbp> sorry
[10:51] <mup> PR snapcraft#3579 opened: snap: move base to core20 <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3579>
[11:27] <sil2100> mvo: no worries! That reminds me... need to fill in out my 360!
[12:15] <mborzecki> heh  cryptic errors: `devicemgr: cannot update revisions after boot changes: empty snap file name`
[12:43] <mup> PR snapd#10743 closed: tests: fix fakedevicesvc service already exists <Simple 😃> <Run nested> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10743>
[12:58] <mup> PR snapd#10755 opened: client: introduce mocking of the Client interface <Created by mardy> <https://github.com/snapcore/snapd/pull/10755>
[13:32] <mvo> mborzecki: should I commit the boltdb imoport fixes or are you on it alredy?
[13:32] <mborzecki> mvo: please do if you can, still fighting managers test suite
[13:32] <mvo> mborzecki: sure, doing this now
[13:41] <mvo> mborzecki: fix pushed
[13:41] <mborzecki> thanks
[13:41] <mvo> mborzecki: let's see if it helps :)
[13:41] <mborzecki> i'm confused, did old model assertions not require a "base" header?
[14:03] <mup> PR snapd#10756 opened: cmd/snap: only log translation warnings in debug/testing <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10756>
[14:41] <mardy> I very welcome reviews on https://github.com/snapcore/snapd/pull/10628, if someone has a few minutes to spare
[14:41] <mup> PR #10628: usersession/xdgopenproxy: move PortalLauncher class to own package <Squash-merge> <Created by mardy> <https://github.com/snapcore/snapd/pull/10628>
[14:45] <pstolowski> cachio: could https://github.com/snapcore/snapd/pull/10561 land now (once reviewed)?
[14:45] <mup> PR #10561: tests: revert revert manuall lxd removal <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10561>
[14:45] <pstolowski> or are we still waiting for lxd fix?
[14:53] <cachio> pstolowski, thanks, the fix is already applied, so it is good time to land this one
[14:53] <pstolowski> cachio: ok, +1 from me
[14:58] <cachio> tx
[15:58] <pstolowski> need 2nd review for https://github.com/snapcore/snapd/pull/10725
[15:58] <mup> PR #10725: o/hookstate: require snap-refresh-control interface for snapctl refresh --proceed <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10725>
[16:54] <cachio> ijohnson[m], hi, I see the recover issue again on uc20
[17:05] <ijohnson[m]> cachio: did you see it with the debug kernel command line branch or with what's on master?
[17:08] <cachio> ijohnson[m], I saw that on maste
[17:08] <cachio> now I am running tests to see if I can reproduce it and get some extra info
[17:08] <cachio> I am using your pr
[17:09] <ijohnson[m]> ack
[18:56] <ledhed> I have some questions about Full Disk Encryption on Ubuntu Core.  Is this the right place to ask, or is there a more appropriate support channel?
[18:57] <ijohnson[m]> ledhed yeah this is the right place 
[18:57] <ijohnson[m]> Either here or the snapcraft forum on the channel header 
[19:00] <ledhed> thanks,   I have a project coming up and would like to use Ubuntu Core, but my understanding is that FDE only works (at least out of the box) on certified devices.  The hardware I need for my project (CompuLab Fitlet2, AMD64) appears to have all the requirements to support FDE. I'm just not clear if I can build my own image and enable FDE, or if
[19:00] <ledhed> FDE is strictly for certified devices and I would need to get the Fitlet2 certified.
[19:02] <ijohnson[m]> ledhed FDE for amd64 platforms works out of the box on devices that meet the requirements, i believe the fitlet2 meets the requirements 
[19:05] <ledhed> when I run: ls /dev/disk/by-partlabel/ | grep enc nothing is returned. Which implies its not encrypted.
[19:06] <ledhed> I checked the bios and confirmed that Secure Boot is enabled, as is the TPM
[19:52] <ledhed> I was able to get it to encrypt the disk, seems I had to clear the TPM.  The problem I'm running into now is that after it encrypts the disks, on the next boot it asks for the recovery key. Then errors out and says "cannot activate with TPM sealed key (cannot unseal key: invalid data file: cannot complete authorization policy assertions: cannot
[19:52] <ledhed> complete OR  assertions: current session digest not found in policy data) and activation with recovery key failed (cannot obtain recovery key: /usr/sbin/systemd-ask-password failed: exit status 1)"
[20:26]  * cachio afk
[22:41] <mwhudson> hello, what version of go is the snapd snap built with?
[22:42] <ijohnson[m]> mwhudson 1.13 currently
[22:42] <mwhudson> ok
[22:43] <mwhudson> from my snap or do we have that in the archive for xenial now?
[22:43] <mwhudson> (it is still built on xenial, right? is there a plan to change that?)
[22:43] <mwhudson> ah yeah we do have 1.13 on xenial
[22:56] <mwhudson> ijohnson[m]: anyway https://bugs.launchpad.net/snapd/+bug/1943077
[22:56] <mup> Bug #1943077: snapd fails to autopkgtest on mksquashfs, which is looking for libgcc_s <update-excuse> <snapd:New> <openssh (Ubuntu):New> <squashfs-tools (Ubuntu):New> <https://launchpad.net/bugs/1943077>
[22:57] <dbungert> if you have questions, I filed that monstrosity
[22:58] <dbungert> the summary would be "snapd seems to need libraries outside of itself to pass autopkgtest"
[23:10] <mwhudson> dbungert: i think the fix is pretty trivial luckily
[23:12] <mwhudson> dbungert, ijohnson[m]: to whit https://github.com/snapcore/snapd/pull/10757
[23:12] <mup> PR #10757: build-aux: stage libgcc-s1 library into snapd snap <Created by mwhudson> <https://github.com/snapcore/snapd/pull/10757>
[23:15] <mup> PR snapd#10757 opened: build-aux: stage libgcc-s1 library into snapd snap <Created by mwhudson> <https://github.com/snapcore/snapd/pull/10757>
[23:15] <dbungert> Failed to fetch stage packages: Error downloading packages for part 'libc6': The package 'libgcc-s1' was not found..
[23:17] <mwhudson> oh really
[23:17] <dbungert> mwhudson: libgcc1?
[23:18] <mwhudson> yes probably
[23:20] <mwhudson> yes
[23:20] <mwhudson> ok force pushing that
[23:21] <mwhudson> package name changed somewhere between bionic and focal it seems