[05:02] <mborzecki> morning
[07:06] <pstolowski> morning
[07:07] <mvo> good morning pstolowski 
[07:09] <zyga-mbp> good morning guys :)
[07:12] <mvo> good morning zyga-mbp !
[07:12]  * zyga-mbp is semi-trapped in the forest today
[07:13] <zyga-mbp> the main road out is closed by lumberjacks and we're not sure our car can go through the service roads
[07:15] <amurray> zyga-mbp: I am very envious of your working environment :) I am just in my house in the suburbs... forest sounds awesome 🌲
[07:16] <zyga-mbp> amurray I went out for an early-morning walk and it's lovely
[07:17] <amurray> nice
[07:18] <zyga-mbp> amurray (terrible colors, reality was less contrasty) https://twitter.com/zygoon/status/1437314457567387648
[07:24] <amurray> oooh pretty
[07:26] <zyga-mbp> there's also a lake but I won't mention that ;)
[07:32] <pstolowski> zyga-mbp: cruel ;)
[07:38] <mup> PR snapd#10770 opened: systemd: use text.template to generate mount unit <Created by mardy> <https://github.com/snapcore/snapd/pull/10770>
[07:52] <mardy> hi all :-)
[07:53] <zyga-mbp> @mvo small PR for spread, https://github.com/snapcore/spread/pull/134 
[07:53] <mup> PR spread#134: Use greedy regex for $(HOST: ) <Created by zyga> <https://github.com/snapcore/spread/pull/134>
[07:53] <mardy> zyga-mbp: we also went in the woods on Saturday, founds quite a few mushrooms -- though we went late, so the best ones had already been collected, it seemed
[07:54] <zyga-mbp> I found a few during my morning walk but I left them intact
[07:54] <zyga-mbp> the woods should be full of shrooms soon, it's still warm and it rained recently
[07:54] <zyga-mbp> too bad I'm at work :P
[07:55] <mvo> zyga-mbp: oh, thanks for this PR!
[07:55] <pstolowski> zyga-mbp: zelda-style gathetring time? ;)
[07:55] <pstolowski> hey mardy 
[07:56] <zyga-mbp> pstolowski less chu-chu jellies and chests ;)
[07:56] <zyga-mbp> I've been using that locally but please double check if it makes sense to your eyes
[07:56] <zyga-mbp> I didn't do any tests, just a quick change & shared it quickly not to forget
[07:58] <mardy> tests are left to the reader ;-)
[07:59] <zyga-mbp> I would not tell *that* to mvo
[07:59] <zyga-mbp> but spread has remarkably few tests
[08:06] <mup> Bug #1943419 opened: LXD snap auto refresh stuck at copy snap data phase for 16+ hours without making progress <sts> <Snappy:New> <https://launchpad.net/bugs/1943419>
[08:28] <mvo> zyga-mbp: I quickly looked at the PR, if you could add an example how you noticed it and a "before/after" the change that would be lovely, then I can write a test for you
[08:28] <zyga-mbp> yeah, I can even write the test but I didn't get to it yet, it's something I bumped into yesterday
[08:28] <zyga-mbp> the example was $(HOST: $(echo example))
[08:29] <zyga-mbp> or maybe
[08:29] <zyga-mbp> the example was $(HOST: $(echo example)-foo)
[08:29] <zyga-mbp> anyway, I'll update it with unit tests
[08:29] <mvo> zyga-mbp: cool, that is all I need
[08:29] <zyga-mbp> the real code was in libzt test suite, I've updated it to support local snap store proxy for caching
[08:30] <zyga-mbp> and I've used quite a bit of HOST variables for that
[08:30] <zyga-mbp> I can paste the real thing but the point is that the old spread stopped at the first right ")"
[08:30] <zyga-mbp> so $(HOST: ...) could never have ) insdie
[08:30] <zyga-mbp> *inside
[08:39] <mardy> reviews *very* welcome on this, as I plan to add more tests based on this new EnsureAtLeast() method: https://github.com/snapcore/snapd/pull/10748
[08:39] <mup> PR #10748: systemd: add AtLeast() method, add mocking in systemdtest <Squash-merge> <Created by mardy> <https://github.com/snapcore/snapd/pull/10748>
[08:48] <mborzecki> re
[08:48] <zyga-mbp> hey mborzecki 
[08:49] <mborzecki> zyga-mbp: hey
[08:53] <mvo> mardy: sure, done
[09:21] <mborzecki> anyone running debian sid or kali? https://forum.snapcraft.io/t/snap-apps-not-running-in-kali-linux/26542 i think it's what mvo mentioned that we need to enable snapd.apparmor.service on that distro
[09:32] <mvo> mborzecki: I did upload a new snapd that enables that late last week, I wonder if the user has the latest version from sid
[09:36] <mborzecki> mvo: they're running kali which i think pulls in packages from sid?
[09:37] <mvo> mborzecki: if so, maybe they can just test the sid package?
[09:37] <mborzecki> mvo: asked them about package version, let's see what they come back with
[10:00] <mardy> mvo: thanks, I added the test. Now I need one more +1 from someone else :-)
[10:03] <mup> PR snapd#10738 closed: o/hookstate/ctlcmd: Implement snapctl refresh --show-lock command <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/10738>
[10:04] <pstolowski> mardy: i made a remark there about adding a test for EnsureAtLeast
[10:21] <mardy> pstolowski: mmm... I don't see your comment. But indeed, I'll add a test
[10:22] <pstolowski> mardy: oh dang, it was still pending, I didn't click submit last week
[10:22] <pstolowski> you should see it now
[10:28] <mardy> yep, thanks
=== Mirv__ is now known as Mirv
[10:55] <mborzecki> hm fun with selinux, caps and bpf :/
[11:13] <mup> Bug #1943419 changed: LXD snap auto refresh stuck at copy snap data phase for 16+ hours without making progress <sts> <snapd:Triaged> <https://launchpad.net/bugs/1943419>
[11:16] <mup> Bug #1943419 opened: LXD snap auto refresh stuck at copy snap data phase for 16+ hours without making progress <sts> <snapd:Triaged> <https://launchpad.net/bugs/1943419>
[11:19] <mup> Bug #1943419 changed: LXD snap auto refresh stuck at copy snap data phase for 16+ hours without making progress <sts> <snapd:Triaged> <https://launchpad.net/bugs/1943419>
[11:29] <mborzecki> mvo: what shall we do about https://github.com/snapcore/snapd/pull/10540 ?
[11:29] <mup> PR #10540: cmd/snap-confine: handle CURRENT_TAGS on systems that support it <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10540>
[11:31] <mup> Bug #1943419 opened: LXD snap auto refresh stuck at copy snap data phase for 16+ hours without making progress <sts> <snapd:Triaged> <https://launchpad.net/bugs/1943419>
[11:34] <mup> Bug #1943419 changed: LXD snap auto refresh stuck at copy snap data phase for 16+ hours without making progress <sts> <snapd:Triaged> <https://launchpad.net/bugs/1943419>
[11:35] <mvo> mborzecki: I think merge - it has a +1 from security and we evaludated the alternatives so dlopen() it is it seems
[11:39] <mborzecki> ok
[11:48] <mborzecki> mvo: pushed one more tweak for a test failing on 14.04 and then we should be ready to land it
[12:57] <mvo> mborzecki: nice
[12:59] <mup> PR snapd#10770 closed: systemd: use text.template to generate mount unit <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10770>
[13:49] <mup> PR snapd#10771 opened: DRAFT: Tests reproduce uc20 boot error <Precious Logs> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10771>
[13:51] <mardy> miguelpires: hi! About 10767, other possibilities are "Finished", "Processed", "Completed"... Though I'm fine even with Stopped.
[13:52] <mborzecki> mvo: can you take a look at https://github.com/snapcore/snapd/pull/10661 ? the tests are looking good, so if they are green we can probably land it, or wait for pedronis?
[13:52] <mup> PR #10661: cmd/libsnap-confine-private: device cgroup v2 support <Complex> <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10661>
[13:53] <mvo> mborzecki: I would say land it, it has no needs-samuele-review and it was carefully reviewed by the team/security
[13:55] <miguelpires> mardy wanted to avoid implying that the work was actually completed since it may not have been (in the case of Error, Undone and Hold) and Stopped met that criteria I think
[14:36] <mborzecki> mvo: i think i got it now in https://github.com/snapcore/snapd/pull/10754, let's land it once it's gree and unblock builds in LP
[14:36] <mup> PR #10754: packaging, tests/lib/prepare-restore: build packages without network access, fix building debs with go modules <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10754>
[14:41] <mvo> mborzecki: nice
[14:41] <mvo> mborzecki: thanks so much for working on this! did you see https://github.com/snapcore/snapd/pull/10754/files#r705436649 btw?
[14:41] <mup> PR #10754: packaging, tests/lib/prepare-restore: build packages without network access, fix building debs with go modules <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10754>
[14:42] <mborzecki> mvo: heh, missed that, i can push a patch on top, or a followup
[14:43] <mvo> mborzecki: maybe on top is ok, ian had some similar commments afaict
[14:43] <mvo> mborzecki: and 1 more hour for the spread run is probably not too terrible at this point
[14:43] <mborzecki> ok
[14:49] <mborzecki> mvo: ok, updated and managed to cancel the previous run
[14:55] <mvo> mborzecki: ta
[15:34] <mup> PR snapd#10748 closed: systemd: add AtLeast() method, add mocking in systemdtest <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10748>
[15:38] <mvo> mborzecki: 10661 looks mostly fine, I guess that is ready for merge once spread ran?
[15:40] <mborzecki> mvo: yeah, i think so
[15:40] <mborzecki> mardy you gave thumbs down previously, can you take a look again?
[15:42]  * cachio afk
[15:42] <cachio> lunch
[15:45] <mvo> mborzecki: nice job, things are coming together it seems :)
[16:04] <ijohnson[m]> @bboozoo one question on 10661 about the security
[16:04] <ijohnson[m]> err
[16:04] <ijohnson[m]> @bboozzoo ^
[16:31] <mborzecki> ijohnson: replied, makes sense? there's CAP_BPF which in theory can separate bpf operatiosn from CAP_SYS_ADMIN, also selinux can mediate respective operations (map_create, read, write etc.)
[16:32]  * ijohnson[m] looks
=== not_phunyguy is now known as phunyguy
[21:44]  * cachio afk