[05:06] <mborzecki> morning
[05:41] <mardy> hi mborzecki, zyga-mbp 
[05:41] <zyga-mbp> hey mardy 
[05:41] <zyga-mbp> rainy cold morning here
[05:42]  * zyga-mbp writes some status reports today
[05:42] <mborzecki> mardy: zyga-mbp: hey
[06:27] <mborzecki> omg github ux has changed again, before when i clicked on a patch in a PR it would take me to that patch view, if there's just one it the same as I would be reviewing the whole PR
[06:28] <mborzecki> now you have to go to 'files changed', otherwise just clicking on a patch shows the patch in the fork repository, and comment added get added to that fork :/
[07:02] <pstolowski> morning
[07:34] <mup> PR snapd#10792 closed: packaging: backports of golang-go 1.13 are good enough <Simple 😃> <Created by xnox> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10792>
[07:38] <mborzecki> mvo: hi, can you land https://github.com/snapcore/snapd/pull/10781 ?
[07:38] <mup> PR #10781: tests: fix tests for 21.10 <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10781>
[07:39] <mup> PR snapd#10785 closed: tests: add test for store.SnapAction() request timeout <Simple 😃> <Test Robustness> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10785>
[07:39] <mup> PR snapd#10786 closed: tests: print user sessions info on debug-each <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10786>
[07:40] <mborzecki> thanks!
[07:42] <mvo> mborzecki: my pleasure, let me know if there is more that I overlooked :)
[07:42] <mvo> pstolowski: and good morning !
[07:42] <mvo> mborzecki: and good morning to you as well :)
[07:44] <mup> PR snapd#10781 closed: tests: fix tests for 21.10 <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10781>
[07:51] <pstolowski> mvo: hmmm, looks like https://github.com/snapcore/snapd/pull/10785 should have landed as the new unit test failed there, but I can't repro this failure locallly
[07:51] <mup> PR #10785: tests: add test for store.SnapAction() request timeout <Simple 😃> <Test Robustness> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10785>
[07:51] <pstolowski> *shouldn't have
[08:00] <mvo> pstolowski: uh, silly me
[08:02] <mvo> pstolowski: silly me indeed, it's just the "" that are different in latest go and current go, should be an easy fix. sorry for that
[08:03] <pstolowski> mvo: no worries, I'll prep a fix
[08:19] <mup> PR snapd#10793 opened: tests: fix regex of TestSnapActionTimeout test <⚠ Critical> <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10793>
[08:49] <mborzecki> hmm https://paste.ubuntu.com/p/2yRyJBKKK6/ failed twice in a row?
[08:50] <pstolowski> mborzecki: https://github.com/snapcore/snapd/pull/10793
[08:50] <mup> PR #10793: tests: fix regex of TestSnapActionTimeout test <⚠ Critical> <Simple 😃> <Skip spread> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10793>
[08:50] <pstolowski> mborzecki: but it seems it still needs a tweak
[08:52] <mborzecki> heh 1.17.x thing
[08:52] <pstolowski> pushed one more tweak
[09:00] <miguelpires> pstolowski I think the regex fix is missing a " before the first colon. The test fails for me at least
[09:00] <pstolowski> miguelpires: even after the tweak i pushed a few minutes ago?
[09:01] <miguelpires> Yes
[09:02] <pstolowski> miguelpires: ah, there, i see
[09:03] <pstolowski> i'm slightly confused about the diff, i'm running 1.13.8 and we've 1.13
[09:24] <mup> PR snapd#10794 opened: build-aux: fork snapcraft.yaml for riscv64 <Created by xnox> <https://github.com/snapcore/snapd/pull/10794>
[09:41] <miguelpires> mvo: can you merge https://github.com/snapcore/snapd/pull/10793 and https://github.com/snapcore/snapd/pull/10784 please?
[09:41] <mup> PR #10793: tests: fix regex of TestSnapActionTimeout test <⚠ Critical> <Simple 😃> <Skip spread> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10793>
[09:41] <mup> PR #10784: o/snapstate: add ChangeID to conflict error <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10784>
[09:49] <mvo> miguelpires: sure
[09:49] <mup> PR snapd#10784 closed: o/snapstate: add ChangeID to conflict error <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10784>
[09:49] <mup> PR snapd#10793 closed: tests: fix regex of TestSnapActionTimeout test <⚠ Critical> <Simple 😃> <Skip spread> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10793>
[10:30] <mup> Bug #1925167 changed: Path to uefi-fw-tools binary file not created <Snappy:Invalid> <https://launchpad.net/bugs/1925167>
[10:33] <mup> Bug #1925167 opened: Path to uefi-fw-tools binary file not created <Snappy:Invalid> <https://launchpad.net/bugs/1925167>
[10:45] <mup> Bug #1925167 changed: Path to uefi-fw-tools binary file not created <Snappy:Invalid> <https://launchpad.net/bugs/1925167>
[10:46] <mborzecki> hm this failed on LP: https://paste.ubuntu.com/p/9FtG8BrWN8/ related to the change ID error change from miguelpires ?
[10:54] <mup> PR snapd#10795 opened: o/assertstate: check installed snaps when refreshing validation set assertions <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10795>
[10:55] <miguelpires> mborzecki: yes, that's related to my PR. Thanks for pointing, I think I made the test flaky
[10:55] <miguelpires> *pointing it out
[10:55] <pstolowski> mborzecki: hmm looks like there was an unexpected change in state, so id ended up being 2
[10:58] <mborzecki> yeah, miguelpires does it reproduce locally with -count <some-number> ?
[11:00] <miguelpires> yes, I can trigger it locally with just a few tries
[11:19] <mup> PR snapd#10796 opened: o/devicestate: fix flaky test remodel clash <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10796>
[11:22] <pstolowski> mvo: hey, could you please land https://github.com/snapcore/snapd/pull/10782 ?
[11:22] <mup> PR #10782: o/ifacestate: do not create stray task in batchConnectTasks if there are no connections <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10782>
[11:31] <pstolowski> miguelpires: silly question there (i'm not familiar with details of remodelling)
[11:37] <miguelpires> pstolowski: I don't see your question in the PR
[11:37] <pstolowski> miguelpires: grr i did it again and forgot to submit the review; now
[11:45] <mup> PR snapd#10797 opened: usersession/client: refactor doMany() method <Created by mardy> <https://github.com/snapcore/snapd/pull/10797>
[12:08] <mborzecki> pstolowski: is there anything else we can do in https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1922293 or can it be closed now?
[12:08] <mup> Bug #1922293: Snaps appear broken on 21.04 Beta with ZFS <hirsute> <iso-testing> <snapd (Ubuntu):In Progress by stolowski> <zfs-linux (Ubuntu):Fix Released> <https://launchpad.net/bugs/1922293>
[12:10] <pstolowski> mborzecki: i think it can be closed
[12:33] <miguelpires> mvo: can you merge https://github.com/snapcore/snapd/pull/10796 please?
[12:33] <mup> PR #10796: o/devicestate: fix flaky test remodel clash <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10796>
[12:40] <mvo> miguelpires: sure
[12:45] <mup> PR snapd#10796 closed: o/devicestate: fix flaky test remodel clash <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10796>
[13:20] <mup> PR snapd#10798 opened: github: do not fail when codecov upload fails <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10798>
[13:20] <mborzecki> trivial PR ^^
[13:45] <mborzecki> mvo: can you take a look and land? ^^
[13:45] <mborzecki> (fwiw codecov uploads are failing atm)
[14:07] <ijohnson[m]> cachio_: hey have you seen either of these failures before ? https://pastebin.ubuntu.com/p/vccF9HBJjB/ and https://pastebin.ubuntu.com/p/cRPHmRQPZV/
[14:11] <ijohnson[m]> https://github.com/snapcore/snapd/pull/10799 will help unbreak master
[14:11] <mup> PR #10799: tests/main/preseed: update for new base snap of the lxd snap <⚠ Critical> <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10799>
[14:15] <mup> PR snapd#10799 opened: tests/main/preseed: update for new base snap of the lxd snap <⚠ Critical> <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10799>
[14:16] <mup> PR core#125 opened: Copy dpkg.yaml for LP Buildd <Created by ilasc> <https://github.com/snapcore/core/pull/125>
[14:17] <mup> PR core18#181 opened: Copy dpkg.yaml for LP Buildd <Created by ilasc> <https://github.com/snapcore/core18/pull/181>
[14:26] <mup> PR core20#113 opened: Copy dpkg yaml for buildd <Created by ilasc> <https://github.com/snapcore/core20/pull/113>
[14:50] <mardy_2nd> do we know if the failure to upload to codecov is a temporary failure on their side, or are there some keys that expired?
[14:53] <mborzecki> mardy_2nd: that's all there is in the log: https://paste.ubuntu.com/p/Z6T8N9YCQp/ do we need some token? ijohnson do you remember if we had to get one?
[15:00] <ijohnson[m]> bboozzoo: we didn't use to need a token, maybe we do now all of a sudden ?
[15:01] <mup> PR core20#113 closed: Copy dpkg yaml for buildd <Created by ilasc> <Merged by xnox> <https://github.com/snapcore/core20/pull/113>
[15:02] <mup> PR core18#181 closed: Copy dpkg.yaml for LP Buildd <Created by ilasc> <Merged by xnox> <https://github.com/snapcore/core18/pull/181>
[15:11] <zyga-mbp> mardy I never saw any codecov keys to begin with, perhaps just a temporary fluke?
[15:16] <mborzecki> ijohnson: ok, let's wait until tomorrow, maybe it's just temporary outage 🙂 unless we're run though our trial period or sth
[15:17] <mborzecki> that would be very 90's of them though :P
[16:00] <cachio_> ijohnson[m], no, didn't see those errores
[16:00] <mvo> mborzecki: sure, lnaded, sorry for the slow reply
[16:00] <mup> PR snapd#10798 closed: github: do not fail when codecov upload fails <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10798>
[16:01]  * cachio_ lunch
[17:37] <mardy> https://status.codecov.com/ all is green
[17:38] <mardy> but they did some release today, and maybe the last one fixes the issue: https://github.com/codecov/uploader/releases
[17:39] <ijohnson[m]> mardy: looks like they do a release on every PR, probably not a "stable" release
[22:32] <mup> PR core20#114 opened: Fix riscv64 build <Created by xnox> <https://github.com/snapcore/core20/pull/114>