| mborzecki | morning | 05:18 |
|---|---|---|
| mardy | mborzecki: hi! | 05:58 |
| mborzecki | mardy: hey | 05:58 |
| mborzecki | not much has landed since yesterday :/ | 05:59 |
| mardy | mborzecki: but now codecov seems to be working at least :-) | 06:00 |
| mardy | mborzecki: have you seen this error before? I'm trying to reproduce it locally: https://github.com/snapcore/snapd/pull/10797/checks?check_run_id=3628825501 | 06:00 |
| mup | PR #10797: usersession/client: refactor doMany() method <Created by mardy> <https://github.com/snapcore/snapd/pull/10797> | 06:00 |
| mardy | looks like a timing issue, with the test taking too long | 06:01 |
| mborzecki | mardy: yes, it's fixed in master | 06:01 |
| mardy | really? I just rebased... | 06:02 |
| mborzecki | hmmm | 06:02 |
| mborzecki | let me pull master again | 06:02 |
| mardy | I have Pawel's commit in my branch | 06:03 |
| mborzecki | ah w8, it's contxt deadline exceeded | 06:03 |
| mborzecki | yeah, a timing problem then? | 06:03 |
| mardy | I think the problem is that locally, it takes less than 5 seconds, and it passes | 06:03 |
| mardy | there, in CI, it took longer than 5 seconds | 06:04 |
| mardy | 5.77s | 06:04 |
| mborzecki | mardy: reproduced it locally https://paste.ubuntu.com/p/m4p5Gq74dF/ | 06:12 |
| mborzecki | with -count 100 | 06:12 |
| mardy | mborzecki: did you change the timeout? I see it took just 1.02 s | 06:14 |
| mborzecki | mardy: i did `cd store && go test -check.f storeActionSuite.TestSnapActionTimeout -count 100 ` | 06:14 |
| mborzecki | then it failed after some number of attempts | 06:14 |
| mborzecki | i guess ti's either hitting a context deadline set when creating a request, or there's an overarching time.After() when the request is issued somewhere in net/http | 06:15 |
| mborzecki | mardy: https://github.com/snapcore/snapd/pull/10800 | 06:17 |
| mup | PR #10800: store: one more tweak for the test action timeout <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10800> | 06:17 |
| mup | PR snapd#10800 opened: store: one more tweak for the test action timeout <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10800> | 06:18 |
| pstolowski | morning | 07:12 |
| mup | PR snapd#10800 closed: store: one more tweak for the test action timeout <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10800> | 07:13 |
| mborzecki | pstolowski: mvo: morning | 07:13 |
| mvo | good morning mborzecki and pstolowski | 07:14 |
| mborzecki | mvo: can you land https://github.com/snapcore/snapd/pull/10703 ? | 07:14 |
| mup | PR #10703: tests/main/security-device-cgroups-strict-enforced: demonstrate device cgroup being enforced <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10703> | 07:14 |
| mvo | mborzecki: sure | 07:16 |
| mborzecki | thanks! | 07:17 |
| mvo | mborzecki: does this mean it's time for a git snapshot upload to impiish? | 07:17 |
| mup | PR snapd#10703 closed: tests/main/security-device-cgroups-strict-enforced: demonstrate device cgroup being enforced <cgroupv2> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10703> | 07:18 |
| mup | PR snapd#10787 closed: tests: add a local snap variant to testing prepare-image gating support <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10787> | 07:23 |
| zyga | good morning, I'll be right back, just need to reboot for kernel updates | 07:27 |
| mup | PR snapd#10779 closed: tests/nested/manual: use loop for checking for initialize-system task done <Simple 😃> <Run nested> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10779> | 07:28 |
| mvo | zyga: good morning | 07:29 |
| mvo | pstolowski: looks like 10765 needs a master merge, failed with the timeout unit test with 1.17 | 07:29 |
| zyga | good morning mvo :) | 07:30 |
| zyga | happy Friday! | 07:30 |
| mborzecki | mvo: not yet, one more branch | 07:32 |
| zyga | congratulations on firefox snap everyone! | 07:33 |
| pstolowski | mvo: yeah, not just this one, going over my PRs atm | 07:35 |
| mup | PR snapd#10801 opened: cmd/libsnap-confine-private: use root when necessary for BPF related operations <Security-High> <Needs security review> <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10801> | 07:43 |
| mup | PR snapd#10802 opened: data/selinux: update the policy to allow s-c to manipulate BPF map and programs <Simple 😃> <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10802> | 07:43 |
| mvo | pstolowski: thanks | 07:51 |
| mborzecki | mvo: all the branches are up, i've closed the WIP one, also added cgroupv2-impish label for things that I think need to be part of the git snapshot (which is everything that's proposed, sans selinux bits) | 07:51 |
| mvo | mborzecki: which one is this? | 07:51 |
| mvo | mborzecki: aha, nice | 07:51 |
| mvo | mborzecki: thanks so much! | 07:51 |
| mborzecki | i'll try to clean up my notes and maybe propose those too as in-source-tree documentation | 07:52 |
| mup | PR snapd#10575 closed: [WIP] many: device cgroup v2 support <â›” Blocked> <cgroupv2> <Created by bboozzoo> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/10575> | 07:53 |
| mup | PR snapd#10803 opened: tests, interfaces/builtin: introduce 21.10 cgroupv2 variant, tweak tests for cgroupv2, update builtin interfaces <cgroupv2> <cgroupv2-impish> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10803> | 07:53 |
| mborzecki | meh, tests/main/auto-refresh* tests are failing now | 08:01 |
| mborzecki | mvo: https://github.com/snapcore/snapd/pull/10799/ can land now, the tests that are affected by the PR are fixed, the failing ones are unrelated | 08:01 |
| mup | PR #10799: tests/main/preseed: update for new base snap of the lxd snap <⚠Critical> <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10799> | 08:01 |
| mvo | mborzecki: +1 done | 08:10 |
| mborzecki | thanks | 08:11 |
| mup | PR snapd#10799 closed: tests/main/preseed: update for new base snap of the lxd snap <⚠Critical> <Simple 😃> <Test Robustness> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10799> | 08:13 |
| mborzecki | not bad for 21.10 now https://paste.ubuntu.com/p/v7ZRj8G5JX/ | 08:27 |
| pstolowski | mborzecki: awesome.. auto-refresh-gating? what failed there | 08:44 |
| mborzecki | pstolowski: afaiu the test expects an auto-refresh change to happen, but there isn't one, store does not return anything | 08:54 |
| pstolowski | mborzecki: ah, weird | 08:54 |
| mborzecki | from what i can tell test-snapd-refresh-control-provider snap should be refreshed after switching the channels, but perhaps the store is rate limiting refreshes now? | 08:55 |
| pstolowski | maybe logs will sched some light | 08:57 |
| pstolowski | but that's how the test works and should continue to work | 08:57 |
| mborzecki | pstolowski: well, it's failing on master too right now, i'm looking at the logs: https://paste.ubuntu.com/p/V6hhDp6nqC/ | 08:59 |
| mborzecki | this is when we expect an auto refresh :) | 08:59 |
| pstolowski | hmm | 09:00 |
| pstolowski | storehelpers.go:604: no install/refresh information results from the store | 09:00 |
| mborzecki | pstolowski: asked in mm | 09:03 |
| pstolowski | thanks | 09:04 |
| miguelpires | mvo: hi, can you merge https://github.com/snapcore/snapd/pull/10756 please? The test failures are unrelated | 09:20 |
| mup | PR #10756: cmd/snap: only log translation warnings in debug/testing <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10756> | 09:20 |
| mvo | miguelpires: sure | 09:22 |
| mup | PR snapd#10756 closed: cmd/snap: only log translation warnings in debug/testing <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10756> | 09:24 |
| pstolowski | mvo: could you please merge https://github.com/snapcore/snapd/pull/10774 ? unrelated failures | 10:06 |
| mup | PR #10774: asserts, snapstate: return full validation set keys from CheckPresenceRequired and CheckPresenceInvalid <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10774> | 10:06 |
| mvo | pstolowski: on it | 10:06 |
| pstolowski | ty | 10:07 |
| mup | PR snapd#10774 closed: asserts, snapstate: return full validation set keys from CheckPresenceRequired and CheckPresenceInvalid <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10774> | 10:09 |
| mup | PR core20#114 closed: Fix riscv64 build <Created by xnox> <Merged by xnox> <https://github.com/snapcore/core20/pull/114> | 10:22 |
| mup | PR snapcraft#3581 opened: packaging: load the correct libraries on riscv64 <Created by xnox> <https://github.com/snapcore/snapcraft/pull/3581> | 11:28 |
| pstolowski | mvo: could you also land https://github.com/snapcore/snapd/pull/10765 ? | 12:05 |
| mup | PR #10765: o/snapstate: enforce validation sets/enforce on InstallMany <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10765> | 12:05 |
| mborzecki | re | 12:16 |
| mborzecki | heh that took a while | 12:16 |
| pstolowski | mborzecki: all fine? | 12:20 |
| mborzecki | yeah, got one more checkup on sunday, but seems to be fine so far | 12:20 |
| pstolowski | great | 12:26 |
| mardy | mvo: can you please use your merging powers on https://github.com/snapcore/snapd/pull/10772? | 12:48 |
| mup | PR #10772: kernel/fde: mock systemd-run in unit test <Created by mardy> <https://github.com/snapcore/snapd/pull/10772> | 12:48 |
| mardy | BTW, the tests there are failing because of some time tolerance issue: https://pastebin.ubuntu.com/p/g76qTyBhC7/ Is anyone working on it (I could take a look, otherwise) | 12:49 |
| ijohnson[m] | mardy yeah I've seen that a bunch I think there's a time sync that happens or something because the test definitely is not executing for 45 minutes like the time difference would suggest | 12:54 |
| ijohnson[m] | But I'm not working on that failure | 12:54 |
| mardy | ah, now I see, it's the same test that once failed at midnight | 12:58 |
| mardy | so, this test does not appear to be doing any refresh on its own :-) | 12:59 |
| mardy | it just assumes that some other test must have been run before, which triggered a refresh | 13:00 |
| mardy | but whether that took 10 minutes or more, it depends from the order of the tests | 13:00 |
| mup | PR snapd#10765 closed: o/snapstate: enforce validation sets/enforce on InstallMany <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10765> | 13:14 |
| pstolowski | miguelpires: see tests/main/interface-hooks test | 13:23 |
| miguelpires | pstolowski: thank you! | 13:24 |
| mup | PR snapd#10804 opened: [Feat] Add @squash rule support to snap-seccomp <Created by diddledani> <https://github.com/snapcore/snapd/pull/10804> | 13:29 |
| mup | PR snapd#10805 opened: overlord/devicestate: make settle wait longer in remodel tests <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10805> | 13:54 |
| mborzecki | trivial pr ^^ | 13:56 |
| mup | PR snapd#10806 opened: tests: rename interfaces-hooks-misbehaving spread test to install-hook-misbehaving <Simple 😃> <Skip spread> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10806> | 14:20 |
| pstolowski | and this ^ | 14:21 |
| diddledani | @jdstrand I'm working on getting per-rule squashing of seccomp denial logs.. I think I've got the snap-seccomp bits done, but it's still logging, so I'm wondering if I need to make changes in libseccomp-go. Any idea what I need to look for to generate a per-rule no-log? | 14:34 |
| mborzecki | pstolowski: https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1943853 looks like a problem with snapd loosing all connections | 15:21 |
| mup | Bug #1943853: Recent update DELETED SNAP PROGRAMS <amd64> <apport-bug> <hirsute> <wayland-session> <snapd:Incomplete> <snapd (Ubuntu):Incomplete> <https://launchpad.net/bugs/1943853> | 15:22 |
| pstolowski | mborzecki: oh well, we don't have snap changes, do we? | 15:24 |
| mborzecki | pstolowski: there's no way to auto connect things again right? | 15:25 |
| pstolowski | mborzecki: no | 15:27 |
| pstolowski | mborzecki: and no snaps are broken, very weird | 15:28 |
| mborzecki | pstolowski: the connections are clearly gone | 15:28 |
| pstolowski | mborzecki: or repo and conns are out of sync for some weird reason, but maybe snap connections uses conns directly these days | 15:29 |
| pstolowski | mborzecki: can you ask him for snap changes & snap change <id> if there were errors? | 15:30 |
| mborzecki | pstolowski: ok, sent a request | 15:32 |
| pstolowski | ty | 15:33 |
| mborzecki | pstolowski: https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1943853/comments/14 meh, looks like it was garbage collected, any ideas how we can help this poor soul? | 15:46 |
| mup | Bug #1943853: Recent update DELETED SNAP PROGRAMS <amd64> <apport-bug> <hirsute> <wayland-session> <snapd:Incomplete> <snapd (Ubuntu):Incomplete> <https://launchpad.net/bugs/1943853> | 15:46 |
| pstolowski | mborzecki: dang, I don't think we will be able to figure what happened without changes :( | 15:54 |
| ijohnson[m] | I really hate some days the fact that we so aggressively garbage collect changes | 15:55 |
| pstolowski | ijohnson[m]: yes | 15:57 |
| pstolowski | also, seems like we regressed with snap disconnect <snapname> and it must happened a very long time ago, filing a bug | 15:58 |
| pstolowski | or actually maybe not, but there is a confusing message with snap disconnect foo: | 16:00 |
| pstolowski | yeah i think it's just the message problem | 16:08 |
| pstolowski | fyi https://bugs.launchpad.net/snapd/+bug/1943987 | 16:08 |
| mup | Bug #1943987: snap disconnect <snapname>: prints a confusing error <snapd:New> <https://launchpad.net/bugs/1943987> | 16:08 |
| mborzecki | also bit of a bummer right now, as I have no ide how to restore the connections other than just manaully running snap connect for all eligible plugs | 16:12 |
| mborzecki | or snap remove & snap install but that would remove their data | 16:12 |
| mborzecki | so snap save? | 16:12 |
| ijohnson[m] | yeah that's what I was going to suggest them to do to restore their system is just snap connect everything | 16:12 |
| mborzecki | ijohnson: but then all connections would be flagged as manual, wouldn't they? | 16:13 |
| ijohnson[m] | oh hmm | 16:13 |
| ijohnson[m] | but what's the problem with that ? | 16:13 |
| mborzecki | ijohnson: afaiu some plugs are not auto connected, so i we iterate blindly and connect everythign the end result will be dierent than what auto connect does | 16:14 |
| mborzecki | ijohnson: so what i'm really missing is maybe `snap connect --eligible <snap>` | 16:15 |
| mup | PR snapd#10807 opened: tests/nested/manual/core20-cloud-init-maas-signed-seed-data: add gadget variant <Test Robustness> <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10807> | 16:15 |
| ijohnson[m] | I was just going to install all the snaps manually so the auto-connections process in a known good machine and then just have them manually connect all of those | 16:15 |
| ijohnson[m] | snap connect --eligible feels like it's just there to fix a bug that shouldn't happen in the first place | 16:15 |
| pstolowski | so I suspect we lost all the connections because at some moment there was a lot of " cannot read snap info of snap "core" at revision 11606: cannot find installed snap "core" at revision 11606: missing file /snap/core/11606/meta/snap.yaml" errors in the log | 16:17 |
| pstolowski | but it's no clear how this leads to removing of connections, needs investigation | 16:17 |
| pstolowski | fwtw core isn't broken in his snap list, so it recovered | 16:19 |
| pstolowski | ijohnson[m]: i wonder if reinstalling core/snapd wouldn't fix it | 16:19 |
| ijohnson[m] | how would you reinstall core/snapd though | 16:19 |
| ijohnson[m] | without removing all the snaps | 16:20 |
| pstolowski | ijohnson[m]: snap refresh --beta snapd etc, i.e. switch channels | 16:20 |
| pstolowski | doing this here creates Automatically connect eligible plugs and slots of snap "snapd" task | 16:25 |
| ijohnson[m] | Hmm maybe I'm not sure | 16:25 |
| ijohnson[m] | Worth a try though, that operation couldn't delete the files at all | 16:25 |
| pstolowski | ok, i sugested that, and that's EOW | 16:27 |
| pstolowski | have a nice weekend, cu o/ | 16:27 |
| ijohnson[m] | bye! you too | 16:28 |
| diddledani | so I don't think snapd can disable logging on a per rule basis until kernel changes are made to not enforce logging which was added at: https://bugs.launchpad.net/snapd/+bug/1721676 | 16:31 |
| mup | Bug #1721676: implement errno action logging in seccomp for strict mode with snaps <verification-done-xenial> <verification-done-zesty> <snapd:Fix Released by tyhicks> <linux (Ubuntu):Fix Released by tyhicks> <linux (Ubuntu Xenial):Fix Released by tyhicks> <linux (Ubuntu Zesty):Fix Released by | 16:31 |
| mup | tyhicks> <linux (Ubuntu Artful):Fix Released by tyhicks> <https://launchpad.net/bugs/1721676> | 16:31 |
| mup | PR snapd#10808 opened: cmd/snap-seccomp: add riscv64 support <Created by xnox> <https://github.com/snapcore/snapd/pull/10808> | 18:05 |
| === alan_g__ is now known as alan_g | ||
| mup | PR snapcraft#3582 opened: github: update snapcore/action-build dep <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3582> | 21:29 |
| mup | PR snapd#10809 opened: .github/workflows/test.yaml: bump action-build to 1.0.9 <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10809> | 22:31 |
| mup | PR snapcraft#3582 closed: github: update snapcore/action-build dep <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3582> | 23:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!