| mup | PR snapcraft#3583 opened: build providers: snapcraft's new base is core20 (CRAFT-544) <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3583> | 01:42 |
|---|---|---|
| === popey2 is now known as popey | ||
| mup | Bug #1944625 changed: snapctl returns EOF <snapd:Incomplete> <https://launchpad.net/bugs/1944625> | 05:56 |
| pstolowski | morning | 07:03 |
| mup | PR snapd#10822 closed: spread: display information about current device cgroup in debug dump <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10822> | 07:20 |
| mup | PR snapd#10823 closed: sysconfig: set TMPDIR in tests to avoid cluttering the real /tmp <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10823> | 07:20 |
| mup | PR snapd#10814 closed: o/ifacestate: don't lose connections if snaps are broken <Squash-merge> <Bug> <cherry-picked> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10814> | 07:30 |
| mup | PR snapd#10715 closed: secboot: move to new version <Run nested> <Created by xnox> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10715> | 07:35 |
| mardy | pstolowski: hi! | 07:53 |
| mup | PR snapd#10815 closed: fde: add HasDeviceUnlock() helper <Simple 😃> <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10815> | 07:55 |
| mup | PR snapd#10830 opened: gadget: add `encryptedDevice` and add encryptedDeviceLUKS <Simple 😃> <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10830> | 07:55 |
| pstolowski | mvo: could you please merge https://github.com/snapcore/snapd/pull/10810 ? | 08:47 |
| mup | PR #10810: o/assertstate, api: update validation set assertions only when updating all snaps <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10810> | 08:47 |
| mvo | sure | 08:47 |
| mup | PR snapd#10810 closed: o/assertstate, api: update validation set assertions only when updating all snaps <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10810> | 08:50 |
| pstolowski | thanks! | 09:46 |
| miguelpires | Hi. Can someone tell me why does snapd create directories under /root/snap/ when installing? Is it intended behavior or should it be using the user's home? | 10:16 |
| pstolowski | miguelpires: are you sure? i just did a quick test and don't see it. this normally happens if you run the snap for the first case as the given user | 10:18 |
| pstolowski | s/case/time/ | 10:18 |
| miguelpires | Yeah, I just tried installing again and it's there, so it's created during install (I assumed because installed as root). Then when doing snap run, the app's files are written to ~/snap so /root/snap is just empty | 10:21 |
| miguelpires | Also, I noticed this while testing my ~/.snap changes, there were AppArmor denials for /root/.snap | 10:22 |
| pstolowski | miguelpires: ok, i think the first depends on whether the snap has hooks or not | 10:27 |
| pstolowski | miguelpires: i can confirm /root/snap/skype gets created on install for skype, but not for hello-world snap | 10:27 |
| pstolowski | because skype has configure hook | 10:27 |
| pstolowski | (which does nothing :}) | 10:27 |
| pstolowski | miguelpires: these user directories get created by snap run (cmd_run.go) for the user who executes it, and hooks are run via snap run --hook=... by snapd as root user | 10:30 |
| pstolowski | makes sense? | 10:30 |
| miguelpires | Ah, then it's intended for that case. I saw that snap-confine was getting permission denied during the install when writing to /root/snap because it was called by 'snap run --hook'. I wasn't sure why the directory was different | 10:30 |
| miguelpires | yes, exactly. Makes sense. Thank you | 10:30 |
| pstolowski | yw | 10:31 |
| mup | PR snapd#10831 opened: osutil: add new `CreateLinearMapper` helper <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10831> | 11:05 |
| miguelpires | mvo: can you please merge https://github.com/snapcore/snapd/pull/10630 ? AFAICT, the failures are unrelated | 11:45 |
| mup | PR #10630: o/snapstate: update default provider if missing required content <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10630> | 11:45 |
| mvo | miguelpires: sure | 12:00 |
| mup | PR snapd#10630 closed: o/snapstate: update default provider if missing required content <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10630> | 12:01 |
| miguelpires | ty | 12:04 |
| mup | PR snapd#10832 opened: tests: skip system-usernames-microk8s when TRUST_TEST_KEYS is false <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10832> | 12:21 |
| pstolowski | damn, conflicts when merging large test files (here: snapstate_update_test.go) can be quite confusing | 12:45 |
| miguelpires | mvo: can you merge https://github.com/snapcore/snapd/pull/10812 please? The test failures are unrelated | 13:33 |
| mup | PR #10812: o/ifacestate: don't fail remove if disconnect hook fails <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10812> | 13:33 |
| mup | PR snapd#10833 opened: tests: fix error trying to create the extra-snaps dir which already exists <Simple 😃> <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10833> | 14:01 |
| mup | PR snapcraft#3583 closed: build providers: snapcraft's new base is core20 (CRAFT-544) <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3583> | 14:23 |
| cachio_ | ijohnson[m], hi, I see this in the netplan test https://paste.ubuntu.com/p/sm7kP7Gzc3/ | 14:28 |
| cachio_ | should we skip it, right? | 14:29 |
| cachio_ | core20 snap is not available on i386 | 14:29 |
| ijohnson[m] | cachio_: yes good catch | 14:30 |
| cachio_ | still don't know why it is not failing on ubuntu-18-32 | 14:31 |
| cachio_ | ijohnson[m], any idea? | 14:31 |
| cachio_ | ahh, it is not executed tehre | 14:32 |
| cachio_ | is in the core suite | 14:32 |
| mvo | ijohnson[m]: thanks for your feedback about 10831 any opinion on the https://github.com/snapcore/snapd/pull/10831/files#r714698094 maybe? | 14:32 |
| mup | PR #10831: osutil/disks: add new `CreateLinearMapper` helper <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10831> | 14:32 |
| ijohnson[m] | mvo did you mean more opinions? I left some opinions, not sure I have more I can try and think of some more if you like haha | 14:34 |
| mvo | ijohnson[m]: I meant specifically about the suggestion from alberto what kind of "size" should be passed in - or did a miss a comment from you there maybe :) ? | 14:34 |
| ijohnson[m] | Oh sorry the link didn't work for me to see that comment | 14:35 |
| ijohnson[m] | Let me take a look | 14:35 |
| ijohnson[m] | Maybe I do have more opinions for you | 14:35 |
| ijohnson[m] | :-) | 14:35 |
| mvo | ijohnson[m]: excellent, sorry if I pasted the wrong link! | 14:37 |
| ijohnson[m] | mvo: I think the link to the comment you pasted was before you pushed the updates, so it references a comment that doesn't exist, whereas if you grab the link from the main PR page and not the files one, that is more "persistent" | 14:39 |
| ijohnson[m] | mvo: oh noes though you are hard-coding the block size | 14:40 |
| ijohnson[m] | or wait was it sector size that was the problem | 14:40 |
| mvo | ijohnson[m]: yeah, afaik blocks are ok | 14:43 |
| mup | PR snapd#10834 opened: tests: fix netplan test on i386 architecture <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10834> | 14:46 |
| ijohnson[m] | mvo: ok I left a review for you | 14:51 |
| mup | PR snapd#10828 closed: tests: cleanup the job workspace as first step of the actions workflow <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10828> | 14:51 |
| mup | PR snapd#10829 closed: tests: use our own image for ubuntu impish <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10829> | 14:51 |
| ijohnson[m] | cachio_: +1 to that PR thanks for catching that too | 14:51 |
| cachio_ | ijohnson[m], yaw | 14:52 |
| mvo | ijohnson[m], mardy pr updated | 14:57 |
| mup | PR snapd#10835 opened: tests: fix lxd-mount-units test which is based on core20 in ubuntu focal system <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10835> | 15:06 |
| ijohnson[m] | mvo: I think #7700 is ready to land now | 15:34 |
| mup | PR #7700: cmd/snap: wait while inhibition file is present <Needs Samuele review> <:birthday:> <Created by zyga> <https://github.com/snapcore/snapd/pull/7700> | 15:34 |
| mvo | ijohnson[m]: yay | 15:34 |
| ijohnson[m] | 🙂 | 15:35 |
| mup | PR snapd#7700 closed: cmd/snap: wait while inhibition file is present <Needs Samuele review> <:birthday:> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/7700> | 15:41 |
| ijohnson[m] | \o/ | 15:42 |
| mvo | ijohnson[m]: I also updated the mapper one :) | 15:45 |
| ijohnson[m] | thanks! | 15:50 |
| * mvo hugs mardy pstolowski ijohnson[m] for their excellent reviews | 15:57 | |
| zyga-mbp | woot, I'm so happy to see those branches finished and merged :) | 16:40 |
| mup | PR snapd#10836 opened: many: add experimental setting to move ~/snap to ~/.snap/data <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10836> | 23:28 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!