[05:43] <mborzecki> morning
[06:10] <zyga-mbp> good morning
[06:14] <mardy> zyga-mbp: hi!
[06:14] <zyga-mbp> hey mardy 
[06:15] <zyga-mbp> I'm looking at bunch of random spread reboot failures, where after reboot stuff fails to connect inside Go's ssh library, apparently due to lack of compression support
[06:15] <zyga-mbp> have you guys seen this at all? this is always against the qemu target
[06:16] <zyga-mbp> all I have so far is https://go.googlesource.com/crypto/+/master/ssh/mux.go#328 this line
[06:25] <mardy> zyga-mbp: not that I know of (I actually never tried to use qemu with the spread)
[06:26] <zyga-mbp> I don't think it's specific to qemu
[06:26] <zyga-mbp> feels like a bug in go's ssh implementation
[06:26] <zyga-mbp> googling for that error text makes is clear this is a widespread issue
[06:26] <zyga-mbp> I really wonder why it happens with increased frequency now
[06:27] <zyga-mbp> my tests run against hirsute 
[06:27] <zyga-mbp> perhaps something got updated
[06:36] <dust> thunderbird snap... is there a documentation where thunderbird stores all its mails, calendar data and so on?
[06:38] <mborzecki> zyga-mbp: mardy: hey
[06:38] <mup> PR snapd#10922 closed: none: dummy commit <Run nested> <Created by mvo5> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/10922>
[06:39] <zyga-mbp> hey mborzecki :)
[06:40] <ogra> dust, snaps typically store their data somewhere under ~/snap/<snapname>/common or ~/snap/<snapname>/current ... take a look there 
[06:40] <mardy> mborzecki: hi!
[06:48] <dust> ogra, thanks
[07:07] <pstolowski> morning
[07:10] <zyga-mbp> hey pstolowski 
[07:27] <mardy> pstolowski: hi!
[08:24] <mup> PR snapd#10932 closed: tests/nested/core/core20-create-recovery: fix passing of data to curl <Simple 😃> <Run nested> <Created by bboozzoo> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10932>
[08:28] <zyga-mbp> congratulations on shipping impish :)
[08:34] <mup> PR snapd#10931 closed: interface/modem-manager: add accept for MBIM/QMI proxy clients <Simple 😃> <Created by alfonsosanchezbeato> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10931>
[08:39] <mup> PR snapd#10926 closed: tests: remove extra-snaps-assertions test <Created by sergiocazzolato> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10926>
[08:44] <mup> PR snapd#10904 closed: osutil/disks, many: switch to defining Partitions directly for MockDiskMapping <Simple 😃> <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10904>
[08:49] <mup> Bug #1947563 opened: snapd execs /usr/lib/snapd/snap-seccomp despite libexecdir set to /usr/libexec <Snappy:New> <https://launchpad.net/bugs/1947563>
[08:49] <mup> PR snapd#10873 closed: interfaces/builtin: Add '/com/canonical/dbusmenu' path access to 'unity7' interface <Created by twang2218> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10873>
[08:49] <mup> PR snapd#10927 closed: interfaces/builtin/hardware-observer: add /proc/bus/input/devices too <Simple 😃> <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10927>
[09:59] <mup> PR snapd#10917 closed: many: mv MockDeviceNameDisksToPartitionMapping -> MockDeviceNameToDiskMapping <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10917>
[09:59] <mup> PR snapd#10938 opened: tests: skip connection of netlink interface on older systems <Created by mardy> <https://github.com/snapcore/snapd/pull/10938>
[10:06] <miguelpires> Hey. I'm having some trouble running some of the spread tests, maybe I'm missing something obvious . The suite prepare fails on `snap install --edge core error: cannot perform the following tasks: - Copy snap "core" data (no state entry for key)` 
[10:08] <miguelpires> The full output is here https://pastebin.canonical.com/p/GtTX58pWFN/ 
[10:10] <miguelpires> If someone has any idea what the issue could be, I'd appreciate the help :] 
[10:16] <pstolowski> miguelpires: is this on your branch with snap folder changes?
[10:21] <pstolowski> miguelpires: unfortunately "no state entry for key" is one of the least helpful errors we have :( unless decorated with additional info. i'd start with looking at doCopySnapData() and add extra debug around all err handling there
[10:21] <miguelpires> Yes, I guess "core" isn't supposed to have state 
[10:21] <miguelpires> ?
[10:21]  * zyga-mbp miguelpires it's a sign of missing error handling
[10:21] <pstolowski> miguelpires: no, this error is about a st.Get("...") not finding a requested key (can be snapstste.Get(..) for example)
[10:21]  * zyga-mbp it's the error that should never surface higher
[10:22]  * zyga-mbp yeah, pstolowski is right, calls like that are guarded against no state usually
[10:22] <miguelpires> I see, thanks!
[10:25] <pstolowski> miguelpires: we often explicitly handle such error by checking if err is state.ErrNoState
[12:01] <mardy> pstolowski: thanks for the review on https://github.com/snapcore/snapd/pull/10938, but I'd need another one since I had to change it considerably :-)
[12:01] <mup> PR #10938: tests: skip connection of netlink interface on older systems <Created by mardy> <https://github.com/snapcore/snapd/pull/10938>
[12:15] <mup> PR snapd#10847 closed: cmd/snap-confine: die when snap process is outside of snap specific cgroup <cgroupv2> <Created by bboozzoo> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10847>
[12:19] <pstolowski> mardy: oh indeed, i  think you should change "tests: " prefix and it may need security review
[12:48] <mardy> pstolowski: I don't think we need to involve security, since this PR is restricting the access
[12:48] <pstolowski> mardy: right, indeed
[12:55] <mup> PR snapd#10939 opened: tests: spread test for validation sets enforcing <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10939>
[13:35] <ijohnson[m]> mardy: so which specific test /variant is it that was failing?
[14:05] <mardy> ijohnson[m]: the issue I was talking about in the standup is on ubuntu-core-18 (maybe also UC 20, but I'm not sure). The PR is https://github.com/snapcore/snapd/pull/10935
[14:05] <mup> PR #10935: tests: wait for snapd to be fully setup before installing snaps <Created by mardy> <https://github.com/snapcore/snapd/pull/10935>
[14:06] <mardy> ijohnson[m]: the service unit seems correct, it has Requires and After: https://paste.ubuntu.com/p/gGVwCtrXYj/
[14:07]  * ijohnson[m] looks
[15:36] <mup> PR snapd#10940 opened: tests: force 16.04 packaging when doing test snapd-snap build <Created by xnox> <https://github.com/snapcore/snapd/pull/10940>
[16:14] <ijohnson[m]> miguelpires: hey just FYI when we ask for more information on bugs like in https://bugs.launchpad.net/snapd/+bug/1946996, we set the status to "Incomplete"
[16:14] <mup> Bug #1946996: snapd: slice bounds out of range <snapd:New> <https://launchpad.net/bugs/1946996>
[16:27] <miguelpires> ijohnson[m]: ok, I'll do that now :]  thanks
[16:46] <mup> PR snapd#10930 closed: secboot: revert move to new version (revert #10715) <⚠ Critical> <Run nested> <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10930>
[16:53] <ogra> miguelpires, note that incomplete bugs expire automatically after 60 days though 
[16:53] <ogra> (i.e. if you want to keep it around even after that and without user reply, pick another status)
[16:56] <mup> PR snapd#10929 closed: tests/nested/manual: add regression test with old/existing initrd and new snapd <⛔ Blocked> <Run nested> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/10929>
[17:37] <miguelpires> ogra, I see, thanks for the heads up