[06:02] <mborzecki> morning
[06:47] <mborzecki> time to grab some coffee
[06:51] <mardy> mborzecki: 'morning
[06:51] <mborzecki> mardy: hey
[06:53] <pstolowski> morning
[07:00] <mborzecki> pstolowski: hey
[07:09] <mborzecki> pstolowski: wonder if that problem with refresh-candidates in state is just corrupted state.json
[07:35] <pstolowski> mborzecki: yeah i don't see anything wrong right now, st.set and st.get look fine. i wonder though if at some point it wasn't an array and got changed to map (in master/edge only), i need to check git changes
[07:39] <mborzecki> pstolowski: hm i don't recall any recent changes in that area
[07:41] <pstolowski> mborzecki: i did plenty of changes
[07:41] <pstolowski> for refresh-control
[07:42] <pstolowski> this error is from the new code
[07:42] <mborzecki> pstolowski: hmm interesting
[07:47] <pstolowski> mborzecki:  git show ea26b8e9eb882dc7ecae249bf2403b1c6edd9cfa
[07:47] <pstolowski> that's it
[07:50] <pstolowski> https://github.com/snapcore/snapd/pull/10182
[07:50] <mup> PR #10182: o/snapstate: autorefresh phase1 for refresh-control <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/10182>
[07:57] <pstolowski> so https://github.com/snapcore/snapd/pull/10167 introduced refresh-candidates in state as an array
[07:57] <mup> PR #10167: o/snapstate: store refresh-candidates in the state <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10167>
[07:58] <pstolowski> and https://github.com/snapcore/snapd/pull/10182 changed it to map
[07:58] <mup> PR #10182: o/snapstate: autorefresh phase1 for refresh-control <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/10182>
[07:59] <mborzecki> hmm
[07:59] <mborzecki> was any of those part of the stable releases?
[07:59] <pstolowski> and they landed almost 1 month apart
[07:59] <pstolowski> i'm about to check that
[08:00] <pstolowski> fwtw any refresh/autorefresh should fix this
[08:00] <pstolowski> so it's a bit unclear why is he in this state
[08:15] <zyga-mbp> mborzecki hey, I saw your request, I'll review it shortly
[08:15] <mborzecki> zyga-mbp: thanks
[08:17]  * zyga-mbp mborzecki and done
[08:17] <zyga-mbp> I had a look at the diff earlier but didn't have my auth to approve
[08:18] <mborzecki> zyga-mbp: thanks, this shoudl fix people updating on 15.3 where we did not build with apparmor before
[08:18] <zyga-mbp> right
[08:18] <zyga-mbp> little by little, that's nice progress
[08:27] <pstolowski> mborzecki: it seems it was never released in the in-between state. was introduced in 2.51 as a map
[08:27] <mborzecki> pstolowski: but was in edge right?
[08:27] <pstolowski> mborzecki: yes
[08:28] <pstolowski> i'm going to reply on the forum
[08:28] <mborzecki> great, let's see if they're tracking edge
[11:51] <mborzecki> funny how submitting a review in github sometimes makes the little notification banner go away
[12:15] <mup> PR snapd#10984 closed: data/selinux: allow snap-confine to read udev's database <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10984>
[12:19] <mardy> mborzecki: what does the postrm script do? Is it a shortcut to quickly remove all installed snaps when uninstalling snapd?
[12:20] <mborzecki> mardy: take a look at debian/snapd.postrm, it's invoked when you call `apt remove --purge`
[12:21] <mborzecki> other distros use snap-mgmt --purge for this, as their hooks run before the package is actually removed
[12:21] <mardy> mborzecki: yes, I found it, I just want to make sure I understand the goal
[12:22] <mborzecki> so the goal is to clean up everything snapd generated
[12:32] <ijohnson[m]> mardy: bboozzoo I made a proposal in 10918, can you take a look today before EOW?
[12:39] <mardy> ijohnson[m]: only if you will have a look at the mount-control one! ;-)
[12:39] <ijohnson[m]> mardy: I will try very hard to look at it today 🙂
[12:40] <mup> PR snapd#10690 closed: tests: split test tools - part 1 <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10690>
[12:40] <mup> PR snapd#10863 closed: tests: fix nested tests on uc20 <Run nested> <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10863>
[12:49] <ijohnson[m]> mardy: will there be a mount-control step 3 BTW?
[12:50] <ijohnson[m]> is step-3 to enable the persistent auto-mounting ?
[12:56] <mardy> ijohnson[m]: yes, the branch is already there, I need to clean it up after mount-control-2 lands
[12:56] <mardy> ijohnson[m]: I added a comment to 10918, I think that if you add an "s" to the function name it would be perfect :-)
[13:00] <ijohnson[m]> mardy: ack, thoughts on doing it in this PR or as a followup ?
[14:01] <mardy> ijohnson[m]: normally I would say we could do it later, but here it looks like you didn't even push your code, so I think you are still in time to make the changes :-)
[14:01] <mardy> (at least I don't see your suggested code in the diff)
[14:01] <ijohnson[m]> yeah I haven't pushed it, wondering if we could just merge it and do it in simpler/smaller followups
[14:02] <ijohnson[m]> to be clear, I am going to make the suggested change to UsableSectorsEnd and update the doc-comments
[14:35] <mardy> ijohnson[m]: ah, you mean merging the current one, and then apply your suggestions as a follow-up? Sounds good to me!
[14:36] <ijohnson[m]> mardy: great, would you mind giving it a +1 so I can get mvo to force merge it, then I will open up the follow-up immediately afterwards ?
[14:39] <mardy> ijohnson[m]: done!
[14:41] <ijohnson[m]> thanks
[14:45] <mup> PR snapd#10918 closed: osutil/disks: add methods to replace gadget/ondisk functions  <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10918>
[14:45] <mup> PR snapd#10933 closed: interfaces: suppress denial of sys_module capability <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10933>
[15:08] <ijohnson[m]> mardy: bboozzoo I opened https://github.com/snapcore/snapd/pull/10986, feel free to review on Monday if it's your EOD already
[15:08] <mup> PR #10986: osutil/disks: re-org methods for end of usable region, size information <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10986>
[15:09] <ijohnson[m]> I will be rebasing all the other PR's on top of this one
[15:10] <mup> PR snapd#10986 opened: osutil/disks: re-org methods for end of usable region, size information <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10986>
[15:17] <mardy> ijohnson[m]: I had a quick look now, +1 (one request to update a comment that IMHO became important with these changes, but that can also be a follow-up)
[15:17] <ijohnson[m]> mardy: this one I opened with skip-spread so I can push things there easily 🙂
[15:30] <mup> PR snapd#10987 opened: o/snapstate: keep old revision if install doesn't add new one <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10987>
[16:46] <mup> PR snapd#10983 closed: spread: run lxd tests with version from latest/edge <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10983>
[16:51] <mup> PR snapd#10988 opened: tests: enable lxd tests on 21.10 too <Created by mvo5> <https://github.com/snapcore/snapd/pull/10988>
=== E_Eickmeyer is now known as Eickmeyer
[18:16] <mup> PR snapd#10988 closed: tests: enable lxd tests on 21.10 too <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10988>