[07:22] <mborzecki> morning
[07:30] <mardy> mborzecki: hi!
[07:33] <mborzecki> mardy: hey, anything interesting on thu/fri?
[07:43] <mardy> mborzecki: can't recall, but it may also be that my memory tends to wane faster during the weekends :-)
[08:04] <pstolowski> morning
[08:06] <mardy> pstolowski: hi!
[08:06] <mardy> and mvo :-)
[08:06] <mardy> do we have spread tests which run the debian/ubuntu postrm script?
[08:06] <mvo> good morning pstolowski and mardy and mborzecki 
[08:06] <mborzecki> pstolowski: mvo hey
[08:07] <mardy> (just wondering because I've a small fix to that, and if the tests don't exercise it, then I'd add the skip-spread label)
[08:07] <mvo> mardy: iirc we have something called postrm-purge and snapmgmt
[08:07] <mardy> mvo: ok, no skip-spread then :-)
[08:07] <mvo> mborzecki: will it be hard to have a spread test for 11039?
[08:08] <mvo> mardy: is something broken?
[08:08] <mvo> mardy: oh, I see there is a new pr from you, let me look
[08:09] <mardy> mvo: not that seriously, but we got a bug report in LP last week
[08:09] <mup> PR snapd#11055 opened: packaging: make postrm script robust against `rm` failures <Simple 😃> <Created by mardy> <https://github.com/snapcore/snapd/pull/11055>
[08:10] <mborzecki> mvo: a reliable test for this may be tricky
[08:10] <mborzecki> i'll take a look, maybe getting something sensible it's that complicated
[08:28] <mup> PR core20#118 closed: hooks: change folder where to save bootcharts <Created by alfonsosanchezbeato> <Merged by mvo5> <https://github.com/snapcore/core20/pull/118>
[09:09] <mup> PR snapd#11040 closed: o/snapstate: remove repeated test assertions <Simple 😃> <Skip spread> <Created by MiguelPires> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/11040>
[09:45] <mborzecki> anyone seen this? https://pastebin.ubuntu.com/p/JTcr7WxtdC/ snap-confine gets blocked by apparmor when trying to enumerate devices
[09:58] <pstolowski> mvo: hey, should I look at https://github.com/snapcore/snapd/pull/11050#issuecomment-968698673 and add --quiet?
[09:58] <mup> PR #11050: tests: the `lxd` test is failing right now on 21.10 <Flaky Test> <Created by mvo5> <https://github.com/snapcore/snapd/pull/11050>
[10:03] <mvo> pstolowski: yes please! one complication is that older version of systemd do not have --quiet so we need to add a version check and do a little bit of digging when exactly --quiet got added
[10:04] <mvo> pstolowski: but should be hopefully straightfoward :)
[10:04] <pstolowski> mvo: great, good you mentioned this, i didn't know that. will do
[10:06] <mvo> pstolowski: my pleasure
[10:29] <mborzecki> mvo: ok, i've modified existing device cgroup test in 11039 and hopefully it will be stable
[10:29] <mborzecki> pushing in a bit
[10:29] <mvo> mborzecki: \o/
[10:44] <mborzecki> mvo: and pushed, please take a look
[10:54] <mvo> mborzecki: looking now (but will have a meeting soon), first glance looks very encouraging :)
[10:55] <mup> PR snapd#10907 closed: interfaces: timezone-control, add permission for ListTimezones DBus call <Squash-merge> <Created by ogra1> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10907>
[10:55] <mborzecki> damn, got another reminder about hr tranings
[10:57] <pstolowski> mvo: pushed as a draft, let's see how spread likes it
[10:59] <mvo> pstolowski: \o/
[11:00] <mup> PR snapd#11056 opened: Append --quiet to udevadm trigger ... calls with newer systemd (>=248) <Created by stolowski> <https://github.com/snapcore/snapd/pull/11056>
[11:02] <pstolowski> mvo: i'm slightly confused about what may cause an error with trigger; i couldn't provoke any error by calling trigger manually on 21.10 with silly properties for example
[11:02] <pstolowski> but maybe it's very specific to running inside lxc
[11:14] <mup> PR snapcraft#3595 opened: set lzo compression by default in kde-neon extension <Created by jriddell> <https://github.com/snapcore/snapcraft/pull/3595>
[11:25] <mvo> pstolowski: it seems to be super specific
[11:25] <mvo> pstolowski: your PR seems to fail on spellcheck or something, let me know if I can help
[11:26] <pstolowski> ah, sorry, let me fix that
[13:05] <mup> PR snapd#11031 closed: interfaces/u2f-devices: add Trezor and Trezor v2 keys (https://launchpad.net/bugs/1947746) <Squash-merge> <cherry-picked> <Created by oSoMoN> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11031>
[13:27] <mborzecki> meh, something changed in sid and tumbleweed and our session prepare is failing now
[14:46] <mup> PR snapd#10921 closed: osutil/disks: add more fields to Partition, populate them during discovery <Simple 😃> <Run nested> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10921>
[14:51] <mup> PR snapd#11048 closed: o/snapstate/handlers: propagate read errors on "copy-snap-data" <Simple 😃> <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11048>
[14:51] <ijohnson[m]> \o/
[14:51]  * ijohnson[m] hugs mvo for the merge
[14:51] <mvo> yw!
[14:56] <mup> PR snapd#10878 closed: interfaces/builtin/time-control: allow pps access <Squash-merge> <Created by kubiko> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10878>
[15:01] <mup> PR snapd#11039 closed: cmd/libsnap-confine-private: do not deny all devices when reusing the device cgroup <⚠ Critical> <Squash-merge> <Security-High> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11039>
[15:05] <mvo> pstolowski: I guess we can mark 11056 as "ready" from "draft" ? or is there anything you feel is missing?
[15:05] <pstolowski> mvo: yes, done
[15:18] <mvo> pstolowski: and I assume squash-merge for 11056 is okay too?
[15:20] <pstolowski> mvo: sure
[15:26] <ijohnson[m]> mardy: I left a suggestion about the microstack spread test
[15:26] <zyga-mbp> hey mvo :)
[15:29] <ijohnson[m]> also reviews for https://github.com/snapcore/snapd/pull/10807 would be great if anybody has some free time before they EOD 🙂
[15:29] <mup> PR #10807: tests/nested/manual/core20-cloud-init-maas-signed-seed-data: add gadget variant <Squash-merge> <Test Robustness> <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10807>
[15:29] <ijohnson[m]> hey zyga-mbp feeling better ?
[15:30] <zyga-mbp> yes, I hopefully no long-term damage
[15:30] <zyga-mbp> I'm recovering nicely
[15:30] <ijohnson[m]> that's good news
[15:30] <ijohnson[m]> some of my friends got covid even after they got the vaccine but it was mild and went away quickly for them
[15:30] <zyga-mbp> I had a bit of a scary moment but I think the worse is over
[15:31] <mup> PR snapd#11043 closed: gadget: include size + sector-size in DiskVolumeDeviceTraits <Simple 😃> <Needs Samuele review> <Skip spread> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/11043>
[15:35] <jawn-smith> mvo: We're getting some more requests to add the --validation flag to ubuntu-image. Have there been any updates on LP: #1948838 ?
[15:35] <mup> Bug #1948838: Snapd can no longer be imported as a Go module <snapd:New> <Snappy:New> <https://launchpad.net/bugs/1948838>
[15:40] <ijohnson[m]> pstolowski: hey have you seen auto-refresh failures like this one ? https://pastebin.ubuntu.com/p/vTQ7qFW6g7/
[15:41] <ijohnson[m]> I've seen that one a few times before and mentioned it in the SU doc, but I don't know that anyone ever looked into it
[15:41] <ijohnson[m]> I'm inclined to mark it as a flaky test for someone to look into at some point
[15:41] <ijohnson[m]> (i.e. keep running the test but make a LP bug with the flaky-tests tag on it)
[15:42] <pstolowski> ijohnson[m]: i remember you mentioning it and looked at it but couldn't reproduce. let me try once again. i suspect the test isn't just waiting long enough for refresh
[15:42] <ijohnson[m]> ok, do you want me to file a LP bug about it so we don't forget ?
[15:43] <pstolowski> ijohnson[m]: i wouldn't disable this test though as this is the only test we have for the gate-auto-refresh hook
[15:43] <ijohnson[m]> right I wasn't suggesting disabling it, just not sure if you would find it helpful to have a LP bug about it
[15:43] <pstolowski> ijohnson[m]: that would be great, thank you
[15:43] <ijohnson[m]> if you're going to look into immediately and try to fix it then maybe not worth it
[15:43] <ijohnson[m]> pstolowski: ack I will file a bug and assign it to you then
[15:44] <pstolowski> ijohnson[m]: ty
[15:45] <ijohnson[m]> np
[16:46] <pstolowski> ijohnson[m]: no luck in reproducing (of course), maybe this will help https://github.com/snapcore/snapd/pull/11057
[16:46] <mup> PR #11057: tests: print extra debug on auto-refresh-gating test failure <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/11057>
[16:46] <mup> PR snapd#11057 opened: tests: print extra debug on auto-refresh-gating test failure <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/11057>
[18:42] <mup> PR snapd#11058 opened: interfaces/udev: fix installing snaps inside lxd in 21.10 <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/11058>
[20:07] <mup> PR snapd#11044 closed: interfaces/builtin/block_devices: allow blkid to print block device attributes <cherry-picked> <Created by woodrow-shen> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11044>
[22:13] <mup> PR snapd#11059 opened: release: 2.53.2 <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11059>
[22:33] <mup> PR snapd#11060 opened: gadget/install: use disks functions to implement deviceFromRole, also rename <Simple 😃> <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11060>
[23:53] <mup> PR snapd#11059 closed: release: 2.53.2 <Simple 😃> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/11059>
[23:58] <mup> PR snapd#11061 opened: packaging: merge changelog for 2.53.2 back to master <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11061>