[02:15] PR snapd#11070 opened: gadget/gadget.go: include disk schema in the disk device volume traits too [06:37] morning [07:37] Issue core18#162 closed: Beef up build instructions [07:57] morning [08:31] hi mborzecki, mvo, pstolowski! [08:32] hey [09:10] experimental.refresh-app-awareness seems a bit suboptimal atm, it asks me to close apps to prevent disruptions and seems to not do any update. I'd have expected it to download the update and apply it when I close the app/reboot; as it stands now, there's basically no advantage as the apps run continously [09:11] like now I have to close the app, run snap refresh manually to get it over with? [09:17] juliank: that, or it will get retried on next auto-refresh (which will happen in whatever refresh window you have set (4 times a day by default) [09:17] pstolowski: right but the app runs all the time, the only time it's not running is during boot [09:18] (or shortly if it got borked) [09:22] optimally I guess it would do the refresh as usual, except for switching the current version over, then do the switch of current at boot/when app is closed [09:22] WOuld work nicer :D [09:25] juliank: yes i see your point, it's not as simple as just switching current revision over unfortunately because we run hooks for example [09:26] yeah hooks are evil :D [09:27] juliank: i suggest you take it to https://forum.snapcraft.io/t/wip-refresh-app-awareness/10736 [09:28] to get more input and rationale, also from our architect [09:40] jamesh: hi, not sure if you saw it, but I proposed 2 PRs for notifications - https://github.com/snapcore/snapd/labels/refresh%20app%20awareness [09:40] jamesh: your feedback would be great [09:40] (but also, no rush) [09:41] pstolowski: yeah. I saw one of the emails last night, but didn't get round to it this morning. Will have a look [09:42] thanks [11:12] PR snapd#11071 opened: data/env: provide profile setup for fish shell [11:27] jamesh: hi, still around? https://github.com/snapcore/snapd/pull/11023 failed on shellchecks, i can push a fix for this and a unit test for strv if you don't mind [11:27] PR #11023: cmd/snap-confine: do not include libglvnd libraries from the host system <â›” Blocked> [11:30] mborzecki: I'll push a fix for that now. I also need to add the gl-core20 test as well: was waiting to see if the first change passed. [11:30] jamesh: ok, thanks! [11:31] jamesh: since i already have it, the patch with unit test: https://pastebin.ubuntu.com/p/JMf4ctkCsn/ [11:39] mborzecki: thanks. I've got to head out, but I'll integrate it when I get home (the pastebin doesn't apply cleanly, since it seems to have converted tabs to spaces) [11:48] jamesh: thanks for the feeback on the notifications PR [13:03] PR snapd#11072 opened: usersession/client: provide a way for usersession client to send messages only to a subset [13:03] jamesh: i created a separate PR for what you suggested ^ [13:18] PR snapd#11073 opened: tests/lib/prepare: allow word splitting of EXTRA_FUNDAMENTAL [13:23] PR snapd#11070 closed: gadget/gadget.go: include disk schema in the disk device volume traits too [13:48] PR snapd#11074 opened: tests: reorganize the debug-each on the spread.yaml [16:54] PR snapd#11075 opened: tests: use --snap instead of --extra-snaps to create the core image [17:04] PR snapd#11076 opened: snapcraft.yaml: fix advanced grammar & 20.04 packaging [20:00] PR snapd#11077 opened: tests: use ubuntu-image from stable channel which uses go 1.11