=== juliank is now known as Guest5123 [07:09] morning [07:19] 'morning! [07:45] heya [08:05] morning [08:18] pstolowski, mvo, zyga: hi! [08:18] o/ [08:23] hey mardy, hey mvo :) [08:38] PR snapd#11144 closed: packaging: merge 2.53.4 (and also 2.53.3) changelogs back to master [08:43] PR snapd#11140 closed: o/snapstate: refactor disk space checks (2.53) [09:04] mvo: can you land https://github.com/snapcore/snapd/pull/11130? [09:04] PR #11130: tests/main/security-device-cgroups-helper: collect some debug info when the test fails [09:41] mvo: [09:41] mvo: and this one too: https://github.com/snapcore/snapd/pull/11131 [09:41] PR #11131: tests/nested/manual/core20-remodel: wait for device to have a serial before starting a remodel [09:43] mardy: can you take a look at https://github.com/snapcore/snapd/pull/11138 ? [09:43] PR #11138: tests/core/kernel-and-base-single-reboot-failover, tests/lib/fakestore: verify failover scenario [10:51] mborzecki: done, feel free to ignore the nitpicks unless you need to touch the code again [10:59] mborzecki: didn't we fix this test some time ago? https://github.com/snapcore/snapd/runs/4428017423?check_suite_focus=true [11:02] mardy: hmm, looks like it was stopped by apparmor, weird [11:51] mvo: there are many failures on the kernel-module-load interface, but they are all unrelated: https://github.com/snapcore/snapd/pull/10977; do you want me to re-run the tests just to see if we can get it somehow a bit greener, or can you merge it now? [11:51] PR #10977: interfaces: kernel-module-load [12:07] mardy: https://github.com/snapcore/snapd/pull/11147 [12:07] PR #11147: tests/main/security-udev-input-subsystem: drop info from udev [12:09] PR snapd#11147 opened: tests/main/security-udev-input-subsystem: drop info from udev [12:21] mborzecki: approved, thanks! I'm trying to reproduce the error, but I couldn't neither in QEMU nor in GCE [12:22] mardy: best guess is some sort of race in udev again [12:24] Good morning [12:25] * ijohnson[m] sees mention of udev races and considers going back to bed and restarting his day later [13:55] PR snapd#10969 closed: o/snapstate, assertsate: validation sets/undo on partial failure [14:05] PR snapd#11148 opened: snap: add support for `snap watch --last={revert,enable,disable,swtich}` [14:16] PR snapcraft#3604 opened: Newsnapcraftspike snapyaml [14:32] bboozzoo: have you seen this debian 11 cgroups v2 failure? https://pastebin.ubuntu.com/p/YJ7W6D7D4S/ [14:33] ijohnson: yeah, if you can please file a flaky test for this one (although isn't there one already?) [14:33] bboozzoo: oh maybe there is one [14:33] ijohnson: as afaiu what's happening is taht systemd daemon-reload triggers reinstallation of bpf programs for all systemd services (timesync, resolved, networkd.. and so on) [14:34] no I don't see one for this specific spread test [14:35] and it's all racy, so at the time we sample the number of prgrams, it can be higher than what we expect [14:35] PR snapd#11145 closed: tests/main/generic-unregister: test re-registration if not blocked [14:37] bboozzoo: filed https://bugs.launchpad.net/snapd/+bug/1953348 [14:37] Bug #1953348: Test debian-11-64:tests/main/cgroup-devices-v2 is flaky [14:42] ijohnson: thanks! [14:45] PR snapd#11146 closed: overlord: fix issue with concurrent execution of two snapd processes [14:50] PR snapd#11130 closed: tests/main/security-device-cgroups-helper: collect some debug info when the test fails [14:50] PR snapd#11131 closed: tests/nested/manual/core20-remodel: wait for device to have a serial before starting a remodel [14:50] PR snapd#11138 closed: tests/core/kernel-and-base-single-reboot-failover, tests/lib/fakestore: verify failover scenario [14:50] PR snapd#11146 opened: overlord: fix issue with concurrent execution of two snapd processes [15:05] PR snapd#11149 opened: tests: avoid checking TRUST_TEST_KEYS on restore on remodel-base test [16:20] PR snapd#11150 opened: systemd: provide more detailed errors for unimplemented method in emulation mode [17:21] PR snapd#11147 closed: tests/main/security-udev-input-subsystem: drop info from udev