| mardy | mborzecki: 'morning! How did you get this nice graph here? https://paste.ubuntu.com/p/y7tQtxQScq/ | 06:28 |
|---|---|---|
| mup | PR snapd#11108 closed: tests: disable flacky test snapd-failover <Flaky Test> <Created by mardy> <Closed by mardy> <https://github.com/snapcore/snapd/pull/11108> | 06:31 |
| mborzecki | morning | 06:58 |
| mborzecki | mardy: silly pastebin requires me to log in 😕 just a sec | 06:58 |
| mborzecki | mardy: i used this tool: https://github.com/KyleBanks/depth | 06:59 |
| mardy | mborzecki: cool, thanks! | 07:15 |
| pstolowski | morning | 08:03 |
| mardy | pstolowski: hi! | 08:28 |
| mborzecki | heya | 08:29 |
| ijohnson[m] | morning folks | 11:02 |
| mardy | ijohnson[m]: hi! | 11:12 |
| ijohnson[m] | o/ | 11:13 |
| mup | PR snapd#11169 opened: o/snapstate: migrate to hidden dir on refresh/install <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/11169> | 11:17 |
| ijohnson[m] | mardy: it seems like https://github.com/snapcore/snapd/pull/11080 is ready to land no? is it waiting on anyone or anything else ? | 11:23 |
| mup | PR #11080: builtin/interfaces: add shared memory interface <Needs Samuele review> <Created by mardy> <https://github.com/snapcore/snapd/pull/11080> | 11:23 |
| mup | PR snapd#11170 opened: snap: squashfs library to read squashfs images <Created by Meulengracht> <https://github.com/snapcore/snapd/pull/11170> | 11:32 |
| mardy | ijohnson[m]: yes, it can be merged, but I lack permissions to force it through the CI | 11:44 |
| ijohnson[m] | mardy: ack just checking I can ask pedronis to merge it | 11:44 |
| mardy | ijohnson[m]: oh, wait a second, I want to squash the commits | 11:45 |
| ijohnson[m] | we can just tag it with squash merge | 11:45 |
| ijohnson[m] | just update the PR description with what you want the commit message to be | 11:46 |
| mardy | ijohnson[m]: too late, I already rebased it :-D | 11:48 |
| ijohnson[m] | ah ok, for reference that is what the squash-merge tag for PR's is for | 11:49 |
| mardy | ijohnson[m]: thanks, I actually knew it, but it's rare that I want to squash everything to a single commit, I often have 2-3 which I prefer to keep separate (though in this case, I could indeed have squashed them all) | 11:58 |
| ijohnson[m] | mardy: sure that's fair, also the other thing I would mention is that I do typically prefer to not force push things after it's gotten reviews to ensure that it's clear to the reviewers that nothing changed in the force push. this does mean we end up with rather messy git history, but that is the decision we made a while ago; perhaps you could ask pedronis about this, I may have since forgotten all the justification why we did it that way | 12:00 |
| mardy | ijohnson[m]: no you are right, in github it's very hard to understand what changed from one force-push to the other (whereas gitlab is much better in this aspect); but I was told that after the approval, I could rearrange the commits, as long as the code is not changed | 12:04 |
| ijohnson[m] | ah perhaps our policy has indeed changed, I remember discussing this when I joined the team and what I recall being told was that any force repushes would require new reviews | 12:05 |
| mborzecki | meh that bpf programs list is slightyl inconvenien to work with | 14:47 |
| mup | PR snapd#11088 closed: tests: add tags to identify the tests that cover the basic functionalities of snapd <â›” Blocked> <Created by sergiocazzolato> <Closed by sergiocazzolato> <https://github.com/snapcore/snapd/pull/11088> | 17:39 |
| mup | PR snapd#11171 opened: tests: tag spread tests with basic tag on core test suite <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/11171> | 18:19 |
| mup | PR snapcraft#3606 opened: build(deps): bump lxml from 4.6.3 to 4.6.5 <dependencies> <python> <Created by dependabot[bot]> <https://github.com/snapcore/snapcraft/pull/3606> | 19:55 |
| bandali | hi all, any idea about why this error might be happening? /snap/bin/snapcraft: 3: exec: /snap/snapcraft/current/usr/bin/python3: not found | 20:59 |
| bandali | fwiw we're using a custom docker image that's essentially the same as https://github.com/snapcore/snapcraft/blob/master/docker/Dockerfile | 20:59 |
| ijohnson[m] | bandali: what's `snap list snapcraft` ? | 20:59 |
| ijohnson[m] | oh nvm then, you won't have snapd then to actually install the snap | 21:00 |
| bandali | hmm. yeah we're just using that docker image | 21:00 |
| ijohnson[m] | yeah that docker image doesn't actually install any snaps, it's a bit of a hack | 21:00 |
| bandali | right :/ any tips on how to go about debugging this? | 21:01 |
| ijohnson[m] | bandali: you might try asking on the forum, not sure who's around, but someone may see the post on the forum in the morning in EU | 21:01 |
| bandali | ijohnson[m], aha okay i'll give that a shot, thanks! | 21:01 |
| ijohnson[m] | np | 21:01 |
| mup | PR snapd#11172 opened: tests: skip installing systemd-timesyncd in debian 10 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/11172> | 21:10 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!