| holmanb | @blackboxsw: I applied your diff to PR #1130, but didn't bother with authorship since that would be lost in the squash merge. How do you feel about adding a "Co-authored-by" line to the commit message? | 03:29 |
|---|---|---|
| blackboxsw | holmanb: no worries was just poking at that now. no need for authoship attribution for this. Generally when there were more significant assistance, we can add the Co-authored-by: <blah> footer. | 03:30 |
| blackboxsw | But it was minor nits. so all good. I'm hoping to merge shortly and call it a night | 03:31 |
| blackboxsw | I took a dinner break for a while and wanted to wrap up on your branch. | 03:31 |
| holmanb | Thanks! That sounds fine to me. | 03:32 |
| holmanb | I'm around for a little bit if you have any questions, otherwise have a good night :) | 03:33 |
| blackboxsw | holmanb: if still around, I think we could add this: to handle non-annotated config errors: https://paste.ubuntu.com/p/yCyM2x8MJP/ | 04:13 |
| holmanb | looking | 04:13 |
| blackboxsw | which gives us: output like this: | 04:13 |
| blackboxsw | root@dev-b:~# cloud-init devel schema --system | 04:13 |
| blackboxsw | Error: | 04:13 |
| blackboxsw | Cloud-config is not a YAML dict. | 04:13 |
| blackboxsw | root@dev-b:~# cloud-init query userdata | 04:13 |
| blackboxsw | #cloud-config | 04:13 |
| blackboxsw | for empty config with --annotate is not provided | 04:14 |
| blackboxsw | http://paste.ubuntu.com/p/XK7qymWjSx/ when calling `cloud-init devel schema --system --annotate` | 04:14 |
| blackboxsw | otherwise, without the patch output of `cloud-nit devel schema --system` will be http://paste.ubuntu.com/p/VpY4Db5nwY/ | 04:16 |
| holmanb | That makes sense. | 04:25 |
| holmanb | It looks like --docs all --annotate is accepted by the parser too, for what it's worth, but I can't think of a reason anyone would try that so I assume that's just an invalid combo. | 04:26 |
| blackboxsw | yeah that's an invalid combo | 04:27 |
| blackboxsw | should raise an error on that | 04:27 |
| blackboxsw | can do that in a separate PR if you want | 04:27 |
| holmanb | I need to hop off for the night, but I'm fine with adding that to this PR | 04:29 |
| holmanb | I can add that and the the suggestion you pastebinned (verb?) first thing in the morning | 04:30 |
| blackboxsw | collio holmanb agreed take care. we'll sort it tomorrow | 04:33 |
| holmanb | Seeya o/ | 04:36 |
| beantaxi | Here's a simple issue I seem tp be having a hard time figuring out ... how do I create a cloud-config that installs the latest node on ubuntu? Node's debian/ubuntu instructions don't seem to be based on 'add this PPA'. Thanks! | 16:46 |
| holmanb | beantaxi - does the latest version packaged by ubuntu meet your needs? | 17:41 |
| holmanb | their "pipe curl to sh" setup script just adds a repo (source and gpg files), which are things that the apt-configure module is capable of | 17:45 |
| holmanb | beantaxi: ahh, yes -> take a look at the manual install section: https://github.com/nodesource/distributions/blob/master/README.md#manual-installation | 18:01 |
| holmanb | beantaxi: apt-configure module in cloud-init can add a repo, for an example see the "sources" key under https://cloudinit.readthedocs.io/en/latest/topics/examples.html#additional-apt-configuration-and-repositories | 18:02 |
| holmanb | beantaxi: their key ID (9FD3B784BC1C6FC31A8A0A1C1655A0AB68576280) is posted in the manual-installation section on the readme. That key is also hosted by keyserver.ubuntu.com, so you should be able to add something like this (untested) to the apt section of your cloud-config to install from their repo: | 18:12 |
| holmanb | ``` | 18:12 |
| holmanb | sources: | 18:12 |
| holmanb | nodesource.list: | 18:12 |
| holmanb | source: deb [signed-by=$KEY_FILE] https://deb.nodesource.com/node_8.x $RELEASE main | 18:12 |
| holmanb | keyid: 9FD3B784BC1C6FC31A8A0A1C1655A0AB68576280 | 18:12 |
| holmanb | ``` | 18:12 |
| beantaxi | holmanb: Thanks! I'll give that a shot | 20:04 |
| esv | hey folks, what would be the difference between using #cloud-config and #cloud-init in the customer data file. ? | 21:17 |
| esv | never mind, thanks for not insulting :) | 21:24 |
| blackboxsw | esv: it's an easy mistake to make, all questions valid! I'm culpable of that mistake a couple times. We're hoping that `cloud-init devel schema --system --annotate` adds value here. As it should show something like the following: | 22:19 |
| blackboxsw | Error: | 22:19 |
| blackboxsw | Cloud config schema errors: format-l1.c1: File 1.yaml needs to begin with "#cloud-config" | 22:19 |
| blackboxsw | or rather | 22:19 |
| blackboxsw | schema -c 1.yaml --annotate | 22:20 |
| blackboxsw | #cloud-init# E1 | 22:20 |
| blackboxsw | # Errors: ------------- | 22:20 |
| blackboxsw | # E1: File 1.yaml needs to begin with "#cloud-config" | 22:20 |
| blackboxsw | holmanb: merged schema annotate and cloud-init boot process warning about empty schema thx https://github.com/canonical/cloud-init/pull/1130 | 22:33 |
| ubottu | Pull 1130 in canonical/cloud-init "cloud-config annotation throws exception, fix it" [Merged] | 22:33 |
| holmanb | blackboxsw: Thanks! | 22:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!