| mborzecki | morning | 07:12 |
|---|---|---|
| mardy | mborzecki: hi! | 07:56 |
| mborzecki | mardy: hey | 08:01 |
| pstolowski | morning | 08:16 |
| mborzecki | pstolowski: hey | 08:35 |
| mardy | pstolowski: hi! | 08:48 |
| zyga | good morning | 08:50 |
| pstolowski | jamesh: hey, coming to the sync? | 09:04 |
| mup | PR snapd#11247 opened: overlord: small refactoring of group quota implementation in preparation of multiple quota values <Created by Meulengracht> <https://github.com/snapcore/snapd/pull/11247> | 09:10 |
| mup | PR snapd#11248 opened: String list attribute <Created by mardy> <https://github.com/snapcore/snapd/pull/11248> | 09:40 |
| mardy | zyga: hi! | 09:43 |
| zyga | hey mardy, how have you been? | 09:53 |
| mardy | zyga: like in a freezer, but it's fine :-) How's life for you? | 10:07 |
| mardy | if anyone can give me a suggestion about where to move the function I added in https://github.com/snapcore/snapd/pull/11248, that would be very appreciated :-) | 10:09 |
| mup | PR #11248: many: add conversion for interface attribute values <Created by mardy> <https://github.com/snapcore/snapd/pull/11248> | 10:09 |
| zyga | mardy, I miss the winter already, it's +1 and raining here so I cannot go out and bike | 10:10 |
| mup | PR snapd#11239 closed: tests/lib/prepare-restore: use go install rather than go get <Simple 😃> <Test Robustness> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11239> | 10:45 |
| mup | PR snapd#11073 closed: tests: ubuntu-image 2.0 compatibility fixes <Simple 😃> <Run nested> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11073> | 11:20 |
| mup | PR snapcraft#3622 opened: lifecycle: core22 lifecycle conditional on build-attributes entry (CRAFT-725) <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3622> | 12:21 |
| === Mirv__ is now known as Mirv | ||
| mup | PR snapd#11249 opened: cmd/snap: rm unnecessary validation <Simple 😃> <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/11249> | 13:06 |
| mardy | any idea why `go vet` is complaining about https://github.com/mardy/snapd/blob/string-list-attribute/interfaces/connection.go#L90-L92 (https://github.com/snapcore/snapd/runs/4803364618?check_suite_focus=true) but not about an identical case here: https://github.com/mardy/snapd/blob/string-list-attribute/client/client.go#L258 ? | 13:53 |
| mvo | mardy: does AttributeNotFoundError has multiple members in the struct? maybe thats the difference? | 13:57 |
| miguelpires | mardy: I think it's because one is local and the other is not. The idea is of the warning is to protect against a 3rd party adding a new field and breaking the usage, so vet doesn't complain about unkeyed local structs. Source: https://go.dev/src/cmd/vendor/golang.org/x/tools/go/analysis/passes/composite/composite.go (see the isLocalType method at | 14:30 |
| miguelpires | the bottom) | 14:30 |
| abeato_ | hey, is there any test-snapd* snap that fails on installation? For instance, by having a configure hook that fails when run the first time. | 15:01 |
| ijohnson[m] | abeato_: `snap install nope` | 15:14 |
| ijohnson[m] | although not sure which specific failure mode you are looking for | 15:14 |
| pstolowski | abeato_: we also have at least on locally built snap in spread tests suite | 15:15 |
| pstolowski | e.g. under snap-set test | 15:15 |
| abeato_ | ijohnson[m], thanks! (lol, was unsure whether you were joiking or not) - it is for doing spread tests of transactional install | 15:15 |
| abeato_ | a service fail seems like a good match | 15:16 |
| abeato_ | can those local snaps be used in sort of a fake store when running spread tests? | 15:17 |
| ijohnson[m] | the nope snap is a real snap! | 15:17 |
| abeato_ | yeah, I've tried to install it :) | 15:17 |
| abeato_ | but I doubted it for a couple of secs! :D | 15:17 |
| ijohnson[m] | abeato_: what do you mean by a fake store ? we have a very specific thing called the "fakestore" but I'm not sure if that's what you're referring to | 15:17 |
| ijohnson[m] | most of the time we will just do what pstolowski says, see tests/lib/snaps/ in the git repo | 15:18 |
| abeato_ | I need the snaps to be in some store while running these spread tests | 15:19 |
| abeato_ | I don't know if they need to be in the real store or if there is an easier way to do the tests | 15:20 |
| ijohnson[m] | abeato_: we do publish some of the test-snapd-* snaps too if that's what you're looking for, that's usually what we do since it's much simpler than using the fakestore TBH | 15:20 |
| abeato_ | ijohnson[m], got it - yeah it seems easier to me too. I'll see if the nope snap is enough for what I want, thanks | 15:21 |
| mup | PR snapcraft#3622 closed: lifecycle: core22 lifecycle conditional on build-attributes entry (CRAFT-725) <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3622> | 15:21 |
| ijohnson[m] | sounds good but yeah if you want any snaps in the store, feel free to push them then we can get them transferred to the test snaps canonical account | 15:23 |
| abeato_ | ijohnson[m], ok, cool | 15:25 |
| mup | PR snapd#11250 opened: tests: fix running tests.invariant on testflinger systems <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/11250> | 15:26 |
| mup | PR snapd#11251 opened: devicestate: ensure permissions of /var/lib/snapd/void are correct <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/11251> | 15:46 |
| mup | PR snapd#11240 closed: tests: fix parallel-install-basic on external UC16 devices <Simple 😃> <Test Robustness> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11240> | 15:51 |
| mup | PR snapd#11246 closed: tests: fix `tests/core/create-user` on testflinger pi3 <Simple 😃> <Test Robustness> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11246> | 15:51 |
| === chrisccoulson_ is now known as chrisccoulson | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!