[07:12] morning [07:56] mborzecki: hi! [08:01] mardy: hey [08:16] morning [08:35] pstolowski: hey [08:48] pstolowski: hi! [08:50] good morning [09:04] jamesh: hey, coming to the sync? [09:10] PR snapd#11247 opened: overlord: small refactoring of group quota implementation in preparation of multiple quota values [09:40] PR snapd#11248 opened: String list attribute [09:43] zyga: hi! [09:53] hey mardy, how have you been? [10:07] zyga: like in a freezer, but it's fine :-) How's life for you? [10:09] if anyone can give me a suggestion about where to move the function I added in https://github.com/snapcore/snapd/pull/11248, that would be very appreciated :-) [10:09] PR #11248: many: add conversion for interface attribute values [10:10] mardy, I miss the winter already, it's +1 and raining here so I cannot go out and bike [10:45] PR snapd#11239 closed: tests/lib/prepare-restore: use go install rather than go get [11:20] PR snapd#11073 closed: tests: ubuntu-image 2.0 compatibility fixes [12:21] PR snapcraft#3622 opened: lifecycle: core22 lifecycle conditional on build-attributes entry (CRAFT-725) === Mirv__ is now known as Mirv [13:06] PR snapd#11249 opened: cmd/snap: rm unnecessary validation [13:53] any idea why `go vet` is complaining about https://github.com/mardy/snapd/blob/string-list-attribute/interfaces/connection.go#L90-L92 (https://github.com/snapcore/snapd/runs/4803364618?check_suite_focus=true) but not about an identical case here: https://github.com/mardy/snapd/blob/string-list-attribute/client/client.go#L258 ? [13:57] mardy: does AttributeNotFoundError has multiple members in the struct? maybe thats the difference? [14:30] mardy: I think it's because one is local and the other is not. The idea is of the warning is to protect against a 3rd party adding a new field and breaking the usage, so vet doesn't complain about unkeyed local structs. Source: https://go.dev/src/cmd/vendor/golang.org/x/tools/go/analysis/passes/composite/composite.go (see the isLocalType method at [14:30] the bottom) [15:01] hey, is there any test-snapd* snap that fails on installation? For instance, by having a configure hook that fails when run the first time. [15:14] abeato_: `snap install nope` [15:14] although not sure which specific failure mode you are looking for [15:15] abeato_: we also have at least on locally built snap in spread tests suite [15:15] e.g. under snap-set test [15:15] ijohnson[m], thanks! (lol, was unsure whether you were joiking or not) - it is for doing spread tests of transactional install [15:16] a service fail seems like a good match [15:17] can those local snaps be used in sort of a fake store when running spread tests? [15:17] the nope snap is a real snap! [15:17] yeah, I've tried to install it :) [15:17] but I doubted it for a couple of secs! :D [15:17] abeato_: what do you mean by a fake store ? we have a very specific thing called the "fakestore" but I'm not sure if that's what you're referring to [15:18] most of the time we will just do what pstolowski says, see tests/lib/snaps/ in the git repo [15:19] I need the snaps to be in some store while running these spread tests [15:20] I don't know if they need to be in the real store or if there is an easier way to do the tests [15:20] abeato_: we do publish some of the test-snapd-* snaps too if that's what you're looking for, that's usually what we do since it's much simpler than using the fakestore TBH [15:21] ijohnson[m], got it - yeah it seems easier to me too. I'll see if the nope snap is enough for what I want, thanks [15:21] PR snapcraft#3622 closed: lifecycle: core22 lifecycle conditional on build-attributes entry (CRAFT-725) [15:23] sounds good but yeah if you want any snaps in the store, feel free to push them then we can get them transferred to the test snaps canonical account [15:25] ijohnson[m], ok, cool [15:26] PR snapd#11250 opened: tests: fix running tests.invariant on testflinger systems [15:46] PR snapd#11251 opened: devicestate: ensure permissions of /var/lib/snapd/void are correct [15:51] PR snapd#11240 closed: tests: fix parallel-install-basic on external UC16 devices [15:51] PR snapd#11246 closed: tests: fix `tests/core/create-user` on testflinger pi3 === chrisccoulson_ is now known as chrisccoulson