=== tianon- is now known as tianon
[06:45] <mborzecki> morning
[07:55] <mardy> hi mborzecki 
[08:02] <pstolowski> morning
[08:28] <mvo> good morning pstolowski 
[09:46] <mup> PR snapd#11252 opened: snap: cpu quota support through --cpu, --cpu-set and --thread <Created by Meulengracht> <https://github.com/snapcore/snapd/pull/11252>
[10:46] <mup> PR snapd#11253 opened: packaging,tests: fix running autopkgtest <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/11253>
[10:56] <mardy> mmm... the code coverage report clearly has some issues. This function is actually fully covered by existing unit tests, yet it shows up as red: https://app.codecov.io/gh/snapcore/snapd/compare/11248/diff#D3L54
[11:17] <mup> PR snapd#11254 opened: spread-shellcheck: use safe_load rather than load with a loder <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/11254>
[12:06] <mvo> reviews for pr#11253 would be supernice, with that I can SRU again and fix the autopkgtest failures we got in the most recent upload
[12:07] <mup> PR snapd#11255 opened: Transactional installs/removes/refreshes <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/11255>
[12:22] <mup> PR snapd#11243 closed: tests/main/snap-info: use yaml.safe_load rather than yaml.load <Simple 😃> <Test Robustness> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11243>
[12:22] <mup> PR snapd#11249 closed: cmd/snap: rm unnecessary validation <Simple 😃> <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11249>
[12:32] <mup> PR snapd#11231 closed: cmd/snap: setup tracking cgroup when invoking a service directly as a user <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11231>
[12:42] <mup> PR snapd#11208 closed: interfaces: allow access to new at-spi socket location in desktop-legacy <Created by jhenstridge> <Merged by jhenstridge> <https://github.com/snapcore/snapd/pull/11208>
[12:52] <mborzecki> meh, so git add -f refuses to add a file named pc-boot.img since we have a matching pattern in gitignore
[12:52] <mborzecki> even though i used -f
[12:57] <mup> PR snapd#11256 opened: Minor changes ensuring unset SNAPD_DEBG to avoid test failures when r… <Created by mansre> <https://github.com/snapcore/snapd/pull/11256>
[13:02] <mup> PR snapd#11254 closed: spread-shellcheck: use safe_load rather than load with a loder <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/11254>
[13:14] <mardy> mborzecki: weird... what's the error message?
[13:15] <mborzecki> mardy: found the culprint, we had *.img in spread.yaml, so it was in git, but miraculously disappeared the source tree on gce
[13:15] <mborzecki> i mean we had *.img in exclude in spread.yaml 🙂
[13:29] <mardy> ah, tricky!
[13:43] <ijohnson[m]> bboozzoo: hey for the core20-remodel nested spread test, do you think this line should be done in a loop? is it racing with snapd trying to write that file? https://github.com/snapcore/snapd/blob/116fa26916a32c582066340c73025f50ca5601d4/tests/nested/manual/core20-remodel/task.yaml#L47
[13:44] <ijohnson[m]> I saw that test fail because that file was not present, but all the logs from snapd in the VM suggests that the remodel was in fact successful
[13:50] <mborzecki> ijohnson: sec, let me see
[13:51] <mborzecki> ijohnson: hmm no by the time it runs the label should be there already, unless hmm it ran around midnight maybe?
[13:56] <ijohnson[m]> bboozzoo: haha
[13:56] <ijohnson[m]> 2022-01-14 00:03:51 Debug output for google-nested:ubuntu-20.04-64:tests/nested/manual/core20-remodel (jan132315-799582) : 
[13:57] <ijohnson[m]> 4 minutes after midnight
[13:57] <mborzecki> hahah
[13:57] <mborzecki> got link?
[13:57] <ijohnson[m]> https://github.com/snapcore/snapd/runs/4810553343?check_suite_focus=true
[13:57] <mborzecki> ijohnson: i suspect the base label is 20220113, but the remodel started after midnight already 🙂
[13:57] <mborzecki> (or at least the label was created at that time)
[13:58] <ijohnson[m]> yeah
[13:58] <mborzecki> hm maybe i should buy some lottery tickets
[13:58] <ijohnson[m]> 🙂
[14:07] <mborzecki> ijohnson: so afaiu, the image ran was creaated before midnight, thus the recovery system label was 20220113, but the test then ran after midnight already so it assumed that the label is 20220114 and expected 20220114-1 to appear next
[14:23] <mup> PR snapcraft#3623 opened: feat: add source_recurse_submodules <Created by mr-cal> <https://github.com/snapcore/snapcraft/pull/3623>
[14:27] <ijohnson[m]> bboozzoo: that makes sense, any idea how we could prevent that sort of thing from happening? could we make the check more loose to check for the current date or the previous date?
[14:29] <mardy> ijohnson[m]: hi! The new custom-device interface, it will be available only on the UC devices, right?
[14:31] <ijohnson[m]> mardy: that is the main consumer yes since it will require a gadget snap, but we have had on occasion some enablements where they have a classic gadget, so if at all possible we should not assume that it will only be used on ubuntu core
[14:53] <mup> PR snapd#11199 closed: tests: fix uses of fakestore new-snap-declaration <Created by bboozzoo> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/11199>
[14:55] <ijohnson[m]> super duper simple PR for anyone with 30 seconds 🙂 https://github.com/snapcore/snapd/pull/11257
[14:55] <mup> PR #11257: gadget: fix typo with filesystem message <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11257>
[14:58] <mup> PR snapd#11257 opened: gadget: fix typo with filesystem message <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11257>
[15:04] <mborzecki> ijohnson: or maybe just tweak the error message: https://github.com/snapcore/snapd/pull/11257/commits/46ee01f8f3d803d19b5e6b673f0de86f751a349d#r784914495
[15:04] <mup> PR #11257: gadget: fix typo with filesystem message <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11257>
[15:04] <ijohnson[m]> oh no it's not super duper simple! 🙂
[15:04] <ijohnson[m]> bboozzoo: also I opened https://github.com/snapcore/snapd/pull/11258 too
[15:04] <mup> PR #11258: tests/nested/manual/core20-remodel: try to work around midnight problem <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11258>
[15:08] <mup> PR snapd#11258 opened: tests/nested/manual/core20-remodel: try to work around midnight problem <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11258>
[15:33] <mup> PR snapd#11230 closed: gadget: misc helper fixes for implicit system-data role handling <Needs Samuele review> <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/11230>
[16:11] <kenvandine> mvo: when do you think we can get user-daemons enabled by default?
[16:28] <mup> PR snapd#11257 closed: gadget: fix typo with filesystem message <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/11257>
[17:18] <mup> PR snapd#11259 opened: tests/nested/manual/minimal-smoke: bump mem to 512 for unencrypted case too <Simple 😃> <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11259>
[17:18] <mup> PR snapd#11260 opened: tests/nested/manual/minimal-smoke: revert back to 384M for unencrypted case <⛔ Blocked> <Simple 😃> <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11260>
[17:23] <mup> PR snapcraft#3624 opened: Fix npm plugin permission denied <Created by om26er> <https://github.com/snapcore/snapcraft/pull/3624>
[23:05] <mup> PR snapd#9536 closed: RFC: bootloader ping/pong protocol <:birthday:> <Skip spread> <Created by zyga> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/9536>
[23:25] <mup> PR snapd#11261 opened: tests/lib/nested.sh: add debug kernel command line parameters <Simple 😃> <Test Robustness> <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11261>