| mborzecki | morning | 06:59 |
|---|---|---|
| mardy | hi! | 07:17 |
| mup | PR snapd#11267 closed: store: fix flaky test <Simple 😃> <Skip spread> <Created by MiguelPires> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/11267> | 07:42 |
| pstolowski | morning | 08:02 |
| mborzecki | pstolowski: hey | 09:13 |
| pstolowski | hey | 09:14 |
| mup | PR snapd#11169 closed: o/snapstate: migrate to hidden dir on refresh/install <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11169> | 09:22 |
| mup | PR snapd#11233 closed: o/ifacestate: add convenience Active() method to ConnectionState struct <Simple 😃> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/11233> | 09:27 |
| mup | PR snapd#11270 opened: mkversion: check that snapd is a git source tree before guessing the version <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/11270> | 09:37 |
| mup | PR snapd#11271 opened: many: add ManyFlags parameter to snapstate.*Many() calls <Created by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/11271> | 10:07 |
| mardy | miguelpires: hi! I'm trying to use testutil.DeepUnsortedMatches in a test comparison, but the "unsorted" quality seems to affect only the outer container: all the inner values are still matched with sorting; do you think I can change it to make it "deeply unsorted", or do you see some issues with that? | 11:10 |
| miguelpires | mardy Hi! You're right, if you're comparing slices of slices the inner slices are compared as they are. Hm I guess it depends on the semantics you're expecting. I think comparing unsorted internally as well might lead to some unexpected behavior in at least some cases. You might not care about the order of a slices of structs but the structs might | 11:39 |
| miguelpires | have maps or slices that determine if they're equal. For example, a hypothetical slice of Tasks that has an ordered slice of dependency tasks. You don't care about the outer order but if the inner slice changes then it's a different task and it shouldn't be considered equal. | 11:39 |
| miguelpires | But we can add a new checker with those semantics to avoid having to look at the usages of DeepUnsortedMatches and see if anything would break (not sure what to call the new checker though =p) | 11:42 |
| mardy | miguelpires: I got a working version, but after your reply I'm not sure we want to keep two versions of the checker. It gets complicated, especially if we try to be smart and reuse as much as possible of the code. | 12:41 |
| mardy | for my use-case I've resorted to another solution (that is, convert the data structure into a map), maybe I'll resurrect the code if I see more use-cases for it | 12:42 |
| === diddledani_ is now known as diddledani | ||
| === madhens_ is now known as madhens | ||
| === Kamilion|ZNC is now known as Kamilion | ||
| mup | PR snapd#11272 opened: interfaces: custom-device <Created by mardy> <https://github.com/snapcore/snapd/pull/11272> | 13:03 |
| mup | PR snapd#11242 closed: systemd: enable batched calls for systemd calls operation on units <Created by kubiko> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11242> | 13:33 |
| mup | PR snapd#11273 opened: o/devicestate: verify that the new model is self container before remodeling <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/11273> | 15:04 |
| mup | PR snapd#11274 opened: tests: add jammy to spread executions <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/11274> | 16:44 |
| mup | PR snapcraft#3626 opened: [DRAFT] cli: integrate craft-cli and add version command <Created by cmatsuoka> <https://github.com/snapcore/snapcraft/pull/3626> | 19:12 |
| === sarnold_ is now known as sarnold | ||
| mup | Issue core20#128 opened: Possible bug: broken OpenDroneMap snap on core20 <Created by Saijin-Naib> <https://github.com/snapcore/core20/issues/128> | 19:37 |
| mup | PR snapd#11275 opened: osutils: deal with ENOENT in UserMaybeSudoUser() <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/11275> | 20:40 |
| === not_phunyguy is now known as phunyguy | ||
| mup | PR snapd#11276 opened: packaging/ubuntu-16.04/control: adjust libfuse3 dependency as suggested <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11276> | 20:50 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!