| mborzecki | morning | 07:03 |
|---|---|---|
| mardy | hi! | 07:53 |
| mborzecki | mardy: heya | 08:06 |
| pstolowski | morning | 08:17 |
| miguelpires | morning | 08:19 |
| mborzecki | pstolowski: miguelpires: hey | 08:19 |
| mborzecki | pstolowski: can you take a look at https://github.com/snapcore/snapd/pull/11122 ? it's a single test for a remodel in our test brand store + all the setup that was needed (models, snaps etc) | 08:20 |
| mup | PR #11122: tests: setup snapd remodel testing bits <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/11122> | 08:20 |
| pstolowski | mborzecki: sure | 08:25 |
| mborzecki | thanks! | 08:26 |
| mup | PR snapd#11277 opened: tests: cross store remodel <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/11277> | 09:09 |
| pstolowski | mborzecki: reviewed | 09:13 |
| miguelpires | hey. If anyone is looking for a PR to review, https://github.com/snapcore/snapd/pull/11262 needs one more +1 and is not too big (< 200 lines) | 10:30 |
| mup | PR #11262: cmd/snap: adjust /cmd to migration changes <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/11262> | 10:30 |
| mborzecki | miguelpires: btw. do we have a spread test maybe for the migration? | 11:14 |
| miguelpires | mborzecki: yes but it depends on the above PR. I'll open a PR for it once 11262 merges | 11:20 |
| mborzecki | miguelpires: cool | 11:30 |
| mardy | mborzecki: hi! I'm still fighting with the spread tests, I'm getting this error when installing my modified gadget snap: - Mount snap "pc" (unset) (model requires system-seed partition, but no system-seed or system-data partition found) | 11:37 |
| mardy | mborzecki: this is my test: https://github.com/mardy/snapd/blob/custom-device-spread/tests/nested/core/interfaces-custom-devices/task.yaml | 11:38 |
| mborzecki | mardy: hmm the gadget.yaml is different between 18 and 20 | 11:40 |
| mborzecki | mardy: i think it's ok to limit the test to just say ubuntu-20.04-64 (means core20) and then fetch the gadget from 20/stable | 11:41 |
| mardy | ah, I see, then the line I commented out was not so useless as I thought :-) Thanks! | 11:52 |
| mup | PR snapd#11278 opened: systemd: add new apis for service lifecycle handling <Created by kubiko> <https://github.com/snapcore/snapd/pull/11278> | 11:54 |
| mardy | mborzecki: I made some progress, now the gadget snap is installed, but it does not provide any slots. Yet I can see that my slot is present if I do "tests.nested exec cat /snap/pc/x2/meta/gadget.yaml" | 12:38 |
| mup | PR snapd#11262 closed: cmd/snap: adjust /cmd to migration changes <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11262> | 12:45 |
| mborzecki | mardy: hmm hmm, w8 those slots were supposed to be declared in gadget.yaml? not snap.yaml? | 13:35 |
| === dob1_ is now known as dob1 | ||
| pstolowski | maybe you mean autoconnections? | 13:40 |
| mborzecki | pstolowski: mardy oh, maybe that, but those are based on snap-ids? | 13:43 |
| mborzecki | so wouldn't work for unasserted snap anyway | 13:43 |
| pstolowski | yes, exactly | 13:43 |
| mardy | what what, I didn't get it :-) | 13:44 |
| mup | PR snapd#11279 opened: spread-shellcheck: add a caching layer <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/11279> | 13:45 |
| pstolowski | mardy: connections defined in gadget will not get auto-connected if a snap are unasserted; our code doesn't consider such snaps for auto-connections | 13:46 |
| mborzecki | mardy: anyway, i think those are supposed to be done in snap.yaml, unless i'm missing something and need to take a look at the spec again | 13:50 |
| mup | PR snapd#11280 opened: tests: spread test snap dir migration <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/11280> | 13:50 |
| mardy | pstolowski: I don't need autoconnection, I'm fine with connecting it manually; but the slot is just not there. So maybe it's as mborzecki says, that this must be in the snap.yaml | 13:51 |
| pstolowski | mardy: yes | 13:51 |
| mup | PR snapd#11122 closed: tests: setup snapd remodel testing bits <Run nested> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11122> | 14:20 |
| ogra | mardy, slots need to be in snapcraft.yaml, not gadget.yaml | 14:26 |
| ogra | https://github.com/snapcore/pi-gadget/blob/20-arm64/snapcraft.yaml#L115 | 14:26 |
| mardy | ogra: thanks, now it works | 15:42 |
| ogra | yay | 15:47 |
| mup | PR snapd#11269 closed: run-checks, check-commit-email.py: check commit email addresses for validity <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11269> | 16:26 |
| === mwhudson_ is now known as mwhudson | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!