santa_ | good morning everyone | 09:29 |
---|---|---|
RikMills | santa_: hi | 09:29 |
santa_ | RikMills: 21.12.2 tarballs are out there | 09:29 |
RikMills | they are, and building in the ppa | 09:30 |
santa_ | let me know about KA's behavior | 09:30 |
santa_ | are the changelogs properly managed? | 09:30 |
RikMills | santa_: I had comment out 2 lines from ka_changelog.py to stop me stealing the trailer | 09:31 |
santa_ | which ones? | 09:31 |
RikMills | 2 secs | 09:32 |
RikMills | in def new_upstream_release(self, new_upstream_version, stability=None): | 09:33 |
RikMills | the very final: | 09:33 |
RikMills | maintainer_str = "%s <%s>" % get_maintainer() | 09:33 |
RikMills | ummm ^ ignore that wrong paste | 09:34 |
RikMills | the final: | 09:35 |
RikMills | #self.set_author(maintainer_str) | 09:35 |
RikMills | #self.set_date(time.strftime('%a, %d %b %Y %X %z')) | 09:35 |
RikMills | commented like that ^ | 09:35 |
RikMills | a very direct hack to stop the trailer you set getting changed | 09:35 |
RikMills | there will obviously be a much better way | 09:36 |
santa_ | actually | 09:38 |
santa_ | that seems like the solution :| | 09:38 |
santa_ | we are using dch above | 09:39 |
RikMills | in that case maybe make those lines conditional on a gbp-nr argument? | 09:39 |
santa_ | no no | 09:40 |
santa_ | what happens there is that those lines were meant as a "final thing" if that could be easily managed with python-debian | 09:41 |
santa_ | but it's managed with dch | 09:42 |
santa_ | self.set_author(maintainer_str) | 09:42 |
santa_ | ↑ at least this line must be commented out | 09:42 |
santa_ | if you have another set of clones, would you mind to try commenting out ONLY: | 09:43 |
santa_ | self.set_author(maintainer_str) | 09:43 |
santa_ | ? | 09:43 |
RikMills | I don't have another, but I can fudge that | 09:44 |
santa_ | just trying with one package would be enough | 09:44 |
RikMills | I am, rolling back git a bit | 09:45 |
RikMills | santa_: https://paste.ubuntu.com/p/cjVFZSQmjy/ | 09:49 |
santa_ | so we have to comment out both | 09:50 |
santa_ | ok, so please | 09:50 |
RikMills | dpends if you want up update the trailer date of not | 09:50 |
santa_ | git pull in you KA clone | 09:50 |
santa_ | but dch already updates the trailer afaics | 09:51 |
RikMills | don't have one. this is installed KA | 09:51 |
santa_ | ok, but you can confirm commenting out both lines works properly, right? | 09:52 |
RikMills | santa_: https://git.launchpad.net/~kubuntu-packagers/kubuntu-packaging/+git/kate/commit/?h=kubuntu_jammy_staging&id=07d6415edaceff737c4feb92966b82f287393f59 | 09:53 |
ubottu | Commit 07d6415 in ~kubuntu-packagers/kubuntu-packaging/+git/kate "NOCI kubuntu_jammy_staging" | 09:53 |
santa_ | ahhh | 09:53 |
santa_ | I think I know what's missing then | 09:54 |
santa_ | hmm | 10:08 |
santa_ | wihtout commenting out anything is working fine here :| | 10:08 |
santa_ | * without | 10:08 |
RikMills | it would work for you. if I did it I would steal the trailer | 10:09 |
santa_ | akonadi (4:21.12.2-0ubuntu1) UNRELEASED; urgency=medium | 10:10 |
santa_ | [ José Manuel Santamaría Lema ] | 10:10 |
santa_ | * Update debian/watch | 10:10 |
santa_ | * Update upstream signing key | 10:10 |
santa_ | [ Other Person ] | 10:10 |
santa_ | * New upstream release (21.12.2) | 10:10 |
santa_ | -- Other Person <other@person.com> Tue, 01 Feb 2022 10:07:09 +0000 | 10:10 |
santa_ | ↑ this would be the result for me impersonating Other Person | 10:11 |
santa_ | (please don't take into account the lack of blank lines, that was just the paste) | 10:11 |
=== mamarley is now known as Guest9469 | ||
=== mamarley_ is now known as mamarley | ||
santa_ | RikMills: I mean, the bahavior is correct if it "steals" the trailer | 10:13 |
RikMills | santa_: oh, I agree | 10:13 |
RikMills | but sometimes like here we may not want to | 10:13 |
santa_ | as long as there is a [ José Manuel Santamaría Lema ] above my changes | 10:13 |
santa_ | re: "but sometimes like here we may not want to" I think in this case the right thing to do would be putting your name in the trailer | 10:15 |
RikMills | I can change that before I upload to the archive if you like | 10:16 |
santa_ | there is a check-and-fix/update-maint-trailer in KA... | 10:19 |
santa_ | which is very shoddy and needs to be fixed before using XD | 10:20 |
RikMills | I was just going to do-all sed it :P | 10:21 |
* RikMills hides | 10:21 | |
santa_ | XDD | 10:22 |
BluesKaj | Hi folks | 13:23 |
=== genii is now known as genii-core |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!