[02:51] <mup> PR snapd#11331 opened: gadget: mv modelCharateristics to gadgettest.ModelCharacteristics  <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11331>
=== amurray_ is now known as amurray
[06:31] <mborzecki> morning
=== ackk is now known as ack
[08:06] <pstolowski> morning
[08:21] <mborzecki> pstolowski: hey
[09:03] <mup> PR snapd#10166 closed: systemd: implement restart as a single systemctl restart call <Created by bboozzoo> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/10166>
[09:08] <mup> PR snapd#9846 closed: [RFC] systemd, many: no reload when enabling or disabling services <Needs Samuele review> <:birthday:> <Run nested> <Created by bboozzoo> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/9846>
[11:03] <mup> PR snapd#11200 closed: usersession/userd: query xdg-mime to check for fallback handlers of a given scheme <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11200>
[11:03] <mup> PR snapd#11264 closed: overlord: remodel getting stuck on prerequisites <⛔ Blocked> <Created by bboozzoo> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/11264>
[11:03] <mup> PR snapd#11273 closed: o/devicestate: verify that the new model is self contained before remodeling <Run nested> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11273>
[11:18] <mup> PR snapd#11332 opened: gadget/install/partition.go: include DiskIndex in synthesized OnDiskStructure <Simple 😃> <Bug> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11332>
[11:18] <mup> PR snapd#11333 opened: gadget/install: rm unused support for writing non-filesystem structures <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11333>
[11:47] <mardy> mborzecki, pstolowski: any of you is able to tell me why adding a s.settle(c) on this line causes the test to fail (no updates are found)? https://github.com/snapcore/snapd/blob/master/overlord/snapstate/snapstate_update_test.go#L3892
[11:48] <pstolowski> mardy: what is the error?
[11:48] <pstolowski> mardy: are you sure it's line 3892?
[11:53] <mardy> yes, there, I get an error on the 4th scenario: https://paste.ubuntu.com/p/FYZZktSNkX/
[11:54] <mardy> pstolowski: basically the update does not generate any tasks
[11:54] <mardy> without the s.settle(c) line, it works; I just don't understand what settle() does :-)
[12:09] <ijohnson[m]> lots of lxd fun this morning it seems
[12:09] <mup> PR snapd#11065 closed: cmd/snap: remove use of zenity, use notifications for snap run inhibition <refresh app awareness> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11065>
[12:14] <mup> PR snapd#11334 opened: gadget/install: add unit tests for makeFilesystem, allow mocking mkfs.Make() <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11334>
[12:14] <mup> PR snapd#11335 opened: gadget/install: add unit tests for install.Run() <Test Robustness> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11335>
[12:42] <pstolowski> mardy: if you add settle() there you are actually executing the tasks. as is now they are created but not run afaict
[12:47] <mborzecki> ijohnson: hi, have you seen somehing like this maybe? https://pastebin.ubuntu.com/p/STBZMQwZmh/
[12:48] <ijohnson[m]> bboozzoo: yeah we don't have a solution other than to retry
[12:48] <ijohnson[m]> https://github.com/snapcore/snapd/blob/09b4d9128ef9c9584fffebc17ee84900fad5c800/tests/lib/nested.sh#L87-L97
[12:49] <ijohnson[m]> but Sergio has more details
[12:52] <mardy> pstolowski: I finally found the solution, the state was leaking from one iteration of the tests to the next one: https://github.com/snapcore/snapd/pull/11321/commits/9f50b31c04d0e869a0e640fae66b75282c1d809e
[12:52] <mup> PR #11321: overlord: fix issue with snapshot restoring on CentOS <Needs Samuele review> <Created by mardy> <https://github.com/snapcore/snapd/pull/11321>
[12:55] <pstolowski> mardy: nice find. maybe you can replace s.settle(c) there with explicit chg.SetStatus(Done) there?
[12:57] <mardy> pstolowski: I'll try, thanks
[13:03] <mborzecki> mardy: or just make this a function helper like we sometimes do, eg. `func (s *suite) TestFoo{1,2}()` call `func (s *suite) testFoo(c *C, some param)` 
[13:04] <pstolowski> or have new state on every iteration (do not use s.state), unless it needs complicated setup in SetUp()
[13:18] <mup> PR snapcraft#3631 opened: parts: add early base parsing (CRAFT-766) <Created by cmatsuoka> <https://github.com/snapcore/snapcraft/pull/3631>
[13:54] <mup> PR snapd#11336 opened: cmd/snap: add --debug to snap run <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/11336>
[14:49] <mup> PR snapd#11337 opened: many: fix leftover empty snap dirs <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/11337>
[18:26] <mup> PR core20#130 opened: static: remove perl dependency <Created by kubiko> <https://github.com/snapcore/core20/pull/130>
[18:42] <mup> PR core20#131 opened: No ssh key in install mode <Created by kubiko> <https://github.com/snapcore/core20/pull/131>