[02:58] <mup> PR snapd#11331 closed: gadget: mv modelCharateristics to gadgettest.ModelCharacteristics  <Simple 😃> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/11331>
=== mwhudson_ is now known as mwhudson
[06:47] <mborzecki> morning
[06:48] <mup> PR snapd#11336 closed: cmd/snap: add --debug to snap run <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/11336>
[07:17] <mardy> hi!
[07:33] <mborzecki> mardy: heyaa
[08:02] <pstolowski> morning
[08:04] <mup> PR snapd#11303 closed: overlord/servicestate: disallow mixing snaps and subgroups <Created by Meulengracht> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11303>
[08:59] <mup> PR snapd#11330 closed: spread: switch to CentOS 8 Stream image <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/11330>
[10:09] <mup> PR snapd#11255 closed: many: transactional installs/removes/refreshes <Needs Samuele review> <Created by alfonsosanchezbeato> <Closed by alfonsosanchezbeato> <https://github.com/snapcore/snapd/pull/11255>
[10:09] <mup> PR snapd#11290 closed: cmd/snap-confine: mount bpffs under /sys/fs/bpf if needed <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11290>
[10:54] <mup> PR snapd#11338 opened: asserts,cmd/snap-repair: support delegation when validating signatures <authority-delegation> <Created by pedronis> <https://github.com/snapcore/snapd/pull/11338>
[12:25] <mup> PR snapd#11327 closed: snap-confine: allow numbers in hook security tag <Bug> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11327>
[12:26] <mardy> mborzecki, pstolowski: do you know better ways to do this? https://github.com/snapcore/snapd/pull/11321/commits/edca569444e93526dc587622de283567319175eb
[12:26] <mup> PR #11321: overlord: fix issue with snapshot restoring on CentOS <Needs Samuele review> <Created by mardy> <https://github.com/snapcore/snapd/pull/11321>
[12:26] <mardy> I wanted to use o.Settle(), but it's incompatible with o.Loop(), which the test uses
[12:32] <mborzecki> mardy: heh, was abou to write that the test shuld probably call settle, but this one is odd
[12:36] <pstolowski> mardy, mborzecki yeah my first instinct would be to try to make it use settle() instead, or is it problematic in this test?
[12:39] <pstolowski> mardy: you can also just wait for chg.Ready() channel, not sure if it helps?
[12:40] <pstolowski> <-chg.Ready() would block until ready afair
[12:40] <mborzecki> mardy: you can try something like https://github.com/snapcore/snapd/pull/11321/commits/edca569444e93526dc587622de283567319175eb#r798522418 maybe? but that's just a refactor of the code, nothing special
[12:40] <mup> PR #11321: overlord: fix issue with snapshot restoring on CentOS <Needs Samuele review> <Created by mardy> <https://github.com/snapcore/snapd/pull/11321>
[12:41] <pstolowski> nvm, <-chg.Ready() is already there
[12:47] <mardy> pstolowski: yes, but I don't only need for the change to be ready, it needs to be clean (the Ensure() function goes through completed tasks and invokes their cleanup handler, or directly marks them clean if there is no handler)
[12:48] <pstolowski> mardy: yes i know, i assume Ready() is the first barrier; but then setting clean flag happens asynchronously as well
[12:49] <pstolowski> anyway, what mborzecki suggested is a more idiomatic way in go / a bit nicer
[12:49] <mardy> mborzecki: looks good, but I guess that I don't nee to to break back to the beginning of the loop; it seems to me that I can just use an ordinary "break" with no label
[13:01] <mardy> ah, no, my ignorance, nevermind :-)
[13:55] <mup> PR snapd#11176 closed: tests/core/failover: verify failover handling with the kernel snap <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11176>
[16:54] <arsenique> zyga sorry to bother u again. could u have a look at https://github.com/snapcore/snapd/pull/11245 (vscode pr)?
[16:54] <mup> PR #11245: vscode: added integrated support for MS VSCODE <Created by are-scenic> <https://github.com/snapcore/snapd/pull/11245>
[16:56] <mup> PR snapd#11339 opened: o/servicestate: revert #11003 checking for memory cgroup being disabled <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11339>
[16:58] <zyga-office> arsenique, re
[16:58] <zyga-office> arsenique, looking
[16:58] <arsenique> thank u.
[16:59] <zyga-office> arsenique, I don't see any replies to any of the points I made about extra extensions
[16:59] <zyga-office> arsenique, did you send your replies? they can be stuck in github until you send the entire review response
[16:59] <arsenique> https://github.com/snapcore/snapd/pull/11245#discussion_r795442967
[16:59] <mup> PR #11245: vscode: added integrated support for MS VSCODE <Created by are-scenic> <https://github.com/snapcore/snapd/pull/11245>
[17:00] <zyga-office> arsenique, after my comments there's a message from miguelpires but I don't see anything more recent
[17:00] <zyga-office> I only see my comment there
[17:00] <zyga-office> if you see more you must have a pending review
[17:00] <arsenique> zyga look at my replies to your comments
[17:00] <zyga-office> there are no replies
[17:00] <zyga-office> check in a privater browser window
[17:00] <zyga-office> *private
[17:00] <arsenique> please follow the link https://github.com/snapcore/snapd/pull/11245#discussion_r795442967
[17:01] <zyga-office> again
[17:01] <arsenique> the replies appear close to the comment, not as a new one
[17:01] <zyga-office> please open a private browser window
[17:01] <zyga-office> I don't see a single comment there
[17:01] <zyga-office> perhaps others can confirm
[17:02] <zyga-office> I'm 100% sure you have a pending review that you yourself can see
[17:02] <zyga-office> but until you send the review
[17:02] <zyga-office> those comments are invisible to others
[17:02] <arsenique> yes I see it in all browsers I have
[17:02] <zyga-office> then github is broken
[17:02] <zyga-office> can you paste your comments?
[17:03] <zyga-office> (in all browsers that you are not logged in as yourself?)
[17:03] <miguelpires> arsenique zyga-office can confirm, I don't see any replies as well
[17:03] <zyga-office> try a private window, if that works
[17:03] <zyga-office> thanks miguelpires 
[17:03] <zyga-office> arsenique, github UX sucks on this
[17:03] <zyga-office> you must be logged in
[17:03] <zyga-office> finish review and the replies will show up
[17:05] <arsenique> <miguelpires> did you try the link that I suggested?  https://github.com/snapcore/snapd/pull/11245#discussion_r795442967
[17:05] <mup> PR #11245: vscode: added integrated support for MS VSCODE <Created by are-scenic> <https://github.com/snapcore/snapd/pull/11245>
[17:06] <zyga-office> can you share a screenshot?
[17:07] <arsenique> yeap. 
[17:10] <arsenique> zyga sorry for a stupid question, is it possible to share screenshot here somehow?
[17:10] <zyga-office> arsenique, you have to use a 3rd party like imgurl
[17:11] <zyga-office> or twitter or whatever you prefer
[17:11] <arsenique> got it
[17:11] <zyga-office> but irc itself is text only
[17:11] <miguelpires> arsenique: yes, I did. zyga-office is right, your comments are still pending (they say so at the top, next to your name). You made a review instead of replying so you need to finish the "review" by submitting
[17:11] <arsenique> i feel so stupid
[17:11] <miguelpires> (for context, arsenique shared a screenshot with me OOB)
[17:12] <pstolowski> everyone been there ;)
[17:12] <pstolowski> github ui sucks
[17:12] <arsenique> in this very thing at least...and big time
[17:13] <zyga-office> no worries arsenique 
[17:13] <zyga-office> github is very broken on this aspect
[17:13] <zyga-office> you've waited for days without feedback
[17:13] <zyga-office> but I bet we're not unique here
[17:15] <pstolowski> thanks heaven gh is not loosing those pending comments
[17:16] <miguelpires> arsenique: did you submit the review?
[17:17] <zyga-office> I don't think so
[17:18] <arsenique> funny part I am struggling to find this bloody review button. I am an author of this pr, so perhaps that is why I don't have this button.
[17:18] <arsenique> or I am that thick :-(
[17:19] <zyga-office> you have it
[17:19] <pstolowski> arsenique: author has this button
[17:19] <zyga-office> anyone leaving a comment has two optinons
[17:19] <zyga-office> send the comment right now
[17:19] <zyga-office> or "start a review"
[17:19] <pstolowski> green "Review changes" in the "Fileschanged" tab
[17:19] <zyga-office> that other thing creates a stash of comments
[17:19] <zyga-office> what pstolowski said :)
[17:20] <zyga-office> I've been on gitlab for a while and I'm not used to github UI anymore
[17:20] <miguelpires> Yes, the green button at the top that says something like "Finish your review"
[17:20] <arsenique> omg are they serious???????????????????????????????????????????????????????????
[17:21] <pstolowski> usability 101
[17:21] <arsenique> do they know the meaning of ux?
[17:21] <arsenique> seriously who is that genius that decided on how this flow shall work?!
[17:22] <zyga-office> I see your comments now
[17:23] <arsenique> i am really puzzled right now. i don't know how to feel right now. being angry or stupid?!
[17:24] <arsenique> zyga pstolowski miguelpires thank you all guys so much for your help and patience.
[17:25] <zyga-office> I replied to your comments now
[17:25] <zyga-office> arsenique, just let it out, it's very frustrating
[17:25] <zyga-office> I think everyone here bumped into this the same way
[17:25] <zyga-office> it's just meh
[17:25] <zyga-office> bad bad bad interface
[17:27] <arsenique> thanks a lot guys. very much appreciated.
[17:27] <zyga-office> thanks for pushing forward :)
[17:32] <pstolowski> np
[17:36] <mup> PR snapd#11340 opened: [systemd] fix systemd unit stop progress notifications <Created by flotter> <https://github.com/snapcore/snapd/pull/11340>
[18:41] <mup> PR snapd#11341 opened: tests: updated the documentation to run spread tests using external backend <Simple 😃> <Skip spread> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/11341>
[19:26] <mup> PR snapd#11342 opened: tests: add regression tests for disabled memory cgroup operation <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11342>
[20:07] <mup> PR snapd#11339 closed: o/servicestate: revert #11003 checking for memory cgroup being disabled <⚠ Critical> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11339>
[21:16] <mup> PR snapcraft#3631 closed: parts: add early base parsing (CRAFT-766) <Created by cmatsuoka> <Merged by cmatsuoka> <https://github.com/snapcore/snapcraft/pull/3631>
[21:27] <mup> PR snapd#11343 opened: tests: reboot test running remodel <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/11343>
[21:42] <mup> PR snapd#11344 opened: cmd/snap/auto-import: use osutil.LoadMountInfo impl instead <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11344>
[22:12] <mup> PR snapd#11345 opened: tests/main/snap-system-key: reset-failed snapd and snapd.socket <Simple 😃> <Test Robustness> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11345>