| mborzecki | morning | 07:20 |
|---|---|---|
| mup | PR core18#186 closed: Handle PPAs being served from ppa.launchpadcontent.net <Created by cjwatson> <Merged by alfonsosanchezbeato> <https://github.com/snapcore/core18/pull/186> | 07:51 |
| mardy | hi mborzecki, mvo | 07:57 |
| mborzecki | hey | 07:58 |
| mup | PR snapd#11181 closed: usersession/userd: support Cloudflare WARP URL scheme <Created by schultetwin1> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/11181> | 08:07 |
| mborzecki | mardy: do the microk8s guys know whether `k` is needed there too? https://github.com/snapcore/snapd/pull/11286#discussion_r798416451 | 08:08 |
| mup | PR #11286: i/b/kubernetes_support: open access to NVIDIA GPUs <Created by mardy> <https://github.com/snapcore/snapd/pull/11286> | 08:08 |
| mborzecki | or whether the PR in its current form solves their problem | 08:08 |
| mup | PR core20#129 closed: Handle PPAs being served from ppa.launchpadcontent.net <Created by cjwatson> <Merged by alfonsosanchezbeato> <https://github.com/snapcore/core20/pull/129> | 08:09 |
| mardy | mborzecki: I didn't hear any feedback | 08:16 |
| pstolowski | morning | 08:18 |
| mardy | pstolowski: hi! | 08:25 |
| mardy | pstolowski, mborzecki: maybe you can help me: I made these changes (https://paste.ubuntu.com/p/TPFgn3pprR/) and now the tests are failing like this: https://paste.ubuntu.com/p/cbRkzB8tTZ/ | 08:38 |
| mardy | do you know what I need to do in order for the task to advance its state? (a call to settle() is already present) | 08:38 |
| mborzecki | mardy: are you sure that's the only change? | 08:42 |
| pstolowski | mardy: also, is thare Retry returned by any task? I usually add a loop to print all tasks and their statuses in such cases | 08:43 |
| mborzecki | mardy: i've added a dumpTasks() helper in managers_test.go, maybe you can use that to print the task states | 08:44 |
| mborzecki | maybe you can also grab the logger buffer and print it out? | 08:45 |
| * mardy tries | 08:49 | |
| mardy | here's with dumpTasks: https://paste.ubuntu.com/p/VYfCFYH8k4/ | 08:54 |
| mardy | mborzecki: do you have any example where we print the logs? | 08:54 |
| pstolowski | mardy: look for logbuf, restore := logger.MockLogger(); also task.Log() and change.Log() | 08:57 |
| mborzecki | mardy: or try something like this: https://paste.ubuntu.com/p/3m5D7SsxJk/ | 08:58 |
| pstolowski | mardy: auto-connect may retry if there is a conflict | 08:59 |
| pstolowski | that would be 1st suspect | 08:59 |
| pstolowski | Retry means task remains in "Doing" and is reconsidered some time later | 09:00 |
| mardy | pstolowski: but how can I trigger a retry? | 09:08 |
| pstolowski | mardy: by resolving the conflict | 09:09 |
| pstolowski | mardy: but hold on | 09:10 |
| mardy | indeed, after applying mborzecki's patch I see that the last log line is "task 2 err: task should be retried" | 09:11 |
| zyga[m] | good morning | 09:12 |
| mardy | zyga[m]: hi! | 09:12 |
| pstolowski | hey zyga[m] ! | 09:12 |
| pstolowski | mardy: with your changes, is IsClean() going to return false if task is no Ready yet? | 09:13 |
| mardy | pstolowski: yes (unless I did something wrong) | 09:16 |
| mardy | pstolowski: "clean" should mean "ready and the cleanup handler ran (if present)" | 09:16 |
| pstolowski | mardy: got it, makes sense | 09:17 |
| pstolowski | mardy: i don't understand why TestAutoConnectDuringCoreTransition is failing with conflict after your changes, seems like maybe the task is not considered clean. I'd add debug in checkAutoconnectConflicts() and printy IsClean and Ready state and just run this test | 09:22 |
| mardy | pstolowski: OK, will do; but I don't know how to run a single test :-) | 09:23 |
| pstolowski | mardy: go test -check.f TestAutoConnectDuringCoreTransition (or another substring that matches testsuite/testnames) | 09:24 |
| mardy | pstolowski: thanks! So, the task is ready (task.Status().Ready() returns true), but task.IsClean() is false. I wonder if the logic I added in taskrunner is wrong then... (https://github.com/snapcore/snapd/pull/11321/files#diff-d38844f5dd133b4b7dedd1f94bd2e344ae8762fbb756e4e155ec7276e9a88b7a) | 09:29 |
| mup | PR #11321: overlord: fix issue with snapshot restoring on CentOS <Needs Samuele review> <Created by mardy> <https://github.com/snapcore/snapd/pull/11321> | 09:29 |
| mardy | maybe it has something to do with task <-> change status sync | 09:30 |
| mardy | oh, the change associated to the task is not clean nor ready | 09:32 |
| mvo | hey mardy, mborzecki and pstolowski - good morning! | 09:35 |
| mardy | do I understand correctly, that a change can have many associated tasks? | 09:36 |
| pstolowski | hey mvo ! | 09:36 |
| pstolowski | mardy: yes, change has many tasks. but tasks can only belong to a single change | 09:36 |
| mardy | pstolowski: but then it seems to me that the check I'm doing here is wrong, and that I should check the status on the task, and not on the change: https://github.com/snapcore/snapd/pull/11321/files#diff-d38844f5dd133b4b7dedd1f94bd2e344ae8762fbb756e4e155ec7276e9a88b7a | 09:37 |
| mup | PR #11321: overlord: fix issue with snapshot restoring on CentOS <Needs Samuele review> <Created by mardy> <https://github.com/snapcore/snapd/pull/11321> | 09:37 |
| mardy | though given that it was Samuele to suggest it like this, I bet he had his reasons | 09:38 |
| pstolowski | mardy: looks good to me, otoh maybe checking just the task would be semantically the same in this case. but by definition change is only clean if all tasks are clean (just like Ready status), so nothing wrong with it afaict | 09:42 |
| tobias_ | Is it still the case that *gadget* snaps (small additions on top of the official Raspberry Pi gadget like splash screen image and snap configuration/connections) require a paid brand store upload + auto-update? Just to clarify, don't want to open a discussion about business models 🙂 | 09:56 |
| mborzecki | tobias_: a brand store in order to publish gadget snaps yes afak, connections/configuration can be put in gadget.yaml regardless of that, i'm not sure what you mean by auto-update though | 10:03 |
| mborzecki | tobias_: as for brand store, if it's an open source project something can be probably arranged, iirc gnuradio has a brand store | 10:04 |
| tobias_ | mborzecki: Yeah sorry, I meant publishing a gadget snap so that it can be refreshed (updated) from the store on deployed devices. I currently build images with a local gadget, but e.g. when Pi kernel assets moved from the gadget to the kernel snap, existing devices could no longer refresh the official pi-kernel snap until users copied my newer gadget snap to their device and ran a manual refresh. Same with the migration from mir-kiosk to | 10:20 |
| tobias_ | ubuntu-frame – requires a manual gadget refresh. We're a small open source project and have mostly non-commercial home users at the moment, but do intend to sell B2B support licenses for the software to keep the lights on 🙂 | 10:20 |
| tobias_ | Thanks for the clarification! | 10:20 |
| mup | PR snapd#11351 closed: tests/nested/manual/remodel-cross-store,remodel-simple: wait for serial <Simple 😃> <Test Robustness> <Run nested> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11351> | 10:57 |
| mup | PR snapd#11352 opened: packaging/fedora: sync with downstream, packaging improvements <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/11352> | 11:32 |
| mup | PR snapd#11353 opened: systemd: do not reload system when enabling/disabling services <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/11353> | 12:53 |
| mup | PR snapd#11335 closed: gadget/install: add unit tests for install.Run() <Test Robustness> <Skip spread> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/11335> | 13:33 |
| mup | PR snapd#11345 closed: tests/main/snap-system-key: reset-failed snapd and snapd.socket <Simple 😃> <Test Robustness> <Created by anonymouse64> <Merged by MiguelPires> <https://github.com/snapcore/snapd/pull/11345> | 13:38 |
| mup | PR snapcraft#3634 opened: dependencies: missing library resolution (CRAFT-422) <Created by mr-cal> <https://github.com/snapcore/snapcraft/pull/3634> | 14:12 |
| mup | PR snapcraft#3628 closed: Autotools Plugin (v1): Fix fatal crash when running autogen.sh or bootstrap <Created by diddledani> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3628> | 14:57 |
| mup | PR snapd#10427 closed: interfaces/cups: add cups-socket-directory attr, use to specify mount rules in backend <Needs Samuele review> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10427> | 15:13 |
| mup | PR snapd#11320 closed: osutil/mkfs: Expose more fakeroot flags <Created by GlenPickle> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11320> | 15:43 |
| mup | PR snapd#11354 opened: gadget: identify/match encryption parts, include in traits info <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11354> | 17:29 |
| mup | PR snapcraft#3629 closed: sources: make submodule fetching configurable <Created by mr-cal> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3629> | 17:37 |
| mup | PR snapd#11341 closed: tests: updated the documentation to run spread tests using external backend <Simple 😃> <Skip spread> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/11341> | 18:04 |
| mup | PR snapd#11355 opened: Changes necessary for ubuntu-image to support preseeding extra snaps in classic images <Created by GlenPickle> <https://github.com/snapcore/snapd/pull/11355> | 18:49 |
| mup | PR snapcraft#3632 closed: 20.00 <Created by eliekh05> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3632> | 18:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!