| mup | PR snapd#11356 opened: spread: non-functional cleanup of go1.6 legacy <Created by are-scenic> <https://github.com/snapcore/snapd/pull/11356> | 00:40 |
|---|---|---|
| === not_phunyguy is now known as phunyguy | ||
| mup | PR snapd#11357 opened: interfaces/seccomp: Add rseq to base seccomp template <Created by alexmurray> <https://github.com/snapcore/snapd/pull/11357> | 05:01 |
| mborzecki | morning | 06:44 |
| pstolowski | morning | 08:04 |
| mup | PR snapd#11352 closed: packaging/fedora: sync with downstream, packaging improvements <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11352> | 08:42 |
| ZygmuntKrynicki[ | hello everyone :) | 09:44 |
| pstolowski | ZygmuntKrynicki[: hello zyga's wannabe ;) | 09:51 |
| ZygmuntKrynicki[ | pstolowski: the matrix has me :) | 09:57 |
| pstolowski | :) | 09:58 |
| mup | PR snapd#11358 opened: cmd/snap-confine: build const data structures at compile-time <Created by mardy> <https://github.com/snapcore/snapd/pull/11358> | 10:02 |
| pstolowski | ogra: hi! do you remember when we discussed a refresh-app-awareness notification message that looked very bad in german (due to length & snap name at the end possible getting truncated)? | 10:21 |
| pstolowski | *possibly | 10:21 |
| ogra | pstolowski, yep, i still see them at times | 10:22 |
| pstolowski | ogra: sure, nothing has been done about it. tbh I forgot what was the plan... is this something to be solved in the translation maybe? | 10:22 |
| ogra | well, you could make a rule for translators to always put the app name first or some such | 10:23 |
| pstolowski | or shall we reword the underlaying message and update trans? | 10:23 |
| pstolowski | indeed | 10:23 |
| ogra | not sure how much that would help though, if the app name is long you'd not see the message and just an icon and the app name | 10:23 |
| pstolowski | oh well, we cannot solve notification issues | 10:24 |
| ogra | ZygmuntKrynicki[, bah, you made my hexchat move the "nick line" in teh chat window with your looooooong nick ... 😛 | 10:24 |
| pstolowski | but it should be better than what it is now | 10:24 |
| ZygmuntKrynicki[ | oh man, is my nick my full name? | 10:25 |
| * ZygmuntKrynicki[ fixes that | 10:25 | |
| pstolowski | ogra: you didn't realize this but his nickname has a payload, he is now browsing your / ;) | 10:25 |
| ogra | LOL | 10:26 |
| === ZygmuntKrynicki[ is now known as zyga[m] | ||
| zyga[m] | sorry, Matrix is a bit confusing for me still | 10:26 |
| zyga[m] | hey ogra , how are you doing? | 10:26 |
| ogra | thats better 🙂 | 10:26 |
| ogra | zyga[m], so so ... | 10:26 |
| zyga[m] | I remember our last conversation | 10:27 |
| zyga[m] | life is tough sometimes | 10:28 |
| ogra | well, life is life ... but yeah, gotta take the bite it gives you | 10:28 |
| pstolowski | ogra: sorry to hear.. are you coming to the sprint? | 10:32 |
| ogra | pstolowski, i wasnt invited ... | 10:32 |
| pstolowski | ah | 10:33 |
| ogra | (and i can'T really easily travle atm either) | 10:33 |
| ogra | *travel | 10:33 |
| mardy | ogra: I thought you were living in Germany | 10:35 |
| ogra | mardy, i do ... even just 180km away from the venue where the sprint is | 10:39 |
| ogra | (it's even a fun 1-2h autobahn ride 🙂 ) | 10:41 |
| mardy | abeato_: hi! I'm looking at your hack-root-homedir branch, and I see that among the root directories you create there are some that look new to me: "host", "meta", "writable". I guess that tha latter is used for supporting /etc/writable/, but what are the other two? | 10:46 |
| abeato_ | mardy, hey! the objective of the branch was to show how you could get a HOMEDIR in / by using tmpfs, so I created some of those with random names | 10:50 |
| abeato_ | mardy, so, nothing special about those names, it was just testing that using tmpfs in / was feasible and that any non-conflicting path could be created there | 10:51 |
| mardy | abeato_: ah, I see, so I won't need them. What about /boot? Do you think we need to expose it to the snap? | 10:55 |
| abeato_ | mardy, it is one of folders in coreXX, so probably yes, if we want to keep things compatible. What is needed is to loop through the folders in coreXX and create the corresponding folders in the tmpfs that will then used as mount points | 10:57 |
| abeato_ | for the folders in base | 10:57 |
| mardy | abeato_: right, I guess that in order to retain a behaviour as much as possible similar to the current one, I'll go through the root directories of the base snap and recreate+mount them into the tmpfs | 11:08 |
| abeato_ | yeah, exactly | 11:08 |
| abeato_ | hmm, I'm getting these errors in CI; | 11:15 |
| abeato_ | There are files left in the git tree after the tests: | 11:15 |
| abeato_ | ?? "cmd/snap-seccomp/\020\017\005\205\300t\025H\215=\346$\t" | 11:15 |
| abeato_ | which is weird, as the PR is not related to the failing tests at all | 11:16 |
| mup | PR snapd#11359 opened: o/snapstate: reduce maxInhibition for refresh app awereness by 1s to avoid confusing notification <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/11359> | 11:52 |
| mardy | mborzecki: in the "legacy mode" of snap-confine we still call pivot_root, don't we? | 12:28 |
| mborzecki | mardy: hmm there's a comment which says we don't, but code suggests otherwise | 12:31 |
| mardy | mborzecki: exactly, I was asking precisely because I saw the comment but the code did not seem to match | 12:38 |
| mardy | I'll make a mini-PR for fixing the comment | 12:39 |
| mardy | zyga[m]: let's see if I can use a bit of your memory :-) You introduced "legacy mode" with https://github.com/snapcore/snapd/commit/5dafcf92ed031700c013fd93c01f47d55d7d21c9 but looking at the current code, it seems we do always call pivot_root | 12:44 |
| mup | PR snapd#11360 opened: cmd/snap-confine: update ambiguous comment <Simple 😃> <Skip spread> <Created by mardy> <https://github.com/snapcore/snapd/pull/11360> | 13:18 |
| zyga[m] | I'll respond shortly | 13:33 |
| mardy | zyga[m]: no hurry, but maybe it's better if you comment on the PR above, when you get some time ^ | 13:40 |
| zyga[m] | <mardy> "zyga: let's see if I can use a..." <- mardy: legacy mode was always designed to be used in a single configuration: core (aka core16)-based device running core-based stanp | 13:44 |
| zyga[m] | so it's natural that over time it just doesn't get used much | 13:44 |
| zyga[m] | I'll check the link now | 13:44 |
| mborzecki | mardy: heh, the place where is_normal is set is not quite obvious | 13:46 |
| zyga[m] | mardy: ah, so the question is about the comment | 13:48 |
| zyga[m] | mardy: yeah, we later switch to pivot all the time, the only difference is where we are starting from | 13:49 |
| zyga[m] | https://github.com/snapcore/snapd/blob/master/cmd/snap-confine/mount-support.c#L708 | 13:50 |
| zyga[m] | some comments are indeed stale | 13:50 |
| mborzecki | zyga: yeah, the comment is confusing now, we do call pivot, but we do not pivot to the base which is the rootfs mounted at scratch dir, but back to / which is the same rootfs basically | 13:51 |
| zyga[m] | yes | 13:51 |
| miguelpires | mvo: hey, can you merge https://github.com/snapcore/snapd/pull/11316 please? failures are unrelated | 14:26 |
| mup | PR #11316: o/snapstate: revert migration on refresh if flag is disabled <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/11316> | 14:26 |
| mvo | miguelpires: sure | 14:26 |
| miguelpires | thanks | 14:27 |
| mup | PR snapd#11316 closed: o/snapstate: revert migration on refresh if flag is disabled <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11316> | 14:28 |
| mup | PR snapd#11360 closed: cmd/snap-confine: update ambiguous comment <Simple 😃> <Skip spread> <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11360> | 14:53 |
| mup | PR snapd#11356 closed: spread: non-functional cleanup of go1.6 legacy <Created by are-scenic> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11356> | 15:03 |
| mup | PR snapd#11361 opened: cmd/snap-confine: remove mention of "legacy mode" from comment <Simple 😃> <Skip spread> <Created by mardy> <https://github.com/snapcore/snapd/pull/11361> | 15:03 |
| mup | PR snapd#11220 closed: gadget/gadget.go: add AllDiskVolumeDeviceTraits <Needs Samuele review> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/11220> | 15:28 |
| mborzecki | ijohnson: hm did https://github.com/snapcore/snapd/pull/11220 depend on any changes that were reverted from master? | 15:40 |
| mup | PR #11220: gadget/gadget.go: add AllDiskVolumeDeviceTraits <Needs Samuele review> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/11220> | 15:40 |
| mborzecki | looks like the master broke after I merged it, but the CI chceks were all green | 15:40 |
| mup | PR snapd#11362 opened: String functions simplification <Simple 😃> <Created by mardy> <https://github.com/snapcore/snapd/pull/11362> | 15:48 |
| mup | PR snapd#11363 opened: gadget/gadget_test.go: fix variable type <⚠Critical> <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/11363> | 15:48 |
| mup | PR snapd#11363 closed: gadget/gadget_test.go: fix variable type <⚠Critical> <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by MiguelPires> <https://github.com/snapcore/snapd/pull/11363> | 16:24 |
| mup | PR snapcraft#3634 closed: dependencies: missing library resolution (CRAFT-422) <Created by mr-cal> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3634> | 17:14 |
| mup | PR snapd#11364 opened: [WIP] many: fix golangci checks and allow it to fail build <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/11364> | 17:39 |
| mup | PR snapd#11361 closed: cmd/snap-confine: remove mention of "legacy mode" from comment <Simple 😃> <Skip spread> <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11361> | 17:54 |
| mup | PR snapcraft#3635 opened: sources: make submodule fetching configurable <Created by mr-cal> <https://github.com/snapcore/snapcraft/pull/3635> | 21:25 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!