| cjp256 | thanks blackboxsw/falcojr for the last minute ask :D | 18:10 |
|---|---|---|
| blackboxsw | cjp256: falcojr https://github.com/canonical/cloud-init/pull/1265/files#r807157218 would this cause a problem across boot stages with our unpickle resetting _iso_dev = None every time we deserialize the cached DS obj,pkl? | 18:21 |
| ubottu | Pull 1265 in canonical/cloud-init "sources/azure: report ready in local phase" [Merged] | 18:21 |
| falcojr | I was understanding it as not wanting the value to get cached at all, but maybe that was a wrong assumption | 18:25 |
| cjp256 | blackboxsw: nah, we are purposely clearing/(re)initializing these vars that we don't want to persist - iso_dev is now one of them. Previously it needed to be re-used in non-local phase | 18:41 |
| blackboxsw | I think _report_ready should have been called by crawl_metadata anyway which should effectivly set self._iso_dev = None anyway. ok thanks for clarification there | 18:42 |
| blackboxsw | I just got pricklies seeing us back off from the hasattr check | 18:43 |
| === arif-ali_ is now known as arif-ali | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!