Eighth_Doctor | falcojr: hey, could you take a look at this (trivial) PR? https://github.com/canonical/cloud-init/pull/1345 | 13:29 |
---|---|---|
ubottu | Pull 1345 in canonical/cloud-init "Add myself as a future contributor" [Open] | 13:29 |
=== blackboxsw_afk is now known as blackboxsw | ||
blackboxsw | falcojr: did you say there was a 2nd PR up related to https://github.com/canonical/cloud-init/pull/1339. I think your suggestions on that PR make sense and we want the generator to emit /run/cloud-init/disabled makes sense | 16:39 |
ubottu | Pull 1339 in canonical/cloud-init "cmd/status: Check for proper file for stats from cloud-init-generator" [Open] | 16:39 |
blackboxsw | was the ask there to cobble up a unit test for generator logic? | 16:40 |
blackboxsw | working through schema review 1341 | 17:11 |
holmanb | henk: Sorry for the delayed response. I just refreshed my memory on cloud-init locale code, it seems my former statement was incorrect. Assuming you're running on a debian-based distro (per the apt keys in your cloud config), this is a relevant section of code: https://github.com/canonical/cloud-init/blob/main/cloudinit/distros/debian.py#L395. It seems locales are not regenerated when you set locale to `C.UTF-8`. | 17:35 |
holmanb | henk: I'd suggest opening a bug report or PR with your requested changes. | 17:36 |
henk | holmanb: yes, that was my understanding of the code as well. | 19:02 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!