rbasak | Why is list(lp.people['ubuntu-sponsors'].getRequestedReviews()) empty, even though https://code.launchpad.net/~ubuntu-sponsors/+activereviews has results? | 12:00 |
---|---|---|
rbasak | I'm looking to fix up the sponsoring page to display MPs again (but this time git-ubuntu rather than bzr). | 12:01 |
rbasak | It looks to me that the code should already work anyway, if I add ~ubuntu-sponsors as a reviewer to those branches. | 12:01 |
rbasak | But it's not, and I narrowed it down to getRequestedReviews() as above. | 12:02 |
cjwatson | Because I never got round to figuring out the correct response to the review feedback on https://code.launchpad.net/~cjwatson/launchpad/git-getRequestedReviews/+merge/271136 | 12:04 |
rbasak | Ah, OK. Thank you for working on this. | 12:06 |
rbasak | Recently I've seen an increase in people filing MPs against git-ubuntu branches. I think people are assuming that if they submit such an MP then somebody will review it, but currently that doesn't happen. | 12:07 |
rbasak | I was hoping to connect it up to the sponsoring page at least. | 12:07 |
rbasak | For now I was just going to have a bot add a ~ubuntu-sponsors review slot for every ~git-ubuntu-import review slot, and then abstain the ~git-ubuntu-import slot with an explanation. | 12:07 |
rbasak | And then make sure that the sponsoring page displays those MPs like it used to for bzr MPs. | 12:08 |
rbasak | I can't think of a way to do this without getRequestedReviews() :-/ | 12:08 |
cjwatson | Yeah, I think it probably does need that, but I'm not sure when I'll have time to work on this | 12:10 |
cjwatson | Maybe my comments are intelligible to some of my colleagues? | 12:10 |
jugmac00 | cough... :-) | 12:38 |
jugmac00 | we are all pretty busy - maybe we need to do some repriorization | 12:38 |
rbasak | It doesn't block me from anything. It's just a wart I was hoping to fix. So not massively urgent, but it'd be nice to be able to handle these MPs better. | 14:12 |
=== chrisccoulson_ is now known as chrisccoulson |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!