| sbeattie | ahasenack: is there a reason there isn't symbol version tracking on the library symbols? | 00:10 |
|---|---|---|
| ahasenack | let me check | 00:10 |
| ahasenack | sbeattie: not that I'm aware of | 00:11 |
| ahasenack | no reason | 00:11 |
| sbeattie | ahasenack: also please please please don't make the fusermount-copy setuid | 00:11 |
| ahasenack | never | 00:11 |
| ahasenack | it currently isn't, and I won't, and debian also won't (they got in touch with me) | 00:11 |
| ahasenack | I'll check the symbols tracking story | 00:12 |
| sbeattie | figuring out how get more tests running during build/adt would be great but won't be a blocker. | 00:12 |
| ahasenack | sbeattie: they have a unit test infra in place, but zero tests for it | 00:42 |
| ahasenack | I asked, and the tl;dr seems to be once they finally got the infra in place, they moved to github tests that were being developed in parallel, and rely on those now only | 00:43 |
| ahasenack | I can even enable unit tests during build, but it will say "0 tests run" in a nice little report | 00:43 |
| sbeattie | lovely | 00:43 |
| ahasenack | for adt, I added that test to create and mount a volume | 00:44 |
| ahasenack | it's a bit limited what I can do with just localhost | 00:44 |
| ahasenack | ideally it would be 3 vms (it's how I test locally) | 00:44 |
| sbeattie | yeah, it's a great smoke test, but not exactly comprehensive. | 00:44 |
| ahasenack | 4 actually, one is a client | 00:44 |
| sbeattie | are the github tests gettable in some way? | 00:45 |
| ahasenack | let me check | 00:46 |
| ahasenack | sbeattie: grabbed a PR at random: https://github.com/gluster/glusterfs/pull/3418 | 00:48 |
| ubottu | Pull 3418 in gluster/glusterfs "xlator_t: remove inconsistent alignment attribute" [Open] | 00:48 |
| ahasenack | scroll down | 00:48 |
| ahasenack | in the tree, there is run-tests-in-vagrant.sh | 00:49 |
| ahasenack | but fedora | 00:49 |
| ahasenack | I didn't get ./run-tests.sh to run in ubuntu | 00:50 |
| ahasenack | they seem to have their own jenkins, exclusive: https://build.gluster.org/job/gh_fedora-smoke/2629/ | 00:50 |
| ahasenack | the jobs: https://github.com/gluster/build-jobs/ | 00:51 |
| sbeattie | ah, yeah, looking at the jenkins job output, they are building and running run-tests.sh | 00:57 |
| ahasenack | so it's doable, but maybe only on rh | 01:00 |
| ahasenack | we could try to make it run in ubuntu | 01:00 |
| ahasenack | ubuntu/debian | 01:00 |
| ahasenack | but run it where | 01:00 |
| ahasenack | we don't have a jenkins | 01:01 |
| sbeattie | oh weird, they have a shellcheck jenkins job, but shellcheck found lots of stuff. | 01:01 |
| ahasenack | our qa-regression-testing? "clone this and run this in a vm" | 01:01 |
| * bittin listening to this weeks show now and updated my Ubuntu box | 07:13 | |
| === cpaelzer_ is now known as cpaelzer | ||
| === chrisccoulson_ is now known as chrisccoulson | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!