[00:10] ahasenack: is there a reason there isn't symbol version tracking on the library symbols? [00:10] let me check [00:11] sbeattie: not that I'm aware of [00:11] no reason [00:11] ahasenack: also please please please don't make the fusermount-copy setuid [00:11] never [00:11] it currently isn't, and I won't, and debian also won't (they got in touch with me) [00:12] I'll check the symbols tracking story [00:12] figuring out how get more tests running during build/adt would be great but won't be a blocker. [00:42] sbeattie: they have a unit test infra in place, but zero tests for it [00:43] I asked, and the tl;dr seems to be once they finally got the infra in place, they moved to github tests that were being developed in parallel, and rely on those now only [00:43] I can even enable unit tests during build, but it will say "0 tests run" in a nice little report [00:43] lovely [00:44] for adt, I added that test to create and mount a volume [00:44] it's a bit limited what I can do with just localhost [00:44] ideally it would be 3 vms (it's how I test locally) [00:44] yeah, it's a great smoke test, but not exactly comprehensive. [00:44] 4 actually, one is a client [00:45] are the github tests gettable in some way? [00:46] let me check [00:48] sbeattie: grabbed a PR at random: https://github.com/gluster/glusterfs/pull/3418 [00:48] Pull 3418 in gluster/glusterfs "xlator_t: remove inconsistent alignment attribute" [Open] [00:48] scroll down [00:49] in the tree, there is run-tests-in-vagrant.sh [00:49] but fedora [00:50] I didn't get ./run-tests.sh to run in ubuntu [00:50] they seem to have their own jenkins, exclusive: https://build.gluster.org/job/gh_fedora-smoke/2629/ [00:51] the jobs: https://github.com/gluster/build-jobs/ [00:57] ah, yeah, looking at the jenkins job output, they are building and running run-tests.sh [01:00] so it's doable, but maybe only on rh [01:00] we could try to make it run in ubuntu [01:00] ubuntu/debian [01:00] but run it where [01:01] we don't have a jenkins [01:01] oh weird, they have a shellcheck jenkins job, but shellcheck found lots of stuff. [01:01] our qa-regression-testing? "clone this and run this in a vm" [07:13] * bittin listening to this weeks show now and updated my Ubuntu box === cpaelzer_ is now known as cpaelzer === chrisccoulson_ is now known as chrisccoulson