| cjp256 | Anyone ever see a `__init__() got an unexpected keyword argument 'strict' ` during a readurl() call for 18.04 image with cloud-init v. 22.1-14-g2e17a0d6-0ubuntu1~18.04.3? Not many objects that have a strict parameter in that path. IPv4Network, JSONDecoder, and some urllib3 objects. urllib3 drops a strict parameter in v2, but that hasn't been released yet. | 14:41 |
|---|---|---|
| blackboxsw | cjp256: haven't seen that error to date. So this is requests calling HTTPConnectionPool with a strict param under the hood from our url_helper.readurl() call then right and the requests.Session.request passing a strict param to urllib3 which is no longer supported in v2? From the looks of docstrings in connectionpool.py was strict param has silently been ignored since py3.... | 15:37 |
| blackboxsw | Does this seems like dependency version mismatch? As in requests version needs to update to support urllib3 v2? | 15:37 |
| cjp256 | it's my best guess as I can't repro, though I'm not sure why anyone would install urllib3 v2 yet :D i've asked for more info | 15:40 |
| blackboxsw | well from https://urllib3.readthedocs.io/en/latest/v2-roadmap.html ...... "We’re maintaining 99% functional API compatibility to make the migration an easy choice for most users. Migration from v1.x to v2.x should be the simplest major version upgrade you’ve ever completed." :) | 15:44 |
| blackboxsw | so.... why not? :) the website said easy | 15:44 |
| blackboxsw | hiya aciba90 welcome. sorry it's been a busy release week for Ubuntu 22.04 Jammy. we are a bit behind on the PR review queue. | 15:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!