| OvenWerks | Headphone switching makes some assumptions that will only work in some cases (hopefully most cases) | 15:44 |
|---|---|---|
| Eickmeyer | OvenWerks: yeah, you'll notice there's a ton of crashes regarding that in the error tracker. | 16:43 |
| OvenWerks | Eickmeyer: I still get: sorry your not a memeber of that group | 16:59 |
| Eickmeyer | Lame. | 17:00 |
| Eickmeyer | Probably takes some time for the application to get through. | 17:00 |
| OvenWerks | the most common one may not be fixable | 17:00 |
| OvenWerks | The phones check one I need more info on. | 17:03 |
| OvenWerks | I think some of these might be fixed with a try/except at the right place. Sometimes things just fail | 17:03 |
| OvenWerks | Eickmeyer: all of the convert-studio-controls ones are gone with next release. | 17:05 |
| Eickmeyer | Oh, cool! | 17:05 |
| OvenWerks | (as is that file) | 17:05 |
| Eickmeyer | I'll find info on the phones issue. | 17:05 |
| OvenWerks | of course other errors might replace them :P | 17:06 |
| OvenWerks | the phones_check seems to show up in that list more than once | 17:08 |
| Eickmeyer[m] | OvenWerks: It shows up a total of 17 times:... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/83910bec8b1771ac3083cd08d23a63d087e2f0fd) | 17:11 |
| Eickmeyer[m] | OvenWerks: Then this one shows up a total of 37 times:... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/6259d564c4f6ef9d9ca6585d40cfca9756c4aab5) | 17:12 |
| Eickmeyer | Similar errors, both in the same spot. | 17:12 |
| OvenWerks | the second one looks like an easy fix, the first less so but I think I understand it. | 17:22 |
| OvenWerks | now I have to figure out which lines those are now... | 17:22 |
| OvenWerks | Eickmeyer: ok, I think I have fixed those two for next release. | 17:38 |
| Eickmeyer | OvenWerks: Awesome. | 17:38 |
| OvenWerks | They are both related to someone having an invalid headphone device | 17:39 |
| OvenWerks | So check that the device is *,*,* and then make sure the device is in the database | 17:40 |
| OvenWerks | Eickmeyer: can you get me the traceback on the one called autojack (NameError) check_jack_status? | 17:42 |
| Eickmeyer | Sure, I'll see if I can find it. | 17:43 |
| Eickmeyer | These are from the error logs. | 17:43 |
| Eickmeyer | (not mine) | 17:43 |
| Eickmeyer[m] | Traceback (most recent call last): | 17:44 |
| Eickmeyer[m] | File "/usr/bin/autojack", line 611, in check_jack_status | 17:44 |
| Eickmeyer[m] | jack_client.deactivate() | 17:44 |
| Eickmeyer[m] | NameError: name 'jack_client' is not defined | 17:44 |
| Eickmeyer | Heh, it just multiline-pasted that time. XD | 17:44 |
| OvenWerks | Huh, there is no line jack_client.deactivate() in check_jack_status and that is not anything I have changed. Are there lines missing in that paste? | 17:51 |
| OvenWerks | Eickmeyer: also the line number does not make sense even with the installed version in /usr/bin/ | 17:55 |
| Eickmeyer | OvenWerks: The only line number it gives is 611. It doesn't give me anything else. | 17:56 |
| Eickmeyer | That's the whole traceback. | 17:56 |
| OvenWerks | Does the rest of the record give the version of studio-controls installed? | 17:57 |
| Eickmeyer | It's occurring in every version from 1.12.6 to 2.3.1, with 2.3.1-0ubuntu1 having the most occurances at 164. | 17:59 |
| Eickmeyer | Sorry, 2.2.8 in the backports repo at 1279. | 17:59 |
| Eickmeyer | So, it's a huge error that must happen all the time and not get reported. | 18:00 |
| OvenWerks | The only problem is that line 611 is not in check_jack_status, does not call check_jack_status and does not do jack_client.deactivate. | 18:01 |
| OvenWerks | nor is this true for any of the lines somewhat close | 18:02 |
| OvenWerks | also jack_client.deactivate is not anywhere in check_jack_status | 18:02 |
| OvenWerks | line 911-112: | 18:04 |
| OvenWerks | if jack_client: | 18:04 |
| OvenWerks | jack_client.deactivate() | 18:04 |
| OvenWerks | However, that does check for jack_client... it should maybe be if jack_client in <whatever it is>: | 18:06 |
| OvenWerks | if 'myVar' in globals(): is the right way | 18:07 |
| OvenWerks | considering 912 is the only place in the whole file with deactivate, I will assume that is it and change the if as above. | 18:10 |
| OvenWerks | Eickmeyer: autojack is built to be robust, almost everything it does it started by a dbus call. This means that autojack itself does not quit because of an error and a second dbus call may correct things. :) so I do not know if these are things that are recorded but autojack hasn't actually died or froze. | 18:17 |
| Eickmeyer | Ah, that makes sense. | 18:17 |
| OvenWerks | However, I do think that traceback was corrupt | 18:18 |
| Eickmeyer | That's very possible, I looked at some of the individual tracebacks and they didn't match what the global traceback was. | 18:19 |
| OvenWerks | Eickmeyer: the third one down is another phones check one, Is that one of the ones you sent? | 18:20 |
| OvenWerks | Ah, import config actually | 18:20 |
| Eickmeyer | Yep. | 18:21 |
| OvenWerks | do these trackers ever get reset/removed or whatever? Or just fade? | 18:23 |
| OvenWerks | I guess it will be reset when there is a 22.10 page | 18:23 |
| OvenWerks | Eickmeyer: there are three studio-controls type error that look to be the same problem (11, 15 and 16) | 18:26 |
| OvenWerks | Anyway, I will be gone for a while, back in 3 or 4 hours | 18:28 |
| OvenWerks | (well I may be around here but bussy with other things) | 18:28 |
| Eickmeyer | ok | 18:46 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!