| mup | PR snapd#11769 opened: tests: run failed tests by default <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/11769> | 01:16 |
|---|---|---|
| mborzecki | morning | 06:03 |
| mardy | hi mborzecki! | 06:08 |
| mup | PR snapd#11770 opened: wrappers: write journald config files for quota groups with journal quotas (3/n) <Created by Meulengracht> <https://github.com/snapcore/snapd/pull/11770> | 06:22 |
| mup | PR snapd#11758 closed: osutil/disks: helper for obtaining the UUID of a partition which is a mount point source <Run nested> <factory reset 🔌> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/11758> | 06:53 |
| mborzecki | mardy: hmm i think there may be a race with nfs homes in snapd, please take a look at the forum if what i wrote there makes sense | 07:01 |
| pstolowski | mornig | 07:06 |
| pstolowski | *morning! | 07:06 |
| jamesh | mvo: hi, I was wondering if I could get https://github.com/snapcore/snapd/pull/11760 merged? It has a review approval from mardy, and amurray also reviewed it (but just left it as a comment rather than adding a tick). | 08:55 |
| mup | PR #11760: cmd/snap-seccomp: only compare the bottom 32-bits of the flags arg of copy_file_range <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/11760> | 08:55 |
| mvo | jamesh: sure, will do | 09:30 |
| mup | PR snapd#11760 closed: cmd/snap-seccomp: only compare the bottom 32-bits of the flags arg of copy_file_range <Created by jhenstridge> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11760> | 09:33 |
| jamesh | mvo: it looks like we might be able to get libseccomp improved to allow a better fix in future. | 09:58 |
| jamesh | mvo: also, it seems this is basically the same basic issue as https://ubuntu.com/security/notices/USN-3917-1 (although not a security hole this time) | 09:59 |
| mup | PR snapd#11771 opened: tests: spread test for uc20 preseeding covering snap prepare-image <Preseeding 🍞> <Created by stolowski> <https://github.com/snapcore/snapd/pull/11771> | 11:09 |
| mardy | zyga[m]: hi! Do you happen to remember whether in https://github.com/snapcore/snapd/commit/bc9c346c15aa8815fa339e94585f889d23c6182b not adding the same autofs detection in /etc/fstab was a deliberate decision? | 11:21 |
| mardy | (a few lines below (not visible in the diff) there's a similar check for /etc/fstab, and that lacks the autofs type check) | 11:22 |
| zyga[m] | hey | 11:22 |
| zyga[m] | yes, it was | 11:22 |
| mardy | oh, I was just about to add it :-) Do you remember what was the reason? | 11:23 |
| zyga[m] | at the time I was told by autofs users that their systems had dynamic autofs mouts that are not described by fstab | 11:23 |
| zyga[m] | since snapd uses both sources (satatic fstab and dynamic mountinfo), this seemed sufficient | 11:23 |
| zyga[m] | note that I've learned since, that there are a lot of extra cases we didn't expect | 11:24 |
| zyga[m] | still, the logic at the time was sound IMO | 11:24 |
| mardy | ah, ok, but you don't foresee problems if we add the same to the fstab, do you? | 11:24 |
| mardy | for context: https://forum.snapcraft.io/t/cannot-open-path-of-the-current-working-directory-permission-denied-bis/28704/31 | 11:24 |
| zyga[m] | no | 11:24 |
| zyga[m] | it should be okay | 11:24 |
| mardy | excellent, thans | 11:24 |
| mardy | *thanks | 11:24 |
| zyga[m] | mardy: how is autofs expressed in /etc/fstab? | 11:25 |
| mardy | mmm... no idea, honestly; isn't it just another fs type like the others? | 11:26 |
| zyga[m] | no | 11:26 |
| zyga[m] | that's the point | 11:26 |
| zyga[m] | read the thread you've linked to | 11:26 |
| zyga[m] | it's specified in a different place | 11:26 |
| zyga[m] | and there's a whole range of config files to read | 11:26 |
| zyga[m] | I think it's a bit unfortunate that this is something we must support by reading random files :/ | 11:27 |
| mardy | ah, so it skips /etc/fstab, I see | 11:27 |
| zyga[m] | unless you have someone who can work with you on their specific autofs setup, I would apply caution :/ | 11:27 |
| mardy | I see, I was assuming that one would specify "autofs" in the /etc/fstab, and then had the whole configuration in the /etc/auto.master file, but now I understand that the fstab is skipped altogether | 11:31 |
| mup | PR snapd#11765 closed: deps: bump libseccomp to include build fixes, run unit tests using CC=clang <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/11765> | 11:34 |
| mup | PR snapd#11764 closed: secboot/keymgr: remove recovery key, authorize with existing key <Simple 😃> <factory reset 🔌> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11764> | 12:14 |
| mup | PR snapd#11727 closed: o/snapshotstate: check installed snaps before running 'save' tasks <Simple 😃> <Run failed> <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11727> | 12:29 |
| mup | PR snapd#11769 closed: tests: run failed tests by default <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/11769> | 12:54 |
| mvo | jamesh: aha, thanks! | 13:56 |
| mup | PR snapcraft#3739 opened: legacy: plugins: convert paths to strings for commands <Created by mr-cal> <https://github.com/snapcore/snapcraft/pull/3739> | 15:23 |
| mup | PR snapd#11763 closed: snapstate: do not auto-migrate to ~/Snap for core22 just yet <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11763> | 18:21 |
| mup | PR snapd#11772 opened: snapstate: do not auto-migrate to ~/Snap for core22 just yet (2.55) <Created by mvo5> <https://github.com/snapcore/snapd/pull/11772> | 19:01 |
| mup | PR snapd#10928 closed: tests: new nested test to validate current snapd with stable kernel <Run nested> <Created by sergiocazzolato> <Closed by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10928> | 21:12 |
| mup | PR snapcraft#3694 closed: autotools v1 plugin: fix fatal crash when running autogen.sh or bootstrap <Created by mtmiller> <Closed by mtmiller> <https://github.com/snapcore/snapcraft/pull/3694> | 23:23 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!