[06:33] <mardy> amurray: hi! How does snap-review get the list of valid interfaces? I'm looking at the code, but I cannot find a list there
[06:34] <amurray> mardy: it has a copy of the snapd base declaration - https://git.launchpad.net/review-tools/tree/reviewtools/data/snapd-base-declaration.yaml
[06:35] <amurray> (this is almost the same as the output of snap debug base-declaration just reformatted slightly)
[06:53] <mardy> amurray: oh, nice, thanks!
[06:53] <mardy> amurray: I'm trying to add a "deprecated interfaces" feature
[06:55] <pstolowski> morning
[06:56] <mardy> pstolowski: hi!
[06:59] <mardy> amurray: would SnapReviewDeclaration._installation_check() be the right place to add a "deprecated interface" check?
[07:05] <amurray> mardy: yes I think so - but perhaps we should add it to the base declaration in snapd directly (ie a deprecated attribute) and then have review-tools raise an error when it sees this attribute
[07:06] <amurray> it would be worth discussion with pedronis I think - since if we do it in the base declaration then snapd can raise a warning too perhaps? (although I guess it is probably not so useful to users to always see a warning when they can't do anything about it...)
[07:06] <mup> PR snapd#11808 opened: Add ttyGS to serial port allow list <Created by tsunghanliu> <https://github.com/snapcore/snapd/pull/11808>
[08:32] <mup> PR snapd#11685 closed: interfaces/builtin: remove obsolete interfaces <Needs Samuele review> <Created by mardy> <Closed by mardy> <https://github.com/snapcore/snapd/pull/11685>
[08:37] <mup> PR snapd#11807 closed: snapcraft.yaml: bump stable branch to release/2.56 <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11807>
[08:42] <mup> PR snapd#8079 closed: overlord/snapstate, wrappers: manpages! <⛔ Blocked> <Needs Samuele review> <:birthday:> <Precious but later :heart:> <Created by chipaca> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/8079>
[08:47] <mup> PR snapd#9384 closed: overlord: export and use snapd tools <:birthday:> <Precious but later :heart:> <Created by zyga> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9384>
[08:47] <mup> PR snapd#11801 closed: testutil: add ErrorIs test checker <⛔ Blocked> <Created by MiguelPires> <Merged by MiguelPires> <https://github.com/snapcore/snapd/pull/11801>
[08:57] <mup> PR snapd#7205 closed: rfc: introduce confinement options failsafe flag <Needs Samuele review> <:birthday:> <Precious but later :heart:> <Created by zyga> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7205>
[08:57] <mup> PR snapd#9546 closed: overlord: add inert export manager <:birthday:> <Precious but later :heart:> <Created by zyga> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9546>
[08:57] <mup> PR snapd#9992 closed: snapstate: error is "snap refresh" has no updates because of conflicts <⛔ Blocked> <Precious but later :heart:> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9992>
[09:01] <zyga[m]> some spring cleaning, I see
[09:02] <mup> PR snapd#7436 closed: many: make per-snap mount namespace MS_SHARED <Bug> <:birthday:> <Precious but later :heart:> <Created by zyga> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7436>
[09:07] <mup> PR snapd#7603 closed: interfaces: add dpdk interface <⛔ Blocked> <Complex> <:birthday:> <Needs security review> <Precious but later :heart:> <Created by alfonsosanchezbeato> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/7603>
[09:12] <mup> PR snapd#11809 opened: many: replace ErrNoState equality checks w/ errors.Is() <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/11809>
[09:42] <mup> PR snapd#11766 closed: wrappers: refactor EnsureSnapServices <Run nested> <Created by Meulengracht> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11766>
[09:52] <mup> PR snapd#11702 closed: tests: add spread test to test upgrade from release snapd to current <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11702>
[10:02] <mup> PR snapd#11804 closed: interfaces/modem-manager: Don't generate DBus plug policy <Created by alexmurray> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11804>
[11:04] <mardy> zyga[m]: it's the crusade against open PRs ;-)
[11:05] <mardy> diddledani: sorry for the chown() ping-pong, thanks for updating your PR :-)
[11:07] <diddledani> No worries 🙂
[11:37] <diddledani> bad copy+pasta on my part. I neglected to ensure dst vs dst_dir naming fixup - seems nvidia uses dst and I used dst_dir in wsl2-gpu
[11:37] <diddledani> force pushed the last commit with the fix
[11:38] <mup> PR snapd#11808 closed: interfaces/serial-port: add ttyGS to serial port allow list <Created by tsunghanliu> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11808>
[14:23] <mup> PR snapd#11802 closed: .github: Trigger daily riscv64 snapd edge builds <Skip spread> <Created by xnox> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11802>
[15:34] <mup> PR snapd#11340 closed: systemd: fix snapd systemd-unit stop progress notifications <Squash-merge> <Needs Samuele review> <Created by flotter> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/11340>
[15:59] <mup> PR snapd#11810 opened: tests: set `br54.dhcp4=false` in the netplan-cfg test <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/11810>
[16:09] <mup> PR snapd#11726 closed: cmd/snap: exit w/ non-zero code on missing snap <Simple 😃> <Needs Samuele review> <Created by MiguelPires> <Merged by MiguelPires> <https://github.com/snapcore/snapd/pull/11726>
[18:42] <mup> PR snapcraft#3746 opened: project: support system-usernames <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3746>
[19:22] <mup> PR snapcraft#3747 opened: cli: disable new pylint false positive <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3747>
[20:27] <mup> PR snapcraft#3746 closed: project: support system-usernames <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3746>
[20:27] <mup> PR snapcraft#3747 closed: cli: disable new pylint false positive <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3747>
[20:40] <mup> PR snapd#11811 opened: tests: allow to re-execute aborted tests  <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/11811>
[21:17] <mup> PR snapcraft#3748 opened: parts: define variables and expand them in snapcraft.yaml <Created by cmatsuoka> <https://github.com/snapcore/snapcraft/pull/3748>
[21:32] <mup> PR snapcraft#3749 opened: slots: allow lists <Created by mr-cal> <https://github.com/snapcore/snapcraft/pull/3749>
[21:52] <mup> PR snapcraft#3750 opened: Add core22 colcon plugin / ros2-humble extension <Created by artivis> <https://github.com/snapcore/snapcraft/pull/3750>
[23:12] <mup> PR snapcraft#3748 closed: parts: define variables and expand them in snapcraft.yaml <Created by cmatsuoka> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3748>