| mup | PR snapcraft#3763 closed: pack: check if output directory is current working directory <Created by mr-cal> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3763> | 00:16 |
|---|---|---|
| mborzecki | morning | 06:06 |
| mardy | hi mborzecki | 06:10 |
| mborzecki | hey | 06:12 |
| mborzecki | mardy: need reviews? | 06:14 |
| mardy | mborzecki: there's one in UC, maybe also abeato can have a look :-) https://github.com/snapcore/core/pull/132 | 06:44 |
| mup | PR core#132: extra-files: add udev rule for snap auto-import <Created by mardy> <https://github.com/snapcore/core/pull/132> | 06:44 |
| mardy | mborzecki: then if you can have another look at https://github.com/snapcore/snapd/pull/11681 | 06:46 |
| mup | PR #11681: interfaces/builtin: add README file <Needs Samuele review> <Skip spread> <Created by mardy> <https://github.com/snapcore/snapd/pull/11681> | 06:46 |
| mardy | mborzecki: well, I actually have a few PRs that need review, but most of them also require security's or Samuele's review, so they are not urgent. But if you have the bandwith: https://github.com/snapcore/snapd/pull/11803 | 06:51 |
| mup | PR #11803: cmd/snap-confine: remove setuid calls from cgroup init code <Needs security review> <Created by mardy> <https://github.com/snapcore/snapd/pull/11803> | 06:51 |
| pstolowski | morning | 07:12 |
| abeato | mardy, just took a look, thanks! | 07:12 |
| mborzecki | heh, is github down? | 07:34 |
| pstolowski | mborzecki: oh, indeed | 07:36 |
| mborzecki | or at least very slow | 07:39 |
| mborzecki | mardy: about https://github.com/snapcore/core/pull/132 there was a PR from valentin which added a systemd service template for core22 iirc? should we have the same template sevice for core/core20? | 07:40 |
| mup | PR core#132: extra-files: add udev rule for snap auto-import <Created by mardy> <https://github.com/snapcore/core/pull/132> | 07:40 |
| mup | PR snapd#11681 closed: interfaces/builtin: add README file <Needs Samuele review> <Skip spread> <Created by mardy> <Merged by mardy> <https://github.com/snapcore/snapd/pull/11681> | 08:21 |
| mardy | mborzecki: AFAIK, core20 works fine already | 09:21 |
| mborzecki | mardy: waht i meant is that maybe we could have similar way of handling this on all cores | 09:21 |
| mborzecki | mardy: as now we'll have the systemd template thingy on core22, but then the old udev rule on other cores (also i'm not even sure we could do it the new way on core16 tbh) | 09:22 |
| mborzecki | mardy: anyways, not really a critical problem, just something to think about | 09:24 |
| mborzecki | mardy: another upside is that the logs that we could not have collected now as udev runs the scripts with closed stdout/stderr would be available if auto-import runs under a service 🙂 | 09:24 |
| mardy | mborzecki: yes, that is something I noticed as well, that our logs are nowhere to be found :-( | 09:25 |
| mardy | mborzecki: SYSTEMD_WANTS has been there since at least 2014, so in principle we could do this in all core snaps. OTOH, this requires testing on each of the releases, and I'm not sure it's worth it. | 09:32 |
| mup | PR snapd#11826 opened: o/snapstate: fix validation sets restoring and snap revert on failed refresh <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/11826> | 09:51 |
| mardy | do we have any example of snapctl commands that handle subcommands? like "snapctl kmod load" and "snapctl kmod unload" | 10:26 |
| mborzecki | mardy: not that i'm aware of | 10:45 |
| mup | PR snapcraft#3765 opened: Fix gtk3 test <Created by sergio-costas> <https://github.com/snapcore/snapcraft/pull/3765> | 11:27 |
| mup | PR snapcraft#3766 opened: extensions: prepend and append functions for ENV <Created by sergio-costas> <https://github.com/snapcore/snapcraft/pull/3766> | 16:42 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!