[01:33] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww opened [pull request #2458](https://github.com/MirServer/mir/pull/2458): Wayland platform threadsafe swap_buffers() [01:33] -GitHub[m]:#mir-server- [01:33] -GitHub[m]:#mir-server- > Fixes #2450 by making `DisplayClient` an executor and running the frame request on it [02:06] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww opened [pull request #2459](https://github.com/MirServer/mir/pull/2459): Wayland platform: do not delete outputs until display configure [02:06] -GitHub[m]:#mir-server- [02:06] -GitHub[m]:#mir-server- > Mitigates #2457. Just a small change that doesn't refactor the architecture, but should prevent the obvious use-after-free. [03:02] -GitHub[m]:#mir-server- **[MirServer/mir]** RAOF opened [pull request #2460](https://github.com/MirServer/mir/pull/2460): platform: Document Display::configure harder.... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/4fc36f938dd1e65a6c8327fbd93c1be6ba802118) [07:09] Bah! Where did my new code go? [07:52] Stashed? Local history? [08:32] Good morn' o/ [08:36] Hello there!! [09:03] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2448](https://github.com/MirServer/mir/pull/2448): Wayland platform size from configure [09:03] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] closed [issue #2447](https://github.com/MirServer/mir/issues/2447): Mir-on-Wayland doesn't support fractional scaling [09:03] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] edited [pull request #2459](https://github.com/MirServer/mir/pull/2459): Wayland platform: do not delete outputs until display configure [09:03] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] edited [pull request #2458](https://github.com/MirServer/mir/pull/2458): Wayland platform threadsafe swap_buffers() [11:39] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths opened [pull request #2461](https://github.com/MirServer/mir/pull/2461): [Wayland platform] timeout safe swap_buffers()... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/a80582582c02b68e02d677f8554bb39b03bc8112) [11:41] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths requested a review from wmww for [pull request #2461](https://github.com/MirServer/mir/pull/2461): [Wayland platform] timeout safe swap_buffers() [11:59] > I think there might also be an existing trace of a touch stream in `test_data`? [11:59] ``` [11:59] $ find tests/mir_test_framework/udev-recordings/ -name *touch* [11:59] tests/mir_test_framework/udev-recordings/synaptics-touchpad.umockdev [11:59] tests/mir_test_framework/udev-recordings/synaptics-touchpad.ioctl [11:59] ``` [13:36] Saviq sounds like to understand https://github.com/MirServer/mir/pull/2451, are you going to review it? [13:37] ACK, will do [13:48] Argh! I have too many chat apps around. I heard a notification ping, but can't find a notification. [14:03] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2460](https://github.com/MirServer/mir/pull/2460): platform: Document Display::configure harder. [16:26] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths closed [pull request #2461](https://github.com/MirServer/mir/pull/2461): [Wayland platform] timeout safe swap_buffers() [16:49] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2459](https://github.com/MirServer/mir/pull/2459): Wayland platform: do not delete outputs until display configure [17:01] Regarding the bogus touches filtered out in the Flohack branch (this is irrelevant to what I'm working on, but it made me think) is (0,0) *really* an invalid state? Because this code is filtering out all inputs at (0, 0). I understand that some device is falsely sending out the (0, 0), but should we be filtering out *ever* (0, 0)? What if someone is to write a test of some sort where they want to test that a press to (0, 0) works. Or [17:01] what if someone is calibrating a touch display and they actually hit (0, 0)? Should this be filtered out? Or should the coordinates in practice start at (1, 1)? [17:01] Or, also likely, am I just overthinking this? [17:03] * grayson-g[m] sent a code block: https://libera.ems.host/_matrix/media/r0/download/libera.chat/b327e3cece42d9eb143656d9e8400ba3a13c812d [17:03] > is (0,0) *really* an invalid state? [17:04] > is (0,0) *really* an invalid state? [17:04] Not really. IIRC the intent was if all touches are at the same (0, 0) then the whole frame is bad [17:05] > <@alan_g:matrix.org> > is (0,0) *really* an invalid state? [17:05] > [17:05] > Not really. IIRC the intent was if all touches are at the same (0, 0) then the whole frame is bad [17:05] Ah yes, this will allow one touch to (0, 0). [17:05] It does seem implausible that several touches are identified at the same point [17:26] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2458](https://github.com/MirServer/mir/pull/2458): Wayland platform threadsafe swap_buffers() [17:26] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] closed [issue #2450](https://github.com/MirServer/mir/issues/2450): Mir-on-Wayland platform deadlocks due to thread unsafety [18:33] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww closed [issue #2434](https://github.com/MirServer/mir/issues/2434): Failing to run Wayland platform on hosts that don't support wl-shell