| amurray | zyga[m]: hmm from a quick look I think it should be safe to allow kcmp in the default template - docker allows it in their base template https://github.com/moby/moby/blob/0ec744f43b52dd0b3065b84e685b89a2ede1dd8e/profiles/seccomp/default.json#L716 so I think we probably should too | 00:36 |
|---|---|---|
| mborzecki | morning | 05:55 |
| mup | PR snapd#11861 opened: interfaces/system-packages-doc: allow read-only access to /usr/share/cups/doc-root/ and /usr/share/gimp/2.0/help/ (https://bugzilla.mozilla.org/show_bug.cgi?id=1770462) <Created by lissyx> <https://github.com/snapcore/snapd/pull/11861> | 06:50 |
| mardy | zyga[m]: Hi! If I can dig a bit into your memory :-) Are you aware of any circumstance, under which a layout would end up being done twice? That is, on the desired mount point the same source is being bind-mounted twice (it's a file) | 06:53 |
| mardy | mborzecki: hi, I thought you were off today? | 06:56 |
| mborzecki | mardy: hey, yeah though so too, but apparently can't even use the calendar properly 🙂 | 06:56 |
| lissyx | mardy, I just sent a PR for fixing https://bugzilla.mozilla.org/show_bug.cgi?id=1770462 | 06:57 |
| lissyx | mardy, osomon suggested me to do so, at least to open discussion on the matter, even if we both agree on the long term it might be a can of worm :/ | 06:59 |
| mardy | lissyx: nice, thanks! | 07:04 |
| lissyx | (I have not yet signed the CLA because I'm unsure how to sign) | 07:04 |
| * mardy wonders if snapd is smart enough not to panic if the requested mount source is not found (that is, if gimp is not installed) | 07:05 | |
| mardy | lissyx: did you fill this? https://ubuntu.com/legal/contributors/agreement | 07:05 |
| lissyx | mardy, not this "how to" | 07:06 |
| zyga[m] | I will be around in 30 min mardy: | 07:06 |
| lissyx | mardy, rather "maybe mozilla is already signed? (I would expect so)" and "is it fine if I sign as an individual even if it's part of my work" | 07:06 |
| lissyx | legalities ... | 07:06 |
| mardy | lissyx: uh, I'm not sure how it works if you are part of an organization | 07:10 |
| lissyx | exactly | 07:10 |
| lissyx | and I need to wait for some colleagues to wake up, we're looking at US west coast so later today :) | 07:11 |
| zyga[m] | mardy: nothing rings a bell, I was initially thinking it could be some weird propagation but cannot think of a scenario when this would happen | 07:12 |
| lissyx | mardy, ok it's signed but I have tests failures and I'm unable to understand them | 07:27 |
| lissyx | oh little tests/main/interfaces-system-packages-doc/task.yaml | 07:30 |
| lissyx | mardy, looks like I need you to re-review to run the updated PR https://github.com/snapcore/snapd/pull/11861 | 08:06 |
| mup | PR #11861: interfaces/system-packages-doc: allow read-only access to /usr/share/cups/doc-root/ and /usr/share/gimp/2.0/help/ (https://bugzilla.mozilla.org/show_bug.cgi?id=1770462) <Created by lissyx> <https://github.com/snapcore/snapd/pull/11861> | 08:06 |
| lissyx | mardy, it should address the comment as well as fix the tests, I hope | 08:06 |
| mborzecki | mardy: lissyx: AFAIU there's no additional CLA check needed for accounts @mozilla.org as we have an organization level CLA or whatnot | 08:37 |
| lissyx | mborzecki, not sure what you mean | 08:39 |
| mborzecki | lissyx: i thought you've signed the commit with some @mozilla.org account, if not then please ignore 😉 | 08:40 |
| lissyx | define @mozilla.org ? | 08:40 |
| lissyx | are you referring to the github org? or email address? | 08:40 |
| mborzecki | lissyx: email address | 08:42 |
| lissyx | I used a mozilla.com | 08:43 |
| mborzecki | lissyx: fwiw the PR looks good to me, thank you for filing it, I've approved the CI run | 08:43 |
| lissyx | cla-check somehow failed? | 08:43 |
| lissyx | oh boy | 08:43 |
| mborzecki | lissyx: pretty sure https://github.com/snapcore/snapd/commit/1164e6f2b502b6203733d1bada6638854b516039.patch is using lissyx.dyndns.org | 08:43 |
| lissyx | tooling constantly assumes same email everywhere ... | 08:44 |
| lissyx | rewrote it | 08:44 |
| mborzecki | lissyx: you can --reset-author and force push 🙂 | 08:44 |
| lissyx | I just did | 08:45 |
| mborzecki | lissyx: it's @free.fr now 🙂 | 08:45 |
| lissyx | I guess you'll have to unblock CI once | 08:45 |
| lissyx | yeah that should be the primary email of my launchpad account | 08:45 |
| mborzecki | cool, so then the cla check should be green | 08:46 |
| lissyx | grmbl | 08:46 |
| lissyx | it considers I have not signeed it ... | 08:47 |
| lissyx | just take the PR and land it for me? | 08:47 |
| mborzecki | lissyx: fwiw it should be as simple as clicking through https://ubuntu.com/legal/contributors/agreement | 08:53 |
| lissyx | mborzecki, I already did all of that | 08:53 |
| lissyx | correct launchpadid and github account | 08:53 |
| mborzecki | lissyx: ok, let's wait a little bit, maybe there's some batch job that processes that, if not i'll ask mvo to take a look | 08:54 |
| lissyx | mborzecki, looks like we're good for another round of approving, there was an assert on length I forgot | 09:09 |
| mborzecki | lissyx: it's running now | 09:17 |
| lissyx | mborzecki, there's a failure and I'm unsure it is me: https://github.com/snapcore/snapd/runs/6828239687?check_suite_focus=true | 09:28 |
| mup | PR snapd#11814 closed: cmd/snap: cleanup and make the code a bit easier to read/maintain for quota options <Created by Meulengracht> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11814> | 09:35 |
| mup | PR snapd#11862 opened: tests: add nested test variant that adds 4k sector size <Run nested> <Created by mvo5> <https://github.com/snapcore/snapd/pull/11862> | 09:55 |
| mup | PR snapd#11863 opened: tests: enable nested tpm test for core22 <Run nested> <Created by mvo5> <https://github.com/snapcore/snapd/pull/11863> | 10:11 |
| mup | PR snapcraft#3786 closed: providers: update craft-providers <Created by mr-cal> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3786> | 10:19 |
| lissyx | so gio's g_file_get_path() return null when running under a snap | 12:10 |
| lissyx | even if the snap is installed in devmode | 12:10 |
| lissyx | and journalctl does not show anything | 12:11 |
| diddledani | lissyx: that CI testing fail you linked earlier is failing in the cmd/snap-repair directory - if you haven't touched that directory then you're fine (I don't think you would have to be fixing a firefox-related issue) | 12:22 |
| mup | PR snapd#11864 opened: many: add migrate-home debug command <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/11864> | 12:56 |
| mup | PR snapd#11859 closed: secboot/keymgr, cmd/snap-fde-keymgr: two step encryption key change <factory reset 🔌> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11859> | 13:01 |
| lissyx | diddledani, well I'll let you people verify and merge if it's okay | 13:14 |
| lissyx | or just ping me if I need to fix something ? | 13:14 |
| mup | PR snapd#11863 closed: tests: enable nested tpm test for core22 <Run nested> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/11863> | 13:26 |
| mup | PR snapd#11865 opened: secboot: stage and transition encryption keys <Simple 😃> <factory reset 🔌> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/11865> | 13:26 |
| mup | PR snapd#11866 opened: data: start snapd after time-set.target <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/11866> | 14:41 |
| mup | PR snapd#11867 opened: squashfs: improve error reporting when `unsquashfs` fails <Created by mvo5> <https://github.com/snapcore/snapd/pull/11867> | 14:52 |
| mup | PR snapd#11813 closed: overlord/ifacestate: add journal bind-mount snap layout when snap is in a journal quota group (4/n) <Created by Meulengracht> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/11813> | 14:57 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!