[05:38] good morning desktoppers [05:39] Hi oSoMoN [05:39] hey duflu [05:49] good morning [05:51] Morning didrocks [05:51] happy Friday duflu [05:56] salut didrocks [06:00] salut oSoMoN [06:49] oSoMoN, https://github.com/snapcore/snapd/pull/11861 [06:49] Pull 11861 in snapcore/snapd "interfaces/system-packages-doc: allow read-only access to /usr/share/cups/doc-root/ and /usr/share/gimp/2.0/help/ (https://bugzilla.mozilla.org/show_bug.cgi?id=1770462)" [Open] [06:49] but CLA mess :( [07:02] goood morning desktopers [07:06] Hi seb128. How are you now? [07:07] duflu, hey, a bit better though my stomach is still isn't great. How are you? [07:10] I'm relatively good. You should rest if you need to [07:21] oSoMoN, FTR for a few weeks I'm suffering https://bugzilla.mozilla.org/show_bug.cgi?id=1773624 [07:21] Mozilla bug 1773624 in Core "Firefox Snap no longer able to save file on SMB share" [--, New] [07:21] is there a way with snap to see some sandbox logs? [07:33] lissyx, usually snapd confirmenent problems show in the journalctl log, at least apparmor denials [07:34] seb128, good catch I see some reports [07:34] seb128, do you know from https://bugzilla.mozilla.org/show_bug.cgi?id=1773624#c1 whether this is a bug on our side or the xdg portal one? [07:34] Mozilla bug 1773624 in Core "Firefox Snap no longer able to save file on SMB share" [--, New] [07:35] lissyx, but file save should use the portals, you can also try to /usr/libexec/xdg-desktop-portal-gnome -rv in case that has issues [07:35] from the log it looks like it's hitting the portal at least [07:37] lissyx, I don't sorry, if that's a recent regression I would guess firefox since the portal didnd't change [07:38] ok [07:38] xdg-desktop-portal-gnome -rv did nothing but xdg-desktop-portal -rv reveal the same as journalct [07:38] I'm wondering if we are passing a correct dbus message ... [07:39] what's the error you see in the log? [07:41] seb128, the one on the comment [07:41] assertions about file_name != NULL [07:41] except I can't find where we hit SaveFile in our codebase :) [07:57] oSoMoN, any opinion on https://bugzilla.mozilla.org/show_bug.cgi?id=1770682#c2 ? [07:57] Mozilla bug 1770682 in Core "Solokeys Solo v2 fido key not supported in linux snap builds" [--, Unconfirmed] [07:58] oSoMoN, I can file a bug against ubuntu in launchpad if needed [08:00] lissyx, that's an easy snapd change needed [08:00] lissyx, it looks like this was fixed already: https://github.com/snapcore/snapd/commit/9c94b67eb4fe64bd5fe26d8e1968f73f957d1cf0 [08:00] Commit 9c94b67 in snapcore/snapd "interfaces/u2f-devices: add Solo V2" [08:00] nice [08:01] probably not released in a stable snapd yet [08:01] I was going to say, it's marked as snap 2.56 [08:01] and latest stable is 2.55.x ? [08:01] yes [08:01] oh I have 2.56 [08:01] right, I didn't see the tag [08:01] updated two days ago? [08:02] ah, right [08:02] well then it should be fixed :) [08:02] lissyx, do you have the hardware to test? [08:02] no [08:05] tjaalton, hey. I would like to see https://github.com/intel/media-driver/commit/e25478c4 cherrypicked and SRUed to fix bug #1962630 , I confirmed that the fix works. Do you want to handle it or should I just cherry pick + SRU? [08:05] Bug 1962630 in intel-media-driver (Ubuntu Jammy) "Video playback crashes with SIGSEGV in KernelDll_AllocateStates (intel-media-driver)" [High, Triaged] https://launchpad.net/bugs/1962630 [08:05] Commit e25478c in intel/media-driver "Fix driver crash with no kernel binary" [08:22] hm no debugging package for xdg-desktop-portal [08:29] ok, xdg-desktop-portal-dbgsym is here with the specific apt repo [08:39] oSoMoN, if it works for you, do you mind r+ on phab? thanks :) [08:40] lissyx, yeah, I'll do that [08:40] lissyx, FYI, I'm working on backporting a fix to xdg-desktop-portal to Ubuntu 20.04 so that OpenDirectory highlights the downloaded file as expected, see bug #1978295 [08:40] Bug 1978295 in xdg-desktop-portal (Ubuntu Focal) "org.freedesktop.portal.OpenURI.OpenDirectory doesn't highlight the selected file" [Undecided, New] https://launchpad.net/bugs/1978295 [08:41] yeah I saw your comment [08:41] oSoMoN, do you happen to know of recent changes around snap that could lead to https://bugzilla.mozilla.org/show_bug.cgi?id=1773624 ? [08:41] Mozilla bug 1773624 in Core "Firefox Snap no longer able to save file on SMB share" [--, New] [08:41] i'm checking and what we send to the XDG portal makes sense [08:42] xdg-desktop-portal receives a smb:// URI and it seems to be rather on the side of gio that it fails? [08:44] you've already gone deeper into investigating the issue than I have [08:45] the g_file_new_for_uri is kinda opaque to me [08:54] oSoMoN, reminds me that we should probably sponsor the changes mardy suggested on https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1851250 to [08:54] Launchpad bug 1851250 in chromium-browser (Ubuntu Focal) "[snap] chromium-browser snap cannot upload files outside ~" [Undecided, Confirmed] [08:55] oSoMoN, unsure if that would also fix your issue [08:55] let me see [08:55] oSoMoN, #19 has the details [08:56] I just checked, it's a different set of commits [08:56] k [08:56] so two separate SRUs, probably [08:56] well if we do a SRU we should also include those I think [08:57] or do another round, as you prefer [08:57] I just had that for a while in my backlog so I mentioned it [08:57] yes, it's relevant. [08:57] oSoMoN, btw do you know what is blocking having debug symbols uploaded for snap package? [08:57] https://crash-stats.mozilla.org/signature/?product=Firefox&version=103.0a1&signature=libxul.so%400x369d8d3%20%7C%20libxul.so%400x369e33c%20%7C%20libxul.so%400x2d48ee9%20%7C%20libxul.so%400x2d48343%20%7C%20libxul.so%400x2d47c66%20%7C%20libxul.so%400x2d43b9e%20%7C%20libxul.so%400x2d438dd%20%7C%20libxul.so%400x2d4a1ce%20%7C%20libxul.so%400xcbf71c%20%7C%20libxul.so%400xccefd0%20%7C%20libxul.so%400xcc9d76%20%7C%2 [08:57] 0libxul.so%400xc...&date=%3E%3D2022-06-08T00%3A00%3A00.000Z&date=%3C2022-06-09T23%3A59%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_columns=release_channel&_columns=distribution_id&_sort=-date&page=1 [08:58] I also discussed it a bit with Ken, we agreed that we should probably try to roll new portal versions as SRUs since usually they had support of newer features in snaps/flatpak which aren't tired to the Ubuntu serie [08:58] seb128, the changes mardy is proposing are even more intrusive, so there's a a non-negligible regression risk [08:58] it's sort of 'enablement of newer versions to keep working on older Ubuntu series' [08:58] oSoMoN, right, at the same time if your portal don't support current versions of the apps you are screwed [08:59] that would solve both issues nicely, if it's acceptable for the SRU team [08:59] but one problem at the time [08:59] I think it's going to take some more time to get the SRU team to decide on allowing those, so maybe don't le me distract you from doing that selected fix [09:00] lissyx, that's https://bugzilla.mozilla.org/show_bug.cgi?id=1766901, I simply haven't had the time to work on it yet [09:00] Mozilla bug 1766901 in Toolkit "Scrape symbols from Ubuntu snap builds" [S1, New] [09:01] oSoMoN, do you have ideas to fix? [09:01] maybe I can help? [09:01] (also I can land the other fix as soon as you r+ it) [09:07] accepted [09:07] sorry for the delay [09:07] I'm multitasking too much for my taste [09:08] thankss [09:08] I can sense the feeling :) [09:08] last round of addressing emilio's comment and we're good [09:09] seb128: go for it :) [09:23] oSoMoN, the SMB access issue might be a snap-level one: https://bugzilla.mozilla.org/show_bug.cgi?id=1773624#c3 [09:23] Mozilla bug 1773624 in Core "Firefox Snap no longer able to save file on SMB share" [--, New] [09:25] oSoMoN, I'm not sure how snapd can impact there [09:29] tjaalton, in fact the fix was already uploaded to Debian and synced, I did the SRU for J now, maybe you want to review it from the queue? ;-) [09:30] tjaalton, I would appreciate if you could also review wpa/J , it fixes another openssl3 related issue which prevents users to connect to legacy stack APs [09:33] seb128: sure thing [09:43] thanks! [11:35] gnome-calculator Sebastien Bacher 312634 * commented merge request !8 * https://deb.li/34yNz [11:36] gnome-calculator tags abec9ed Sebastien Bacher upstream/42.1 * Upstream version 42.1 * https://deb.li/p3JU [11:37] gnome-calculator upstream/latest cb230c7 Sebastien Bacher * pushed 9 commits (first 5 follow) * https://deb.li/iiWSc [11:37] gnome-calculator upstream/latest 1f82a7b Rūdolfs Mazurs po/lv.po * Update Latvian translation * https://deb.li/1Wa7 [11:37] gnome-calculator upstream/latest 5b88d49 Nathan Follens po/nl.po * Update Dutch translation * https://deb.li/3V1Hd [11:37] gnome-calculator upstream/latest 2a50c55 Hugo Carvalho po/pt.po * Update Portuguese translation * https://deb.li/D1m2 [11:37] gnome-calculator upstream/latest 9f9e95b Fabio Tomat po/fur.po * Update Friulian translation * https://deb.li/3L3QC [11:37] gnome-calculator upstream/latest 4f0f435 Robert Roth lib/math-equation.vala * Fixed undo/redo broken (#266) * https://deb.li/Tyuh [11:37] gnome-calculator pristine-tar 544a0da Nathan Pratta Teodosio gnome-calculator_42.1.orig.tar.xz.delta gnome-calculator_42.1.orig.tar.xz.id * pristine-tar data for gnome-calculator_42.1.orig.tar.xz * https://deb.li/Q5Ux [11:40] seb128: the intel-media-driver sru is also a new upstream release? [11:40] tjaalton, oh crap, I overlooked that, let me fix [11:41] there's also -non-free [11:41] version of it [11:48] tjaalton, I reuploaded [11:48] tjaalton, the bug impacts only -DENABLE_NONFREE_KERNELS=OFF builds from what I understand [11:50] gnome-calculator signed tags 965129a Sebastien Bacher ubuntu/1%42.1-1ubuntu1 * gnome-calculator Debian release 1:42.1-1ubuntu1 * https://deb.li/3TPNI [12:21] tjaalton, thanks! [12:32] ah ok [13:39] hm osomon is not here :/ [13:39] I'm wondering where is snap/command-chain/desktop-launch coming from on firefox snap [13:51] lissyx: it's coming from the `extensions: [gnome-3-38]` or similar line in the `apps:` block [13:52] that tells snapcraft to insert the desktop-launch script which is housed in the snapcraft source [13:53] ok [13:53] so ultimately the fix is the one requested by gimp people [13:54] https://bugzilla.mozilla.org/show_bug.cgi?id=1773624#c6 [13:54] Mozilla bug 1773624 in Core "Firefox Snap no longer able to save file on SMB share" [--, New] [13:58] the best fix would be to petition @kenvandine and team to add gvfsdbus into the gnome extensions [13:58] yes [13:59] seb128: the wpa sru bug description isn't formatted for sru [14:06] tjaalton, sorry I was sure I had updated it, did that now [14:08] lissyx, sounds like libgvfsdbus should perhaps be in the platform snap [14:09] seb128, this is something the link from the forum requests, but there has been no action since [14:09] and honestly, trying to replicate the gimp workaround is starting to get very hairy [14:10] seb128: yes, better [14:11] lissyx, the snapcraft extension is https://github.com/snapcore/snapcraft/tree/main/extensions/desktop/common [14:12] seb128, I'm not going to be able to hack more on that today unfortunately [14:12] yeah the solution is to add libgvfsdbus to the platform snaps - I would push back on adding my "fix" for gimp into the extension desktop-launch script [14:12] seb128, I'm leaving brain dump at https://bugzilla.mozilla.org/show_bug.cgi?id=1773624#c8 [14:12] Mozilla bug 1773624 in Core "Firefox Snap no longer able to save file on SMB share" [--, New] [14:12] lissyx, ack [14:12] diddledani, ah you are the one who did it? [14:12] (I'm the primary maintainer of the gimp snap) [14:12] also gvfs in snaps is an issue [14:12] unsure if it is one for that particular case [14:13] but libgvfs needs to talk to gvfsd but that can't be allowed for security reason [14:13] usecase: accessing files from my NAS from Firefox [14:13] since there is no mediation at this level and it would basically give a free access to the host [14:13] i've already spotted at least one report, probably more linked to that [14:13] lissyx, the issue is that gvfs has no way today to limit the access to the one thing you request [14:14] diddledani, well, thanks for that, although I'm lost on how you endup with libgvfsdbus.so [14:14] lissyx, also it's weird that this report make it sound like it's a regression, I would have expected that it never worked [14:14] (I mean how you get it packaged in your snap) [14:14] seb128, it was working a few weeks ago [14:14] seb128, maybe it was using the debian package back then? [14:14] probably? [14:14] either way, from a user perspective, it's a regression [14:14] yes [14:15] there are at least three reports that complains about network files and snap [14:15] lissyx: I've got `gvfs-backends` as a dependency (stage-packages) [14:15] I'm waiting on needinfo so I can't be sure, but it sounds like it [14:15] diddledani, is that really fixing it? [14:15] diddledani, I did that as well as the layout thigns [14:15] I think we are basically talking about https://github.com/flatpak/xdg-desktop-portal/issues/102 [14:15] Issue 102 in flatpak/xdg-desktop-portal "A portal for network (and other mounts)" [Open] [14:15] 'Currently, if you need access to gvfs functionality inside the sandbox, the only option is to allow access to gvfs-daemon, which makes all network mounts available.' [14:15] diddledani, but I end up with nothing in my snap's usr/lib/... [14:16] seb128, how do I give access to gvfs-daemon ? [14:16] you can't [14:16] ok so it's not an option then [14:16] snapd doesn't allow to open random holes like flatpak do, that would make snaps unsecure [14:16] no [14:17] that's a platform problem that we need to fix, it's not trivial though [14:17] seb128: I think I'm relying on gvfs mounts already being mounted - by that point they'll be in a path located at a place that removable-media allows IIRC [14:17] diddledani, through the fuse mounts? [14:17] I forget, the change was quite a while ago now [14:18] seb128, and would a hack like the one on gimp be doable? [14:18] honestly, it's above my current level of snap [14:18] (which was undefined two hours ago) [14:19] it might be that my fix doesn't even do the job that I wanted it to do and I never reverted it ;-) [14:20] lissyx, by CIFS mount in that bug do we mean a smb:// location mounted through gio/nautilus? [14:20] yes [14:21] I think this is the issue report that I "fixed" with that change to add gvfs-backends and other related changes https://github.com/snapcrafters/gimp/issues/99 [14:21] Issue 99 in snapcrafters/gimp "Gimp cannot access all drives" [Closed] [14:21] no maybe not [14:21] donno then :-) [14:21] need to go anyway [14:21] * lissyx & [14:21] bye!