=== guiverc2 is now known as guiverc [15:09] EFI installation bug has been fixed upstream. https://github.com/calamares/calamares/pull/1991 [15:09] Pull 1991 in calamares/calamares "[bootloader] bootLoader GS is always empty for EFI" [Merged] [15:14] If the daily doesn't auto-build by the time we're all hacking away at it, I vote for an ISO rebuild. [15:40] Good (last) morning from Charlotte [15:42] "EFI installation bug has been..." <- Very nice! Thank you so much for being willing to coordinate this with upstream and make sure the fix is pushed there :) [15:42] I don't want to roll another upstream tar again (at least for the next few days) so if you can figure quilt out I'd be happy to upload your patch :) [15:42] https://www.google.com/url?q=https://raphaelhertzog.com/2012/08/08/how-to-use-quilt-to-manage-patches-in-debian-packages/&sa=U&ved=2ahUKEwigzrCW4qr4AhXPIUQIHeNzDjEQFnoECAEQAg&usg=AOvVaw3RJ9J_S04HFapBMnoMz8rs [15:42] Simon Quigley: Thanks! I'll look at it. [15:43] * https://raphaelhertzog.com/2012/08/08/how-to-use-quilt-to-manage-patches-in-debian-packages/ [15:43] arraybolt3[m]: Thank *you* :) [16:21] arraybolt3 @arraybolt3:matrix.org: this might be helpful too: https://phab.lubuntu.me/w/packaging/packaging-guide/ [16:50] Dan Simmons: Thanks, looks important. I currently still need to learn quilt, but hopefully I'll figure it out and have the patches done soon. Is the idea to just turn the latest commits into a patch, and then submit it? [17:51] Also, guys, how do I find the last commit that's part of the current Calamares package? [17:51] "Dan Simmons: Thanks, looks..." <- There is some important quilt information on the packaging guide. Essentially the patch you create gets added to the debian/patches folder and "quilted" in. [17:52] Or do I just guess and make one patch per commit and then whoever knows the answer can patch in whatever's needed? [17:52] Dan Simmons: I see that. I'm getting Quilt set up to work properly according to the packaging guide (with quiltrc and all that). [17:53] You can turn the commit into a patch. [17:53] Right but the last build was made on the 10th, I believe, and there's two commits on the 13th. [17:54] Oh wait, nevermind, I'm looking at one commit and a pull request merge... [17:54] Right, so you only need the one commit. [17:54] I see that. Sorry for the confusion, still learning Git... [17:55] No worries [17:58] That's why I merge and rebase... I avoid merge commits as much as possible [18:01] OK, I just realized that I probably need the Calamares source package so I can make the patch. How do I obtain that? [18:01] Do I use apt-get source? [18:02] Looks like that's right, I'm gonna try it. [18:09] "OK, I just realized that I..." <- The tl;dr version https://phab.lubuntu.me/w/packaging/packagingtutorial/ [18:11] OK, this is gonna take longer than expected... [18:14] Take your time. [18:16] OK, I'm to the point where I'm supposed to uncomment deb-src lines, but I'm looking at my sources.list in my Kinetic VM, and some of the deb-src lines are uncommented, and some of them are commented, which is making me worried. I think I enabled deb-src before, should I uncomment everything anyway? [18:17] * tsimonq2 CLT ✈️ MSP ✈️ GRB later [18:17] arraybolt3[m]: I just straight erase the entire file and add my own so I don't have to edit a bunch of lines [18:17] You can put all four components on one line and it'll still work [18:18] OK, sounds fun. [18:20] I know I need kinetic, but what about kinetic-updates, kinetic-security, and kinetic-backports? Do I put all those in, too? [18:20] From b_dmurray in -release: [18:20] Simon Quigley: I've set the number of rebuilds a product owner can request per day to 6 in the ISO tracker. [18:20] tsimonq2: oh nice. [18:20] ack [18:20] arraybolt3[m]: I would. [18:21] tsimonq2: Is that a nice way of saying "you're rebuilding too many times"? Or did we just get more rebuilds allowed per day? [18:22] arraybolt3[m]: Simon asked for it to be bumped, it was 3 per day previously. [18:22] Ah, OK. I thought we got in trouble for respinning an ISO every thirty minutes... (ok not that often but still) [18:23] OK, wrote my own sources.list from scratch, looks like apt hasn't lost its mind yet! 😃 [18:24] arraybolt3[m]: I asked Steve L before we did it [18:24] He basically said "I doubt you're going to run out of space" [18:24] He didn't know about or have access to change that quota [18:26] (I think it's funny that I'm like, "Oh no, the config file doesn't look right, what do I do? How do I fix it?!!", and the answer is, "Oh, just nuke it and write your own." My initial response was "OK, that's worse", but now that it's working, I'm like, "Hey, this is cool!") [18:29] [telegram] only part about github I really like is the contributions graph [18:33] Lynorian's graph likely lights up the room. :D [18:34] "(I think it's funny that I'm..." <- Here is the script that initially creates the sources.list https://git.launchpad.net/~ubuntu-qt-code/+git/calamares-settings-ubuntu/tree/common/modules/automirror/main.py?h=ubuntu/kinetic [18:35] Looking at that reminds me we need to edit it. The Partner repository is no longer. [18:36] Wow, my Internet is good, but it's time zone info is SO BAD. One day it thinks I'm in Denver, the next day I'm clear over in New York, and every once in a while it puts me in Chicago, the time zone I'm actually in. [18:38] Today I'm in New York after about a week in Denver. And I never left my house in Missouri. What is WRONG with this thing?! [18:41] Geoip isn't the most reliable. [18:41] It's not GeoIP's fault, even my Chromebook thinks I'm zipping around the country, and I think a Windows laptop is doing the same thing, too. [18:43] Anyway, not on topic, just annoying. [19:11] Quick question, is Falkon suitable for use with all our websites for developer stuff? I'm spinning up a whole new development VM and I just chucked Firefox and installed Falkon so I can test it. [19:13] It seems to work fine for most things. [19:24] OK, bit of a problem. I'm following the packaging requirements setup guide, and everything was going just fine until "arc set-config phabricator.uri "https://phab.lubuntu.me". Arcanist proceeded to throw a temper tantrum with a PHP fatal error. [19:25] OK, I don't see any personal data in the error, so I'm gonna pastebin it. [19:27] https://pastebin.com/QsWgiQY0 [19:28] Don't worry about setting up the phab or arc stuff [19:29] OK. [19:29] Should I also skip the gpg, bzr, and ssh agent with keychain steps? [19:31] You should be good there too [19:32] OK. (I saw the warnings in the TL;DR you sent me, and was like, "OK, make sure everything works right, I'mma follow **all** the steps. LOL, guess that was overkill) [19:32] Yeah we need to revise the docs when we get on a new platform. [19:33] You will need gpg when you get upload rights. [19:34] bzr is rarely used these days, most everything has migrated to git. [19:40] Thanks for all your help! I hope I'm not bugging you too much, but I'm a bit confused here. The packaging tutorial has me getting the source code from Phab. There's no Calamares repository in Phab that I can see, but there is a Calamares packaging repository. So I have the Calamares packaging repo. the Calamares GitHub repo, and the Calamares source from apt-get source. I dunno what I do at this point. Do I clone from just the [19:40] right commit from Calamares GitHub, combine in the Calamares packaging, and then work from there? Or do I get everything from apt-get and work from there? Or...? [19:41] s/clone/checkout (I think) [20:03] No worries, sorry for my delayed replies in between tasks. It sounds like you are on the right track. Just substitute anything you see for phab with Github. [20:04] OK. But, don't I need a Calamares source code repo that includes debian/patches in it already, so I can add another patch? [20:05] (It seems like I'm probably supposed to apt-get source the existing Calamares package in Kinetic, then use the data from GitHub to generate the patch with quilt.) [20:06] Nope, don't need apt here. [20:06] The packaging repo should have a debian directory where the patches are. [20:07] uscan downloads the source tar from upstream. [20:08] Oh, OK. And that will work even though the tip of the Calamares branch contains the commit I want to turn into a patch? I figured I'd need the code from just before the patch, then I can use quilt to prepare for the patch, then change the file, create the patch, and submit it. [20:08] (I guess I just git clone, git checkout, copy in the packaging files, then use quilt.) [20:16] Really rough order -> fork on github, git clone, git checkout ubuntu/kinetic, uscan, tar extract, quilt new, quilt edit, quilt refresh, quilt header, dch -i, debuild, rm source files, git push, do PR [20:17] Nice. That should be enough for me to figure it out! Worst case scenario, someone will look at my work before blindly merging it and will be able to tell if I botched something. Thank you! [20:18] The tl;dr guide is slightly more verbose ^ [20:19] Don't be afraid if you have quilt woes, it can be fun. [20:21] Almost forgot about this page, it could be useful too: https://phab.lubuntu.me/w/packaging/packaging-example/ [20:38] OK, quick question. I'm doing the git diff part of patch making, and I decided to look at what it was outputting before making the patch file. To my surprise, the patch makes it look like it's going to do the exact opposite of what the commit did (delete all the lines that were added, add the lines that were deleted). The packaging example has me doing "git diff ^". When I change that to "git diff ^ [20:38] " everything looks right. Is the backwards-looking patch really correct? Or am I right that I need to tweak the command? [20:38] arraybolt3 @arraybolt3:matrix.org: Word of advice on GPG keys, guard it like it's your social security card. [20:38] Assuming we meet at some point, I will be happy to sign your key. I'd need to see some ID that matches your GPG key but I can then officially recognize that you're who you say you are [20:40] arraybolt3[m]: The example might be backwards so you are probably on the right track. [20:40] Simon Quigley: Yeah, encryption keys are very important things to keep safe. I have an assortment of strong passwords I keep in memory, and I use Chrome's password manager for everything else, but I should come up with a dedicated password for just the GPG key (and maybe use it for SSH too?). [20:41] Simon Quigley: By form of ID, I assume the corresponding secret key will do? [20:41] arraybolt3[m]: Yeah good passwords are important. [20:42] arraybolt3[m]: Like a drivers license or passport. That kind of ID. [20:42] Ah, OK. I figured those aren't linked to a GPG key at all, but OK. [20:43] Some Debian Developers require two. I only require two if you don't have clout within the community [20:43] (Two forms of ID) [20:43] (I guess having that, and a GPG secret key.) [20:44] Also, fun fact, Simon is my middle name. It says Simon Quigley on my ID but it's partially my full name [20:44] My dad is Tom, I'm Simon, I have an II on the end of my name [20:44] The two DDs I signed with had no problem with that - in fact, it explains my username [20:45] (Why do people name their kids their own name plus a 2? I don't get it.) [20:45] My grandmother believed that she named my dad what she did due to divine intervention. She meant to say a completely different name but Thomas came out [20:46] I plan on naming my firstborn son ...Quigley III fwiw :) [20:46] (Fun fact - cut one of the I's off of III, and you get the same number but in binary.) [20:47] hahahaha :) [20:47] Anyway, what were we talking about? [20:47] Quilting [20:47] Oh one more thing I'll mention to Aaron before we move on... [20:48] At Altispeed Technologies I'm required to keep my SSH key on a Yubikey. You can also do that with GPG keys [20:48] So would recommend [20:48] Anyway [20:48] How is quilting? [20:48] Simon Quigley: That sounds way more secure than putting it on a flash drive. One small problem I have is that my desktop uses only USB-A ports, but my Chromebook uses only USB-C ports. Do they make Yubikeys that work with both? [20:49] Quilting is REALLY HARD this first time! I've still not even run "quilt" yet, fighting with git and tutorials ATM. [20:49] arraybolt3[m]: Yes [20:49] arraybolt3[m]: I would think so [20:50] arraybolt3[m]: Have you ever worked with diff and manually applying patches? [20:50] What in the world...? Matrix just decided to tell me something about stickerpacks out of nowhere LOL [20:50] tsimonq2: Nope. 😱 [20:51] arraybolt3[m]: I would run through that process once and it'll all kind of click [20:51] So let me give you an example... [20:52] LXQt releases tarballs but applies commits on top. They basically apply patches on top completely managed by version control [20:52] I'll give you an example repo and an example commit [20:52] Try cloning it and manually applying the patch using patch -p1 < PATH [20:52] Dan Simmons: I know you said to replace Phab with GitHub, but I still can't figure out where to get the active source code from. I have the upstream code, but I don't know where to get the code that's actively in Lubuntu ATM. [20:52] Simon Quigley (Developer): OK, tracking. [20:53] So, clone this repo: https://github.com/lxqt/libfm-qt/ [20:53] Then run git checkout 1.1.0 [20:53] We're going to try with this commit here... [20:53] https://github.com/lxqt/libfm-qt/commit/472128c3bfc301f3258bd99501a88ef4097d0429 [20:53] Commit 472128c in lxqt/libfm-qt "Fixed crash with empty URI scheme of folder path (#808)" [20:53] Cloning. [20:53] Done. [20:53] So there's two ways you can pull that patch... [20:54] A) you can use git cherry-pick ID to just straight pull that commit [20:54] This time, just add .patch to the end of that commit url [20:54] You should be able to download it [20:54] OK, wait, git cherry-pick? [20:54] tsimonq2: And as long as you checked out the 1.1.0 tag, you should be able to apply it with this command [20:54] I know git clone, git checkout, git reset (sorta), and git push so far. (And git add and git commit.) I dunno what cherry-pick is. [20:55] I know I'm going fast :) [20:55] arraybolt3[m]: Do you know what it means to cherry pick something or are you simply asking about command usage? [20:56] I don't know what the cherry pick command does. [20:56] Using the man page... [20:56] Okay, so it pulls a single commit rather than having to merge the entire branch [20:56] You can do that or you can manually download the patch [20:57] Playing with this will make quilt easier to understand though :) [20:57] Oh OK. I think I understand. [20:57] Cool. Any further questions I'm happy to help :) [20:57] * tsimonq2 sometimes goes too fast - if you don't understand a part of it don't hesitate to say so [20:57] So, it grabs just one commit and applies it? Like manually downloading the patch and then shoving it in with diff? [20:58] Exactly :) [20:58] And not shoving it in with diff... [20:58] With patch :) [20:59] Right, because diff makes the patches, and patch applies them. Got it. (Turns out this is a deep rabbit hole of Linux I never hardly touched before.) [21:01] Back to calamares, to get what is currently in Lubuntu git clone the Calamares packaging repo and use uscan to download the current version. That looks at the version in the changelog and downloads the tar based on what is in the debian watch file. [21:02] Dan Simmons: OH, I GET IT! Finally uscan makes sense to me! Thank you, that made it click. [21:03] Yeah, I glossed over, sorry. [21:03] And you'll know if your watch file is b0rked pretty quickly [21:04] You can throw on verbose mode but I'd argue they're equally as if not more frustrating than symbols [21:04] To write from scratch, that is [21:05] Another cool feature I'll share is upstream signing keys. uscan automatically checks that it has integrity [21:06] Yeah, watch files are fun use of special characters [21:07] I can't hardly understand what you guys are saying, but it sounds cool! And scary. And like it could blow up in my face. Hey, I guess that's why we use VMs, right? [21:07] Bingo [21:08] * tsimonq2 uses sbuild [21:09] Me too, we haven't graduated @arraybolt3 to that yet though. [21:09] Baby steps ;) [21:10] ^^ :) [21:10] Everyone gets there eventually [21:10] "I know git clone, git checkout..." <- git bisect is the most fun of them all ;) [21:11] Oh, I've tried to do git bisect before, I never managed to get there because of complications before that, but I almost did it! [21:11] Hey, I just signed in on my desktop, is that doing anything weird as far as messages? [21:11] Looks like it's working. [21:12] arraybolt3[m]: That's the beauty of Matrix, we can't tell [21:12] I've been messaging you guys half on my laptop half on my phone [21:12] On IRC it makes things go wonky, but it looks OK here. [21:12] Nice. Now I can set my Chromebook to charge and stop having to multitask on multiple systems. 👍 [21:13] arraybolt3[m]: Quassel doesn't mind if you have a core setup. [21:13] Eh, Quassel + Chrome OS = way too much disk space used for my taste. [21:15] Simon Quigley (Developer): OK, so I need to download the patch. What do I do that with? GutHub doesn't seem to have a download button. [21:15] (LOL, GutHub. Accurate.) s/GutHub/GitHub [21:18] OK, I did git checkout 1.1.0 and then git cherry-pick . Was that right? [21:19] If you have the web link, paste that into your browser address and add `.patch` to the end and you should be prompted to download. You will probably want to rename it after. [21:20] Oh, OK. I think I remember that going by in the chat, but I forgot it. [21:20] arraybolt3[m]: This should work too. [21:20] OK, it looks right. [21:20] Neat [21:22] OK, and I did it with patch! Hey, figuring this out! [21:26] Hmm. The Phab documentation contained dire warnings to use SSH cloning, not HTTP cloning, but I'm trying to do it with SSH and it seems stuck. [21:26] (Cloning the calamares-packaging repo from Phab.) [21:27] quilt is automated patch without Git [21:27] arraybolt3[m]: Consider Phab deprecated [21:27] Simon Quigley (Developer): Right, but how do I get the calamares-packaging repo? Oh, you have a Lubuntu GitHub, huh? [21:27] arraybolt3[m]: Yeah [21:27] Ah. OK, let's try that then. [21:28] Soon enough when you get commit access you should do it via SSH [21:28] (Ask when you're at 5-10 solid changes) [21:28] Fork on github then clone [21:28] Commit access =/ upload access [21:28] kc2bez[m]: That too [21:29] Found it! And I'm forking because I'm going to be uploading a quilt patch, right? [21:29] Right, then Simon can merge your changes. [21:30] Or I can too I guess. Whoever gets there first. [21:32] OK, cloned it. Thanks for training me on this! [21:33] Oh no. uscan is downloading Calamares 3.2.59. [21:33] Absolutely, thanks for working on it. [21:34] I need 3.3.0 but right behind the UEFI-boot fixing commit, right? [21:37] And as expected, quilt failed. [21:38] cat debian/patches/series and show error plz [21:39] The problem is that, in Calamares 3.2.59, there was a piece of code in the bootloader module. It got changed in Calamares 3.3.0, which caused the bug, so now it's been changed back to what it was in Calamares 3.2.59. So applying this patch to Calamares 3.2.59 is bound to fail since the code's already right in Calamares 3.2.59. I need to apply it to Calamares 3.3.0, which uscan didn't download for me. [21:40] I think if I can just get the source code used in the Calamares 3.3.0 package that's in Kinetic (complete with packaging data), I can make this happen. [21:41] debian/patches/series: https://pastebin.com/ZWC6gLSH [21:41] Error: https://pastebin.com/qhJayL3w [22:07] Hmm, thoughts here Simon Quigley (Developer)? [22:08] Oh so the Git repo needs to be updated [22:09] What is in debian/changelog for a version arraybolt3 [22:15] Hold on, grabbing it... [22:16] https://termbin.com/yo67 [22:17] That's the contents of debian/changelog from the calamares-packaging Git repo I believe. (Come to think of it, I should have just linked to the file on GitHub...) [22:19] Yeah, all good. That is definitely not the latest. [22:19] * kc2bez[m] shakes fist at github [22:19] The changelog in the files from apt-get source looks right. [22:19] We can't really use that though [22:21] Crud. [22:22] I have the bootloader patch extracted from the upstream code, though. [22:22] * kc2bez[m] wonders why it isn't mirrored, it should be. [22:22] It's not up to date on Phab, either. [22:22] No? [22:23] Top line of the file is "calamares (3.2.59-0ubuntu1) kinetic; urgency=medium" [22:23] Blah [22:24] * kc2bez[m] wonders what is in launchpad [22:25] * tsimonq2 flies [22:25] Indeed [22:25] Lots of em. [22:26] Hey, I can git clone from Launchpad. [22:27] Maybe, you won't be able to push there though. [22:28] At least, I thought I could, but it won't take my username or email or password. [22:28] (At least not through Git, anyway.) [22:29] Right, that is what I would have thought. [22:59] Alright, this might be less an issue of the system(s) and more like we need some commits from Simon Quigley (Developer) ;) [23:00] Hey, possibly silly question, but can I git clone the repo, copy all of the corresponding files from the apt-get source download, do git add * and git commit and have it fixed? [23:01] The problem with doing that is it squashes all of the commits and you loose the tags too. [23:01] Eh, oh well. I'll just wait. [23:28] Sorry about that arraybolt3 we'll get you over the finish line as soon as we can. [23:59] [telegram] tbh we should be using a less convoluted workflow imo [23:59] [telegram] its why i use git-buildpackage in Debian source repos for me :P