[00:09] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww edited [pull request #2469](https://github.com/MirServer/mir/pull/2469): wlr-screencopy-v1: send .damage event when required
[00:58] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww opened [pull request #2470](https://github.com/MirServer/mir/pull/2470): Send changed area to frame posted notification... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/16d22f0bf2389563c76a73068d88721c10232faf)
[02:36] -GitHub[m]:#mir-server- **[MirServer/mir]** RAOF opened [pull request #2471](https://github.com/MirServer/mir/pull/2471): renderers/gl: Clear framebuffer to opaque black, not fully-transparent.... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/ce162b329cec96e76472bd0c5740179482a01258)
[04:38] -GitHub[m]:#mir-server- **[MirServer/mir]** RAOF removed RAOF review needed from [issue #1130](https://github.com/MirServer/mir/issues/1130): [mesa] Add support for modifiers
[04:51] -GitHub[m]:#mir-server- **[MirServer/mir]** frank-dspeed edited [issue #2467](https://github.com/MirServer/mir/issues/2467): Auto-selection of X11 platforms fails with Nvidia drivers (470 and 515)
[04:52] -GitHub[m]:#mir-server- **[MirServer/mir]** frank-dspeed edited [issue #2467](https://github.com/MirServer/mir/issues/2467): Auto-selection of X11 platforms fails with Nvidia drivers (470 and 515)
[04:53] -GitHub[m]:#mir-server- **[MirServer/mir]** frank-dspeed edited [issue #2467](https://github.com/MirServer/mir/issues/2467): Auto-selection of X11 platforms fails with Nvidia drivers (470 and 515)
[04:59] -GitHub[m]:#mir-server- **[MirServer/mir]** frank-dspeed edited [issue #2467](https://github.com/MirServer/mir/issues/2467): Auto-selection of X11 platforms fails with Nvidia drivers (470 and 515) using LXDE
[08:05] <Saviq> Good morning o/
[08:07] <alan_g[m]> Good morning. It is sunny here, possibly a day to use the outdoor office
[08:10] <Saviq> alan_g I can't do `MultiLogger(std::initializer_list<std::unique_ptr…>)` as you can't move out of `std::il` AIUI, and UPtr is move-only. Am planning to move a `std::vector<std::unique_ptr…>` instead, which would also help with constructing the vector of child loggers, WDYT?
[08:14] <alan_g[m]> Saviq: I'll have to experiment, there must be a better solution. I just don't know which it is...
[08:18] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths edited [pull request #2471](https://github.com/MirServer/mir/pull/2471): renderers/gl: Clear framebuffer to opaque black, not fully-transparent.
[08:34] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] closed [issue #2465](https://github.com/MirServer/mir/issues/2465): ABI breakage of libmircore.so.1 with v2.8.0 vs v1.8.2
[08:34] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2466](https://github.com/MirServer/mir/pull/2466): Bump mircore soname
[09:08] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2471](https://github.com/MirServer/mir/pull/2471): renderers/gl: Clear framebuffer to opaque black, not fully-transparent.
[09:08] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] closed [issue #2427](https://github.com/MirServer/mir/issues/2427): Screenshotting and background
[09:13] <alan_g[m]> <alan_g[m]> "I'll have to experiment, there..." <- Saviq I think that the best trade-off is to use shared_ptr and copies. That does come at a cost, but this shouldn't be a "hot" path (just executed once during setup)
[09:13] <Saviq> Yeah that was the other alternative. ACK
[10:16] <Saviq> alan_g something to fix on 32 bit:
[10:16] <Saviq> https://launchpadlibrarian.net/607040430/buildlog_ubuntu-kinetic-armhf.mir_2.8.0+dev217-gfbe99fb062-0ubuntu22.10_BUILDING.txt.gz
[10:17] <alan_g[m]> Yeah, just started on that
[10:28] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths opened [pull request #2472](https://github.com/MirServer/mir/pull/2472): Fix armhf symbols
[11:13] <alan_g[m]> Saviq a quick one: https://github.com/MirServer/mir/pull/2472
[11:23] <Saviq> Was waiting for a Pi to test, but went ahead and borsed instead…
[11:25] <alan_g[m]> Saviq: Oh, you actually wanted to try packaging it on armhf before landing! (Maybe we should do that in CI too)
[11:26] <Saviq> We do, but apparently that doesn't catch this problem.
[11:28] <Saviq> Oh! We don't: https://github.com/MirServer/mir/blob/3739e3fbb18ebf88cd2767b5aa5da94f8966166a/.github/workflows/spread.yml#L45
[11:29] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq drafted [pull request #2473](https://github.com/MirServer/mir/pull/2473): ci: add armhf builds
[11:29] <Saviq> Let's see how that fares
[11:29] <Saviq> (it should fail)
[11:32] <alan_g[m]> Saviq: That's how good tests should begin
[11:41] <Saviq> Which is why I raced bors to this PR :)
[11:48] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2472](https://github.com/MirServer/mir/pull/2472): Fix armhf symbols
[12:15] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq opened [issue #2474](https://github.com/MirServer/mir/issues/2474): AllSurfaceTypes/TouchTest flaky in CI... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/7833560741850540df42056e7a779046ffb26be0)
[12:16] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq edited [issue #2474](https://github.com/MirServer/mir/issues/2474): wlcs.AllSurfaceTypes/TouchTest / .BadBufferTest flaky in CI
[12:17] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq edited [issue #2474](https://github.com/MirServer/mir/issues/2474): wlcs.AllSurfaceTypes/TouchTest / .BadBufferTest flaky in CI
[12:28] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2469](https://github.com/MirServer/mir/pull/2469): wlr-screencopy-v1: send .damage event when required
[12:42] <Saviq> > (it _should_ fail)
[12:42] <Saviq> Oh well… it _did_ fail, just not how we wanted it to…
[13:21] <alan_g[m]> Yeah, there seems to be too many "random" wlcs tests failures.
[13:45] <alan_g[m]> Like this (wlcs.MultiRectEdges/RegionSurfaceInputCombinations.*) https://launchpadlibrarian.net/607067476/buildlog_ubuntu-focal-arm64.mir_2.8.0+dev225-gd7826d3c16-0ubuntu20.04_BUILDING.txt.gz
[13:49] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq edited [issue #2474](https://github.com/MirServer/mir/issues/2474): wlcs tests flaky in CI
[13:52] <Saviq> alan_g re: nullptr logger override, that was the behaviour before my changes, and AIUI means it falls back to the default (IoW, doesn't override) - I agree it's not intuitive, and we may as well override always.
[13:53] <Saviq> Also, after my changes we will only do that if we fail to write to the log file, so there's less reason to "retain the default" if that's not gonna happen unless things go in unexpected ways
[13:56] <Saviq> So I applied your suggestion.
[13:59] <Saviq> And now I realize a null shared_ptr is not exactly the same as an empty one.
[14:01] <alan_g[m]> You're right, it would then use the default
[16:47] <sophie-w> Working on the ABI break to geometry, do we need to keep the `_generic` headers around?
[16:49] <alan_g[m]> sophie-w: They're used (by other headers). What are you wanting to do?
[16:52] <sophie-w> alan_g[m]: Move their contents into the non-generic version (when `Point` is just a typedef specialization of `generic::Point`, there's no need to have it in it's own header)
[16:53] <Saviq> > Yeah, there seems to be too many "random" wlcs tests failures.
[16:53] <Saviq> I have a distinct feeling it got worse, too.
[16:53] <sophie-w> > <@saviq:matrix.org> > Yeah, there seems to be too many "random" wlcs tests failures.
[16:53] <sophie-w> > 
[16:53] <sophie-w> > I have a distinct feeling it got worse, too.
[16:53] <sophie-w> Agreed
[17:07] <alan_g[m]> Goodnight all!
[17:39] <Saviq> And here it goes:
[17:39] <Saviq> https://mir-server.io/docs/how-to-maintain-documentation
[17:42] <Saviq> Good night from me o/
[18:37] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2464](https://github.com/MirServer/mir/pull/2464): performance_test: record renderer and mode
[20:46] -GitHub[m]:#mir-server- **[MirServer/mir]** graysonguarino pushed something to [pull request #2299](https://github.com/MirServer/mir/pull/2299): Filter 2 distinct bogus touch event scenarios
[21:15] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww opened [pull request #2475](https://github.com/MirServer/mir/pull/2475): Simplify geometry types
[21:15] -GitHub[m]:#mir-server-  
[21:15] -GitHub[m]:#mir-server- > For ABI stability reasons, we previously had the int geometry types inherit from the generic ones. Making the same code work for both these inherited types and the generic ones added all sorts of complexity and a few papercuts. Now that we are breaking the mircore ABI all of that can be removed. The one downside is that the forward declarations of geometry types changed and became more verbose, so I switched everything that was forward
[21:15] -GitHub[m]:#mir-server- declaring them to use the `geometry/forward.h` header. I also consolidated the headers.