| jelmer | cjwatson: If you have chance, another review of either https://code.launchpad.net/~jelmer/loggerhead/drop-python3/+merge/426103 or https://code.launchpad.net/~jelmer/loggerhead/no-file-ids/+merge/426375 would be great | 11:42 |
|---|---|---|
| jelmer | (the latter is larger, but supersedes the former) | 11:43 |
| cjwatson | jelmer: does this break old rev-id-ful links? | 12:10 |
| cjwatson | jelmer: I guess there may ultimately be not much choice if so ... | 12:10 |
| jelmer | cjwatson: It doesn't break rev-id-ful links, but would break old links that include filter_file_id arguments | 12:11 |
| jelmer | revid are still fully supported, fileids are becoming more of an implementation detail | 12:12 |
| cjwatson | Sorry, I meant file-id indeed | 12:13 |
| cjwatson | https://www.google.com/search?channel=fs&client=ubuntu&q=%22bazaar.launchpad.net%22+%22filter_file_id%22 finds a few such old links, but doesn't seem like catastrophically many, and I agree it seems ultimately necessary | 12:14 |
| cjwatson | (also those URLs really were horrible) | 12:14 |
| cjwatson | jelmer: I've approved the larger MP - let's see what the test job does | 12:15 |
| jelmer | cjwatson: we could potentially keep the support for filter_file_id around where the version of breezy / format supports it | 12:17 |
| cjwatson | I'm not sure that's worth it, since we'll want to upgrade breezy at some point anyway | 12:21 |
| cjwatson | jelmer: I hate xenial so much. https://code.launchpad.net/~cjwatson/loggerhead/py35-workarounds/+merge/426630 ? | 13:09 |
| cjwatson | jelmer: (deals with the test failure on your branch) | 13:09 |
| jelmer | cjwatson: LGTM | 13:14 |
| jelmer | cjwatson: is launchpad still on xenial or is it just the test runner for loggerhead? | 13:14 |
| jugmac00 | jelmer: still - but we are working on it | 13:18 |
| cjwatson | Yeah, the migration got set back quite a bit by needing to move out of an old datacentre | 13:21 |
| cjwatson | Tests pass on bionic, but we're trying to see if we can jump straight to focal in order to make more economical use of scarce SRE time. We have solid progress on 2/3 of the remaining known blockers for running on focal. | 13:26 |
| cjwatson | jelmer: I assume you'd like us to upgrade bazaar.launchpad.net to this? (Or you can propose a merge yourself - it's still `utilities/sourcedeps.{conf,cache}` with a `utilities/update-sourcecode` script for managing the latter, though it's in git these days and it's been almost a decade since your last commit so I don't imagine you still have a development environment handy ...) | 13:31 |
| cjwatson | jelmer: and should we reject https://code.launchpad.net/~jelmer/loggerhead/drop-python3/+merge/426103 now? | 13:34 |
| jelmer | cjwatson: yeah, it'd be good to upgrade - though there's no hurry until you also update to Breezy >= 3.3 | 13:35 |
| jelmer | cjwatson: Yeah, I'll remove that MP - thanks for the merge | 13:35 |
| cjwatson | jelmer: OK, I filed https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/426634 since I figure we may as well stay current | 13:39 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!