=== cpaelzer_ is now known as cpaelzer | ||
cjp256 | blackboxsw: the is_platform_viable() interface you're thinking of, will that include a parameter for seed_dir? it's not clear to me which seed scenarios exist but the source does check seed dir to determine viability | 14:58 |
---|---|---|
=== smoser1 is now known as smoser | ||
blackboxsw | cjp256: sorry to miss this ping there is only one potential seed dir that I think ds-identify looks for `/var/lib/cloud/seed/azure/` I actually don't know if any images in Azure cloud platform ever instruments this use-case and seed that directory anymore. It may be just historical | 20:36 |
blackboxsw | cjp256, that said, I know Azure config magic sets datasource_list: [Azure] anyway so ds-identify doesn't even go down the path of trying to check_seed_dir because a datasourcE_list of one means do no further detection. https://github.com/canonical/cloud-init/blob/main/tools/ds-identify#L1798-L1802 | 20:49 |
blackboxsw | cjp256: thanks I see you've addressed the comments and kept this is_platform_viable function separate. Thank you much for this. looks good and will land it. we can iterate in the future if needed | 20:53 |
blackboxsw | agreed falcojr on rename cc_autoinstall -> cc_ubuntu_autoinstall for basic schema support via #cloud-config | 21:39 |
blackboxsw | rebased and pushed https://github.com/canonical/cloud-init/pull/1572 | 21:39 |
ubottu | Pull 1572 in canonical/cloud-init "UC02.1: subiquity autoinstall directives opaque schema support (SC-1160)" [Open] | 21:39 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!