[00:54] <arraybolt3[m]> Shoot, we'd better be seriously careful with the Calamares SRU. Just got this email:... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/2c515d8e534cafb1963980f7c24ba39e25e707a2)
[00:55] <arraybolt3[m]> I think that means that, even if the SRU is done on time, it might still get kicked off of the ISO if it's not perfect.
[01:15] <Eickmeyer[m]> Yeah, we all got that email, I'm sure.
[01:16] <arraybolt3[m]> I figured that was likely, but just in case.
[01:26] <Eickmeyer[m]> Well, let's not be discouraged and proceed as planned.
[01:49] <arraybolt3[m]> Simon Quigley (Developer) Eickmeyer https://paste.ubuntu.com/p/jHJqdhmrsk/ Calamares SRU paperwork take 3
[01:51] <Eickmeyer[m]> LGTM
[01:57] <arraybolt3[m]> I think Simon Quigley (Developer) is busy, should I just plug it into the bug report as-is and go for it (attaching the required debdiff and subscribing the sponsorship team, and all the other SRU stuff I'm supposed to do)?
[01:57] <arraybolt3[m]> Eickmeyer: ^
[02:00] <Eickmeyer[m]> There's a couple of steps you can skip, but I don't know who's agreed to sponsor you: you don't need to attach the debdiff or subscribe the sponsorship team if you already have a sponsor.  Simon Quigley (Developer) or myself can do it, but I have the feeling Simon was going to handle this one. 
[02:01] <arraybolt3[m]> I think I should wait, but it's late and I don't want to mess up our progress by being too slow.
[02:01] <Eickmeyer[m]> I get it, but those steps can be skipped if you already have a sponsor lined-up, which you do.
[02:02] <Eickmeyer[m]> Feel free to update the bug report and attach the debdiff, but don't subscribe anyone else just yet. Nothing will move forward until the upload is done anyhow.
[02:03] <arraybolt3[m]> OK. Sounds like a palm.
[02:03] <arraybolt3[m]> s/palm/plan/ 🤦‍♂️
[02:04] <arraybolt3[m]> Eickmeyer: I am supposed to add all the SRU stuff to the start of the bug report, but leave the original, right? Or do I clobber everything that's already there?
[02:05] <arraybolt3[m]> So it will originally have looked like... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/b00cb9491d1d29b272cb918584e407cd32f17719)
[02:05] <arraybolt3[m]>  * So it will originally have looked like... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/41fdc56f39fefd5f7aaee2e9ae79abd511083265)
[02:05] <arraybolt3[m]> s/`//, s/`---`/---/, s/`//
[02:05] <arraybolt3[m]> * ## So it
[02:06]  * arraybolt3[m] is fighting with Markdown
[02:06] <Eickmeyer[m]> Yeah, leave the original, just add it to the top.
[02:10] <arraybolt3[m]>  * So it will originally have looked like... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/4580ad1a30c29760e8206a0a82c22fc5e1d04a1d)
[02:10] <arraybolt3[m]> s/`ABC`/`ABC`/
[02:11] <arraybolt3[m]> OK, got the bug report updated, but I'm having to compile Calamares again to make absolutely sure everything is entirely clean, so it's going to be a bit before the debdiff gets attached.
[02:18] <Eickmeyer[m]> No worries. 
[02:29] <tsimonq2> arraybolt3: Reviewing your bug report description.
[02:30] <tsimonq2> > flavours
[02:30] <tsimonq2> ok canadian
[02:32] <tsimonq2> > [Where problems could occur]
[02:32] <tsimonq2> ok you'
[02:32] <tsimonq2>  * ok you're not specific enough
[02:32] <tsimonq2> Everyone gets this wrong when they SRU
[02:33] <tsimonq2> The real question is, what could break, not why it would break
[02:33] <tsimonq2> Yeah, obv if we find a bug it comes from le upstream
[02:33] <tsimonq2> And we should submit it there accordingly
[02:34] <tsimonq2> But it's asking, what specifically could break in this update. An example may be, a system could be unbootable if the installer really screws up.
[02:34] <tsimonq2> For 22.04.2 we should talk to Rik and consider getting some KPMCore patches in too... bugfix, not this type of stuff
[02:35] <tsimonq2> I guess what I'm asking is, could you elaborate on this sentence? "it could potentially result in failed or otherwise broken installations"
[02:40] <arraybolt3[m]> OK, "flavours" was the spelling Canonical uses, so I keep using it to avoid being ambiguous. My spellchecker gets after me for it Every. Single. Time.
[02:41] <arraybolt3[m]> Simon Quigley (Developer): Ok, how about "failed, unbootable, or unusable installations"? Failed - as in Calamares says "Installation failed." Unbootable as in, "well it installed OK but now I'm being told there's no OS." Unusable as in "Yikes, what's THIS mess on my screen now?!".
[02:43] <arraybolt3[m]> I could say:
[02:43] <arraybolt3[m]> If a bug was introduced in this version of Calamares, or if a configuration change is needed in calamares-settings-ubuntu, it could result in installations failing, being unable to boot after a "successful" installation, or being bootable but too damaged to use.
[02:43] <arraybolt3[m]> Is that too much "why" mixed in still?
[02:44] <tsimonq2> I think that was modified since I last saw it. Used to say Regression Potential
[02:44] <arraybolt3[m]> I'm trying to follow the idea from this: https://bugs.launchpad.net/ubuntu/+source/unattended-upgrades/+bug/1590321
[02:44] <ubot93> Launchpad bug 1590321 in unattended-upgrades (Ubuntu Zesty) "/usr/bin/unattended-upgrade:FileNotFoundError:/usr/bin/unattended-upgrade@1468:main:get_dpkg_log_content" [Undecided, Fix Released]
[02:44] <arraybolt3[m]> (This is the bug the SRU how-to document links to.)
[02:44] <arraybolt3[m]> So I'm trying to make my "Where problems could occur" section look like that-ish.
[02:46] <arraybolt3[m]> Simon Quigley (Developer): "If a bug was introduced in this version of Calamares, or if a configuration change is needed in calamares-settings-ubuntu, it could result in installations failing, being unable to boot after a "successful" installation, or being bootable but too damaged to use." (SRU regression potential section take 2)
[02:47] <tsimonq2> I'd also add something to the tune of "you can tell pretty quickly if something is b0rked" lol
[02:49] <arraybolt3[m]> Simon Quigley (Developer): "If a bug was introduced in this version of Calamares, or if a configuration change is needed in calamares-settings-ubuntu, it could result in installations failing, being unable to boot after a "successful" installation, or being bootable but too damaged to use. Due to the highly obvious nature of such issues, it will be easy to catch it if something like this happens." (Take 3, tried to make it
[02:49] <arraybolt3[m]> "official" sounding.)
[02:50] <tsimonq2> LGTM
[02:51] <arraybolt3[m]> Done.
[02:51] <arraybolt3[m]> And my compile is finally done, so the debdiff should be in shortly.
[02:58] <arraybolt3[m]> Simon Quigley (Developer): Debdiff uploaded, I marked it as a patch since that's what I thought it was, should I change that?
[03:00] <tsimonq2> Nope. I will prioritize this and review it right now. $dayjob has been taking up the vast majority of my time.
[03:00] <tsimonq2> Prepare for the torch if so much as one line is off ;)
[03:00] <tsimonq2> You have five minutes, are you sure you're ready for a full review again?
[03:00] <arraybolt3[m]> Understood and more than happy to receive it. (It's the same thing you checked before, though.)
[03:01] <arraybolt3[m]> (Also, I have an SRU for calamares-settings-ubuntu that fixes the BTRFS install bug, so we should probably get around to that once Calamares proper is dealt with.)
[03:02] <lubot> [telegram] <teward001> it was, like six months ago.  you were still AWOL (re @lubuntu_bot: (irc) <tsimonq2> I think that was modified since I last saw it. Used to say Regression Potential)
[03:02] <lubot> [telegram] <teward001> (mostly, anyways)
[03:03] <tsimonq2> arraybolt3[m]: Don't wait on this. I'll fix up whatever is left on calamares and upload it. Depending on time zones it may be in proposed before you EOD. Just work on the settings pretty please. 
[03:03] <arraybolt3[m]> 👍️
[03:04] <tsimonq2> I will flame you if I find something though :)
[03:04] <tsimonq2> (The SRU team manually reviews diffs. I'm preempting their questions. I'm friendlier. :) )
[03:09]  * tsimonq2 sent a code block: https://libera.ems.host/_matrix/media/r0/download/libera.chat/83415e2c75cf521282f4d781826d0ce6986ef645
[03:10] <tsimonq2> Fixing
[03:10] <arraybolt3[m]> How... what?
[03:11] <arraybolt3[m]> The changelog in our packaging and the changelog in Ubuntu proper is different. Look at what my changelog says:
[03:11] <arraybolt3[m]> calamares (3.2.41.1-0ubuntu3) jammy; urgency=medium
[03:11] <arraybolt3[m]>   * No-change rebuild with Python 3.10 as default version
[03:11] <arraybolt3[m]>  -- Graham Inggs <ginggs@ubuntu.com>  Fri, 14 Jan 2022 11:25:54 +0000
[03:11] <arraybolt3[m]> This is pulling directly from our GitHub and then checking out the Jammy branch.
[03:12] <tsimonq2> lol are you aware of what an NCR is?
[03:12] <arraybolt3[m]> No...
[03:12] <tsimonq2> okay so
[03:12] <tsimonq2> basically, let's say a library package updates to a new version
[03:13] <arraybolt3[m]> Yep, looking at gitk, the changelog line you noticed is just gone. Never was in our repos AFAICT.
[03:13] <tsimonq2> all packages that depend on that library to build need to be rebuilt
[03:13] <tsimonq2> well I just pulled that straight from the archive
[03:13] <arraybolt3[m]> Oh, NCR meaning "no-change rebuild." I thought it was going to be a tool to keep this kind of junk from happening in the future.
[03:14] <Eickmeyer[m]> National Cash Register
[03:14] <tsimonq2> arraybolt3[m]: https://launchpad.net/ubuntu/+source/calamares/3.2.41.1-0ubuntu4 wuzzat then
[03:14] <arraybolt3[m]> Eickmeyer[m]: Neutrino-Counting Raspberry
[03:14] <tsimonq2> never fear `patch -p1 <` is here
[03:14] <arraybolt3[m]> tsimonq2: That is in the Ubuntu archives, but not in our Git.
[03:15] <tsimonq2> ah same page
[03:15] <arraybolt3[m]> I just pulled calamares-settings-ubuntu straight from the Lubuntu GitHub and worked off of that.
[03:15] <arraybolt3[m]> So I'm guessing in the future I need to pull from the Ubuntu archives proper, and sync our repo with that first?
[03:15] <tsimonq2> yes always
[03:16]  * arraybolt3[m] stuffs that new piece of info into the cranial repository for future reference, then goes and tears up all the calamares-settings-ubuntu work I did yesterday
[03:16] <arraybolt3[m]> (Actually, wait, git rebase -i might be the savior here, too.)
[03:17] <arraybolt3[m]> YES! My git-fu is starting to get better.
[03:22] <tsimonq2> `$ dput ssh-ubuntu **calamares_3.2.60-0ubuntu0.1_source.changes`
[03:22] <tsimonq2> s/**//
[03:22] -queuebot:#lubuntu-devel- Unapproved: calamares (jammy-proposed/universe) [3.2.41.1-0ubuntu4 => 3.2.60-0ubuntu0.1] (lubuntu, ubuntustudio)
[03:23] <Eickmeyer[m]> Heh, I always skip the "ssh-ubuntu" part, it just works.
[03:23] <arraybolt3[m]> Turns out there was no need to change anything in calamares-settings-ubuntu, the debdiff is telling me the only changes that were made were my changes.
[03:23] <arraybolt3[m]> (OK, I may have gotten a bit excited over that.)
[03:24] <arraybolt3[m]> Simon Quigley (Developer): And here's the calamares-settings-ubuntu fix, all SRU'd and ready for review. https://bugs.launchpad.net/ubuntu/jammy/+source/calamares-settings-ubuntu/+bug/1966774
[03:24] <ubot93> Launchpad bug 1966774 in calamares-settings-ubuntu (Ubuntu Jammy) "btrfs partioning with calamares results in unbootable system" [Medium, In Progress]
[03:25] <arraybolt3[m]> (And yes, I took Ubuntu Studio into account for that fix, too.)
[03:25] <Eickmeyer[m]> So arraybolt3 , Simon Quigley (Developer) 's upload will actually alert the SRU team to look at the SRU bug and the debdiff. Your part is done. \o/
[03:26] <arraybolt3[m]> Nice! Wow, that was so fun. Thank you guys for walking me through all that, and for letting me help!
[03:26] <Eickmeyer[m]> Actually, switch the bug status in Jammy to "In Progress" if it's not already.
[03:27] <arraybolt3[m]> Set the Calamares SRU to "In Progress".
[03:27] <tsimonq2> I have special powers there. Let me fix 'er up real quick once.
[03:27] <arraybolt3[m]> (The other one was set to "In Progress" already.)
[03:27] <tsimonq2> Ah, I see I already did it.
[03:28] <Eickmeyer[m]> I also have said special powers, I'm just lazy right now.
[03:28] <tsimonq2> Well, it was already fixed in Kinetic, yeah?
[03:28] <Eickmeyer[m]> Yeah, fixed in Kinetic since it was uploaded there, afaik.
[03:28] <arraybolt3[m]> Simon Quigley (Developer): Were you supposed to be the one who set Calamares to In Progress? Because I just did it... (Yes, both bugs were already fixed in Kinetic.)
[03:28] <tsimonq2> nah allg
[03:28] <tsimonq2> you got the version wrong :)
[03:28] <tsimonq2> what should the version be?
[03:28] <arraybolt3[m]> In which SRU?
[03:29] <tsimonq2> -settings
[03:30] <arraybolt3[m]> Simon Quigley (Developer): The closest line I can see in the Security Updates file is:
[03:30] <arraybolt3[m]> 2.0-2ubuntu2.1                2.0-2ubuntu2.2
[03:30] <arraybolt3[m]> And that's what I did.
[03:30] <arraybolt3[m]> So...?
[03:30] <tsimonq2> hint https://launchpad.net/ubuntu/+source/ubiquity%2Dslideshow%2Dubuntu
[03:31] <arraybolt3[m]> So it should have been 22.04.4.1
[03:31] <arraybolt3[m]> Not 22.04.5
[03:31] <lubot> [telegram] <teward001> *drags simon through the dirt for reasons*
[03:31] <tsimonq2> correct
[03:31] <arraybolt3[m]> Right?
[03:31] <tsimonq2> already fixed
[03:31] <arraybolt3[m]> Oh, OK, thank you.
[03:31]  * arraybolt3[m] hits @teward001 with five hundred tons of pure pet dander
[03:32]  * tsimonq2 kicks @teward001 with a croc and proceeds to throw 15,769 steel toe boots at his head
[03:32] <lubot> [telegram] <teward001> are you trying to kill me? (re @lubuntu_bot: (irc) <arraybolt3[m]> hits @teward001 with five hundred tons of pure pet dander)
[03:32] <tsimonq2> your vote @teward001? :P
[03:32] <lubot> [telegram] <teward001> because allergies + asthma + explosives == bad
[03:32] <lubot> [telegram] <teward001> *avoids the steel toe boots, extracts the steel plates, and melts them down to form a steel bar for resources he'll need later*
[03:32] <arraybolt3[m]> Oy, sorry, I didn't realize you had allergies, I was trying to be funny and dramatic at the same time.
[03:32] <lubot> [telegram] <teward001> no worries :)
[03:33] <tsimonq2> `$ dput ssh-ubuntu calamares-settings-ubuntu_22.04.4.1_source.changes`
[03:33]  * arraybolt3[m] throws @teward001 an adrenaline shot
[03:33] <lubot> [telegram] <teward001> *injects himself with pure caffeine instead*
[03:33] <arraybolt3[m]> (Actually, caffeine is a good anti-asthma treatment.)
[03:33] <lubot> [telegram] <teward001> aaaaaaanyways was just checking the activity here before heading off for MandatorySleepCycle so
[03:33] <lubot> [telegram] <teward001> see ya
[03:33] <arraybolt3[m]> (Or coffee is at least.)
[03:33] <arraybolt3[m]> @teward001: 👋
[03:33] <tsimonq2> make sure to crossfade with the morphine so you don't get a heart attack
[03:33] -queuebot:#lubuntu-devel- Unapproved: calamares-settings-ubuntu (jammy-proposed/universe) [1:22.04.4 => 1:22.04.4.1] (lubuntu, ubuntustudio)
[03:34] <lubot> [telegram] <teward001> depends on the severity.  does nothing against long-covid asthma-like respiratory symptoms leftover. (re @lubuntu_bot: (irc) <arraybolt3[m]> (Actually, caffeine is a good anti-asthma treatment.))
[03:34] <lubot> [telegram] <teward001> *offlines for sleep*
[03:34]  * Eickmeyer[m] imagines a fader crossfade because audio engineer
[03:35] <tsimonq2> nah duuuuuude partying 🤘
[03:35] <tsimonq2> although morphine isn't exactly a party drug
[03:35] <tsimonq2> anyway
[03:35] <tsimonq2> arraybolt3: got anything else to sponsor urgently?
[03:36] <arraybolt3[m]> PSA: Drugs will kill you and your brain. Don't use them. My dad did, and he's permanently damaged as a result. I've not done them ever, and now I'm able to help with Lubuntu SRUs.
[03:36] <arraybolt3[m]> (And I'm never going to do them, thank you.)
[03:36] <arraybolt3[m]> Simon Quigley (Developer): I don't think so. Pretty sure that's all we really need.
[03:37] <arraybolt3[m]> (It's a shame we missed the LibreOffice localization bug fix, but it changes a part of the configuration that's deep enough I didn't want to risk it - if even one Calamares-related SRU b0rks, it could be the end of them all.)
[03:38] <Eickmeyer[m]> Not really, arraybolt3 . If an SRU fails, you can always try again.
[03:39] <arraybolt3[m]> Right but if we're 5 days into the test process and then one of them causes a serious problem...
[03:39] <arraybolt3[m]> I'd hate for a failure in one to cause the SRU team to panic and cancel all of them if it becomes unclear which one's fault it is.
[03:39] <Eickmeyer[m]> Hopefully the test process on this doesn't take that long, otherwise we'll miss the .1 window.
[03:40] <arraybolt3[m]> I thought you had to do a week of testing, but it was OK since we had a week plus a couple of day's buffer.
[03:45] <Eickmeyer[m]> No, you only have to test once and mark as verification-done. The minimum 7 days begins as soon as the SRU is accepted and it is built in jammy-proposed.
[03:45] <arraybolt3[m]> But then if a regression hits in that 7-day window there's a problem right?
[03:46] <Eickmeyer[m]> No, if a regression hits after it's released to -updates there's a problem and phasing stops.
[03:46] <Eickmeyer[m]> But that doesn't apply to calamares since it's an installer.
[03:46] <arraybolt3[m]> Oh, OK. Then I might prep the LibreOffice fix tonight too.
[03:46] <arraybolt3[m]> (It's a fix in calamares-settings-ubuntu.)
[03:47] <Eickmeyer[m]> Only if Simon Quigley (Developer) has the heads-up too (I guess this would serve as said heads-up).
[03:57] <tsimonq2> What does the diff look like? What does the change do? What could break? Did you have to rewrite something? So many questions before I can give a definitive answer on anything.
[03:58] <tsimonq2> Perhaps I've been terribly out of the loop but this is one of the first times I've heard about this bug 
[04:01] <Eickmeyer[m]> arraybolt3: I'm foggy on the details too.
[04:27] <arraybolt3[m]> Simon Quigley (Developer): I've not done any of the work on the bug yet, but here's the link: https://bugs.launchpad.net/ubuntu/+source/calamares-settings-ubuntu/+bug/1970270
[04:27] <ubot93> Launchpad bug 1970270 in calamares-settings-ubuntu (Ubuntu Kinetic) "LibreOffice localization is not working out of the box" [High, Confirmed]
[04:27] <arraybolt3[m]> (I didn't know how to do patches properly when I first submitted the patch, so there's one in there that probably should be ignored.)
[04:34] <arraybolt3[m]> Eickmeyer: ^
[04:36] <tsimonq2> I need a patch that includes that change and the one already uploaded.
[04:36] <arraybolt3[m]> Shouldn't it be a separate SRU entirely?
[04:36] <tsimonq2> Preferably with the same version number and both changes, with mentions to both bugs 
[04:36] <tsimonq2> arraybolt3[m]: Do it both in one 
[04:36] <tsimonq2> If you're actively working on it I'll stay up to sponsor 
[04:36] <arraybolt3[m]> OK. Hold on, that will take me a while since I'll need to do two VM installs to make sure the fix works.
[04:36] <tsimonq2> Okay. Probably a few hours?
[04:37] <arraybolt3[m]> That's probably more than enough, but since things usually take longer than you'd think, I'll say a few hours is good.
[04:37] <tsimonq2> I'll be up in approx 6h anyway
[04:39] <arraybolt3[m]> The fix isn't in Kinetic, so I'll need to fix that, too (as per the SRU document I believe).
[04:41] <arraybolt3[m]> Simon Quigley (Developer): OK, should I give you the Jammy patch and then tackle Kinetic, or should I do Kinetic first and then tackle Jammy?
[04:42] <tsimonq2> I need both at the same time. Technically speaking, Kinetic first. The longer it takes the less time we have to test ;)
[04:42] <arraybolt3[m]> OK, that means four VM installs, I'll have them done ASAP.
[04:43] <tsimonq2> See you on the flipside
=== guiverc2 is now known as guiverc
[11:58]  * arraybolt3[m] posted a file: (1KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/srEXlcChqRRDTULUYsYnVlBI/localizefix-kinetic.diff >
[11:59]  * arraybolt3[m] posted a file: (3KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/JXAFCFCwDyLsbIjzHGoFHHoc/calamares-settings-ubuntu-fix-jammy.diff >
[11:59] <arraybolt3[m]> Simon Quigley (Developer): ^ Patches for calamares-settings-ubuntu
[12:31]  * arraybolt3[m] posted a file: libreoffice_localization_fix_sru (3KiB) < https://libera.ems.host/_matrix/media/r0/download/matrix.org/OKeVJIIwEhlCfzqqaVIjiijL >
[12:32] <arraybolt3[m]> Simon Quigley (Developer): ^ SRU paperwork for the LibreOffice localization bug
[12:36]  * arraybolt3[m] heads to bed, feel free to send any "oops this isn't right" messages to me while I'm afk and fix any problems, I'll read through the scrollback when I wake up.
[12:40] <arraybolt3[m]> (Note: In my testing, I have noticed a *very small* problem with the new Calamares - when installing in German, it keeps autoselecting "German (Austria)" rather than just "German" like the old version did, and I end up having to set it to "German" properly. Not sure if this is a bug or intended behavior, but it's very minor and I think we can overlook it.)
[12:40] <arraybolt3[m]> (This is when selecting the keyboard layout.)
[16:42] <Eickmeyer[m]> That bug sounds like a "feature" from one of the contributors, but is a bug nonetheless. I think we can overlook it, but I think I know exactly where it came from. I'm not about to talk about it publicly, however.
[23:26] <guiverc[m]> fyi: the SRU columns when added to the testing checklist make it too wide... I'll think on it & amend (likely in a few hours)