| didrocks | good morning | 05:37 |
|---|---|---|
| oSoMoN | good morning desktoppers | 06:08 |
| didrocks | salut oSoMoN | 06:12 |
| oSoMoN | salut didrocks | 06:12 |
| KGB-0 | system-config-printer ubuntu/jammy b18f13b Gunnar Hjalmarsson * pushed 9 commits (first 5 follow) * https://deb.li/G1H1 | 06:23 |
| KGB-0 | system-config-printer ubuntu/jammy 8a7ad9a Jeremy Bicha debian/patches/ series Allow-installing-non-free-drivers-from-OpenPrinting.patch Hide-Printers-app-in-GNOME-and-KDE.patch Rename-app-to-Printers.patch * Add remaining Ubuntu patches * https://deb.li/35g5N | 06:23 |
| KGB-0 | system-config-printer ubuntu/jammy 761a928 Jeremy Bicha debian/ control control.in gbp.conf * Update Maintainer and Vcs fields and debian/gbp.conf * https://deb.li/P3Qc | 06:24 |
| KGB-0 | system-config-printer ubuntu/jammy cae8ee3 Jeremy Bicha debian/changelog * releasing package system-config-printer version 1.5.15-1ubuntu1 * https://deb.li/3JP9y | 06:24 |
| KGB-0 | system-config-printer ubuntu/jammy e46e53e Jeremy Bicha debian/ (5 files in 2 dirs) * Merge tag 'debian/1.5.15-2' into ubuntu/master * https://deb.li/WYns | 06:24 |
| KGB-0 | system-config-printer ubuntu/jammy eab997d Jeremy Bicha debian/changelog * releasing package system-config-printer version 1.5.15-2ubuntu1 * https://deb.li/3FifU | 06:24 |
| KGB-0 | system-config-printer ubuntu/jammy 6e378ba Gunnar Hjalmarsson debian/rules * Fix syntax error in d/rules * https://deb.li/iUqXM | 06:40 |
| lissyx | oSoMoN, good, the cron is ready :) https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=symbols&selectedTaskRun=JuLzffjpSCeRHe-RczPocA.0 | 07:04 |
| duflu | Hi didrocks, oSoMoN, lissyx | 07:14 |
| === duflu_ is now known as duflu | ||
| didrocks | hey duflu | 07:50 |
| ricotz | good morning desktopers :) | 08:07 |
| alocer | morning all | 08:13 |
| duflu | Hi ricotz and alocer | 08:16 |
| seb128 | goood morning desltopers | 08:25 |
| seb128 | hey duflu ricotz alocer | 08:25 |
| duflu | Hi seb128 | 08:26 |
| didrocks | hey alocer, seb128 | 08:27 |
| seb128 | hey duflu, how is it going? | 08:33 |
| duflu | seb128, too much drama for one day but I am getting on top of it | 08:34 |
| duflu | How are you? | 08:35 |
| ricotz | duflu, seb128, didrocks, alocer, hello | 08:36 |
| seb128 | lut didrocks | 08:37 |
| seb128 | seems like IRC timeouted again :/ | 08:37 |
| lissyx | oSoMoN, finger crossed. | 09:45 |
| oSoMoN | lissyx, I'm seeing the same build failures for arm64 dbgsym-enabled builds on Launchpad :/ So if the patch to reduce the debug info is working for you, we'll probably need to apply it conditionnally depending on the architecture | 09:48 |
| lissyx | what are the limitations on launchpad? | 09:51 |
| lissyx | maybe you can raise some more easily? | 09:52 |
| lissyx | oSoMoN, build seems to be successfully finishing for me | 09:58 |
| lissyx | oSoMoN, I'm not so used to quilt, how can we apply arch-based? | 09:59 |
| oSoMoN | lissyx, quilt doesn't allow to apply patches conditionnally, so the condition has to be written in the patch itself | 10:01 |
| oSoMoN | lissyx, or, put the patch in a different place, and apply it conditionnally from snapcraft.yaml | 10:01 |
| lissyx | oSoMoN, what solution do you prefer? | 10:02 |
| lissyx | given that for now we would need to condition on GitHub Actions running, or on ARM64 builds, I tend to think we might want to deal with it at snapcraft.yaml level? | 10:03 |
| lissyx | I'm also verifying if it it safe to apply always ... | 10:03 |
| lissyx | (I was suggested that because it is what opensuse does, and according to their spec file, it seems they do unconditionnally? | 10:04 |
| oSoMoN | yes, doing it conditionally at the snapcraft.yaml level sounds fine | 10:07 |
| oSoMoN | we already do quite a lot of conditional work there anyway | 10:07 |
| lissyx | I've failed to be able to pass env var to snapcraft, do you know how I could detect a GitHub Actions build VS a Launchpad build? | 10:08 |
| === guiverc2 is now known as guiverc | ||
| oSoMoN | lissyx, according to https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#file-systems , there's $GITHUB_WORKSPACE and $GITHUB_EVENT_PATH that we could use to detect a github action run | 10:12 |
| lissyx | ok | 10:12 |
| lissyx | lunch time | 10:12 |
| lissyx | oSoMoN, but do we get those inside snapcraft.yaml? | 11:25 |
| lissyx | oSoMoN, updated my patch | 11:30 |
| lissyx | oSoMoN, testing: https://github.com/lissyx/firefox-snap/actions/runs/2739152389 | 11:32 |
| oSoMoN | lissyx, I would think that snapcraft doesn't strip the environment (but I might be wrong), so we should be seeing $GITHUB_WORKSPACE inside the build scriptlets | 11:55 |
| lissyx | oSoMoN, /bin/bash: line 53: GITHUB_WORKSPACE: unbound variable | 12:05 |
| lissyx | I'm going to rely on the symbols upload token file ... | 12:08 |
| ricotz | oSoMoN, is it possible that https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1951210 regressed? | 12:17 |
| ubottu | Launchpad bug 1951210 in libreoffice (Ubuntu Jammy) "libreoffice help doesn't open in firefox (404 error on file:///tmp/lu417531j7po.tmp/NewHelp0.html)" [Medium, Fix Released] | 12:17 |
| ricotz | oSoMoN, this isn't working anymore in a clean VM with snapd 2.56.2 and firefox 102.1.0 snap | 12:21 |
| lissyx | oSoMoN, weird | 12:55 |
| lissyx | oSoMoN, https://github.com/lissyx/firefox-snap/runs/7519781080?check_suite_focus=true#step:5:21435 | 12:55 |
| lissyx | oSoMoN, like it skipped the build ? | 12:55 |
| oSoMoN | lissyx, it looks like it stopped the build script after "patch -p1 patches/mozilla-reduce-rust-debuginfo.patch" | 13:11 |
| oSoMoN | maybe the patch didn't apply cleanly? | 13:11 |
| lissyx | there was no error reported | 13:12 |
| lissyx | oSoMoN, meh | 13:59 |
| lissyx | oSoMoN, "patch -p1 ..." | 13:59 |
| lissyx | like, it misses "<" ... | 13:59 |
| oSoMoN | heh | 14:01 |
| lissyx | oSoMoN, so the file is there: https://github.com/lissyx/firefox-snap/blob/debug-symbols_only_TESTS/patches/mozilla-reduce-rust-debuginfo.patch | 14:44 |
| lissyx | but it's not finding it? https://github.com/lissyx/firefox-snap/runs/7521824157?check_suite_focus=true#step:5:21357 | 14:45 |
| lissyx | relative vs abslute path maybe? | 14:46 |
| oSoMoN | lissyx, you'll need to prefix the path to the patch with $SNAPCRAFT_PROJECT_DIR/ | 14:46 |
| oSoMoN | because the build script is running relative to a different directory, not the project's root | 14:46 |
| lissyx | yeah | 14:54 |
| oSoMoN | ricotz, it looks like bug #1951210 regressed indeed | 14:56 |
| ubottu | Bug 1951210 in libreoffice (Ubuntu Jammy) "libreoffice help doesn't open in firefox (404 error on file:///tmp/lu417531j7po.tmp/NewHelp0.html)" [Medium, Fix Released] https://launchpad.net/bugs/1951210 | 14:56 |
| oSoMoN | a possible suspect: https://github.com/snapcore/snapd/commit/5abb3aab6b74db5a9e9920c537d673806603349a | 15:03 |
| ubottu | Commit 5abb3aa in snapcore/snapd "interfaces/system-packages-doc: allow read-only access to /usr/share/gtk-doc" | 15:03 |
| oSoMoN | jbicha, could it be that the changes you made to interfaces/builtin/system_packages_doc.go in that commit regressed RO access to /usr/share/libreoffice/help ? | 15:07 |
| oSoMoN | the removal of 'apparmor.GenWritableProfile(emit, "/usr/share/libreoffice/help", 3)' looks suspicious to me | 15:07 |
| oSoMoN | I've verified that /usr/share/libreoffice is mounted in the snap's namespace, but not its subdirectories | 15:09 |
| lissyx | oSoMoN, 1h28m still building, we might be on something :) | 16:16 |
| lissyx | oSoMoN, yallah! https://github.com/lissyx/firefox-snap/runs/7522784969?check_suite_focus=true#step:5:33874 | 18:07 |
| lissyx | oSoMoN, wrong token, so it's all good | 18:08 |
| lissyx | oSoMoN, I'm going to change the URL back to the prod server on my other PR | 18:08 |
| ricotz | oSoMoN, thanks for confirming | 19:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!