[07:08] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq opened [issue #2618](https://github.com/MirServer/mir/issues/2618): Newest swaybg missing an interface on Mir... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/67cc76066924bd94bf7d0a09a5c9ed0fab73b4c3)
[07:09] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq edited [issue #2618](https://github.com/MirServer/mir/issues/2618): Newest swaybg missing an interface on Mir
[07:54] <alan_g[m]> Oh, so that's why I lost my background on 22.10
[07:57] <Saviq> Electron on Wayland is plenty adventurous indeed...
[07:57] <Saviq> It... runs...
[09:09] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths closed [issue #2618](https://github.com/MirServer/mir/issues/2618): Newest swaybg missing an interface on Mir
[09:16] <Saviq> alan_g ah you're right, of course re: extensions. But still it doesn't draw the background, like you observed. May not be a Mir problem, though.
[09:52] <alan_g[m]> <Saviq> "alan_g ah you're right, of..." <- Well, it does work on Sway...
[10:16] <alan_g[m]> ...and the only striking difference I see in the behaviours is that (for reasons that escape me) sway issues a `wl_output.done` event after `zxdg_output_v103.done` and Mir doesn't.
[10:17] <alan_g[m]> s/zxdg_output_v103/zxdg_output_v1/
[10:18] <alan_g[m]> Actually, we're wrong:... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/af8e3a2f3be44c5f713ac2f0202e65ac1f4ad1e2)
[10:21] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths opened [issue #2619](https://github.com/MirServer/mir/issues/2619): zxdg_output_v1 version="3" implemented incorrectly... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/570320cc96ff2a41b56604ade478a3f695a9ae02)
[10:38] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths closed [issue #2619](https://github.com/MirServer/mir/issues/2619): zxdg_output_v1 version="3" implemented incorrectly
[10:41] <Saviq> This is happening so quickly :D
[10:42] <alan_g[m]> Well, it is easier to deal with issues that I can reproduce. ;P
[11:11] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths opened [issue #2620](https://github.com/MirServer/mir/issues/2620): Latest swaybg (on 22.10) doesn't paint on Mir... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/de21228dafb418fa3e5576e992cfac900f752089)
[11:13] <alan_g[m]> Saviq I know what swaybg is doing. And, if you're trying to use it, it is possibly why you saw those messages in your log
[12:47] <Saviq> And why Chris didn't.
[14:12] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths closed [pull request #2616](https://github.com/MirServer/mir/pull/2616): Avoid racy access to shm buffers
[14:22] -GitHub[m]:#mir-server- **[MirServer/mir]** AlanGriffiths drafted [pull request #2621](https://github.com/MirServer/mir/pull/2621): Bind shm textures when we create the buffers... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/67d9c0bef80791aa95fb98138e03820040fb6cc9)
[14:24] <alan_g[m]> Saviq another experiment to try ^ (it may also fix your transparent windows)
[16:15] <grayson-g[m]> Has anyone got an idea how to diagnose our generators *saying* that they're generating a file, but it not being created? I was having no trouble generating the files last week, but now I can't get the `logind-seat` and `logind-session` files to generate.
[16:17] <alan_g[m]> Are you sure that's what's happening?
[16:18] <alan_g[m]> What makes you say "the generators are saying they created the files"?
[16:18] <alan_g[m]> And what makes you say they are not?
[16:20] <grayson-g[m]> alan_g[m]: In the build output I see `Generating logind-session.c` (as well as the other files) but they don't appear anywhere at all within my Mir directory.
[16:21] <alan_g[m]> OK, I just ran a build of your branch and see: 
[16:21] <alan_g[m]> $ ls ./cmake-build-release/src/server/console/
[16:21] <alan_g[m]> CMakeFiles           CTestTestfile.cmake  logind-seat.h     logind-session.h
[16:21] <alan_g[m]> cmake_install.cmake  logind-seat.c        logind-session.c  Makefile
[16:21] <alan_g[m]> So the files are created for me
[16:24] <alan_g[m]> What's your build directory?
[16:24] <grayson-g[m]> > <@alan_g:matrix.org> OK, I just ran a build of your branch and see:... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/45ab553e01ecabc1d2c70bdf71bf8e06799edaa5)
[16:25] <grayson-g[m]> alan_g[m]: I have a `/build/` dir in my root Mir directory and I have been `cd`'ing into it and running `cmake ..` then `make`. And I have regenerated my CMake and completely deleted and remade `/build/` and it's not fixing the issue.
[16:26] <alan_g[m]> Does `build/src/server/console/` exist?
[16:27] <grayson-g[m]> alan_g[m]: Yes
[16:27] <alan_g[m]> What's in it?
[16:32] <grayson-g[m]> alan_g[m]: Wait a minute...I just freed up some space then rebuilt and now the files generated. Not sure if that was caused by me freeing space or if it was from running a hard reset to match your build exactly. Gonna make the changes I had and see if this persists.
[16:34] <alan_g[m]> 😎
[16:41] <alan_g[m]> grayson-g this fixes your build errors: https://github.com/MirServer/mir/pull/2611#issuecomment-1238398147
[17:02] <grayson-g[m]> <alan_g[m]> "grayson-g this fixes your..." <- It sure does! (Or it does when I modify the *correct* `CMakeLists.txt`)
[17:17] <grayson-g[m]> alan_g: Is it cleaner to go back and follow your directions for reverting the old commit or just continue with what I've already pushed (it all gets squashed, right?) I'm not sure if you made that suggestion after I fixed the commit (I didn't realize which file you were modifying.)
[17:19] <alan_g[m]> I'm not sure what the timing was. If you've replaced the commit that's fine. (And if you just copy the patch you won't change the wrong file)
[17:20] <grayson-g[m]> alan_g[m]: I appreciate the git tips because I sure need them.
[17:20] <alan_g[m]> "In future" that is
[17:21] <alan_g[m]> That type of habit is also why pairing would be useful
[17:22] <alan_g[m]> Anyway, it's past my EOD and my wife is complaining...
[17:22] <grayson-g[m]> alan_g[m]: Thanks again for your help! Take care.
[17:27] <Saviq> grayson-g FWIW we don't squash (in Mir, at least - we do in some smaller repos, though I'm not certain why :P), we merge, so history is preserved
[17:28] <Saviq> `git rebase -i main` is my best friend
[17:30] <Saviq> While in review/development, it's generally OK to modify commits (I commit fixes, then rebase to squash them with where they belong)
[17:30] <Saviq> GitHub records what changed in a force push, so that can always be referenced
[17:32] <Saviq> Rebasing on newer main is sometimes confusing, especially if you make changes along the way, as that makes it trickier to see what changed relevant to the PR
[17:33] <Saviq> Another handy tool is `tig`, allowing for visual browsing of history
[18:31] <Saviq> And now me o/
[21:08] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww drafted [pull request #2622](https://github.com/MirServer/mir/pull/2622): Verify serials for move/resize requests... (full message at https://libera.ems.host/_matrix/media/r0/download/libera.chat/d1b67bf7f4649a7b61ab310f59c7a8e7e85f36b0)
[21:09] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww marked [pull request #2622](https://github.com/MirServer/mir/pull/2622): Verify serials for move/resize requests as ready for review
[21:11] <sophie-w> Is there any way to make GH default to a normal PR, even if my last PR was a draft? This so annoying
[21:15] <Saviq> sophie-w: https://github.com/refined-github/refined-github/pull/2486 🤷
[21:22] <sophie-w> Cool! I'll give that a try
[23:03] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww opened [pull request #2623](https://github.com/MirServer/mir/pull/2623): Modernize touch events
[23:03] -GitHub[m]:#mir-server-  
[23:03] -GitHub[m]:#mir-server- > This renames `ContactState` to `TouchContact`, and versions it similar to how scroll axis is versioned. The old `ContactState` struct is kept around for ABI stability, and is aliased to `TouchContactV1`
[23:05] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww edited [pull request #2623](https://github.com/MirServer/mir/pull/2623): Modernize touch events