[01:33] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2649](https://github.com/MirServer/mir/pull/2649): CMake: Only run package-abis test if toplevel debian dir exists [01:33] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] closed [issue #2596](https://github.com/MirServer/mir/issues/2596): Tests always fail for non-Debian systems on package-abis due to missing debian/ dir [02:06] -GitHub[m]:#mir-server- **[MirServer/mir]** RAOF opened [pull request #2664](https://github.com/MirServer/mir/pull/2664): Server/run_mir: Fix build failure.... (full message at ) [02:21] -GitHub[m]:#mir-server- **[MirServer/mir]** RAOF opened [pull request #2665](https://github.com/MirServer/mir/pull/2665): mtd::MockInputSurface: Fix `consume` method signature... (full message at ) [05:08] Damn compiler bugs! [05:09] ๐Ÿ‘ฟ๐Ÿ”ฅ๐Ÿ˜ฎ๐Ÿ˜ค [05:49] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] closed [issue #2663](https://github.com/MirServer/mir/issues/2663): FTBFS: unused_result in run_mir.cpp [05:49] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2664](https://github.com/MirServer/mir/pull/2664): Server/run_mir: Fix build failure. [05:57] Saviq: Did you have a primary bug for the "gcc gives nonsensical warning with `-Werror=restrict` on std::string code~? [05:57] s/~?/?/ [05:58] Because I've stumbled upon a nice, pretty minimal test case. [06:01] Ah. Also, the reason why *everything* isn't on fire is apparently because it requires both `-std=c++20` *and* `-O3` [06:01] RAOF (he/they) I only had this https://bugs.launchpad.net/ubuntu/+source/gcc-12/+bug/1983852 [06:03] Right. That's a different g++-12 bug. [06:03] * RAOF thinks gcc 12 was not their finest release. [06:03] โ˜๏ธ๐Ÿ‘†๏ธโ˜๏ธ [06:07] For those playing at home, https://bugs.launchpad.net/ubuntu/+source/gcc-defaults/+bug/1990811 [06:09] Just in case this is some quirk of my setup, would you be able to download "small testcase" from that bug and try compiling it with `g++ -O3 -S --std=c++20 -o test.o gcc-bug-test.cpp -Wall -Werror`? [06:09] Confirmed [06:10] Shouldn't it be against the `gcc-12` package, though? [06:10] *source [06:14] Plausibly. [06:15] I just run `ubuntu-bug g++` [06:15] If foundations wanted bugs against g++ to go to the current source package, they'd have added an apport hook ๐Ÿค” [06:15] Ah yes, I did `ubuntu-bug g++-12`, as one of my tests was to try with 11 [06:43] -GitHub[m]:#mir-server- **[MirServer/mir]** RAOF opened [issue #2666](https://github.com/MirServer/mir/issues/2666): Possible bug in implementation of `xdg_output`... (full message at ) [07:45] UuuuuuUUUUrgh. [07:45] We should really have a surfaceless, software rasterised GL platform for our acceptance tests. [07:45] xvfb, you mean? ;) [07:46] I mean, that'd work fine. [07:48] But the acceptance tests fail locally because somehow they've managed to get the mock GL linked into them, and so `the_screenshooter()` results in calling a GL method without a current mock installed, generating a failure. [07:48] And than answer is to build with `ld`. [07:48] Well, that's not a good answer. [07:49] But that's the reason it doesn't fail in CI :) [07:49] No fast linkers for you! [07:49] :'-( [07:50] But it'd be nice if our tests didn't rely on the specific ordering `ld` chooses, vs `lld` or `mold`. [08:00] Urm. So yeah.... (full message at ) [08:00] FWIW it's reproducible locally with `-DCMAKE_BUILD_TYPE=RelWithDebInfo` [08:00] ๐Ÿ”ฅ [08:01] That is literally the recommended pattern for silencing that warning. [08:01] Ok, tomorrow I'll store it in a `#[maybe_unused]` variable! [08:01] For now, EOD. [08:41] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq opened [pull request #2667](https://github.com/MirServer/mir/pull/2667): server: fix unused variable [08:41] -GitHub[m]:#mir-server- [08:41] -GitHub[m]:#mir-server- > Fixes #2663 [09:23] -GitHub[m]:#mir-server- **[MirServer/ubuntu-frame]** Eldho1416 opened [issue #88](https://github.com/MirServer/ubuntu-frame/issues/88): ubuntu-frame fails to install in Jetson nano... (full message at ) [09:25] -GitHub[m]:#mir-server- **[MirServer/ubuntu-frame]** Eldho1416 edited [issue #88](https://github.com/MirServer/ubuntu-frame/issues/88): ubuntu-frame fails to install in Jetson nano [09:25] -GitHub[m]:#mir-server- **[MirServer/ubuntu-frame]** Eldho1416 edited [issue #88](https://github.com/MirServer/ubuntu-frame/issues/88): ubuntu-frame fails to install in Jetson nano [09:39] -GitHub[m]:#mir-server- **[MirServer/ubuntu-frame]** Saviq closed [issue #88](https://github.com/MirServer/ubuntu-frame/issues/88): ubuntu-frame fails to install in Jetson nano [09:39] -GitHub[m]:#mir-server- **[MirServer/ubuntu-frame]** Saviq closed [issue #88](https://github.com/MirServer/ubuntu-frame/issues/88): ubuntu-frame fails to install in Jetson nano [11:58] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2665](https://github.com/MirServer/mir/pull/2665): mtd::MockInputSurface: Fix `consume` method signature [11:58] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] closed [issue #2659](https://github.com/MirServer/mir/issues/2659): mock_input_surface.h: Mock method mistakenly fails to override base method [13:39] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added AlanGriffiths review needed to [issue #1981](https://github.com/MirServer/mir/issues/1981): Occasionally windows are misplaced partially offscreen (at top left) when created soon after Mir starts [13:39] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #1981](https://github.com/MirServer/mir/issues/1981): Occasionally windows are misplaced partially offscreen (at top left) when created soon after Mir starts [13:41] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #1984](https://github.com/MirServer/mir/issues/1984): When laptop lid is closed, Mir continues to use internal display [13:43] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #1992](https://github.com/MirServer/mir/issues/1992): Layer shell: respect -1 exclusive zone [13:47] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq closed [issue #2001](https://github.com/MirServer/mir/issues/2001): [Mir-on-X] Ctrl-Alt-[Left|Right] doesn't work [13:47] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2001](https://github.com/MirServer/mir/issues/2001): [Mir-on-X] Ctrl-Alt-[Left|Right] doesn't work [13:49] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug and removed Needs Info from [issue #2007](https://github.com/MirServer/mir/issues/2007): Surface visibility attribute not set to false when minimized [13:50] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #1975](https://github.com/MirServer/mir/issues/1975): BadBufferTest.test_truncated_shm_file fails intermittently with `unaligned tcache chunk detected` [14:04] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq closed [issue #2011](https://github.com/MirServer/mir/issues/2011): `stop_server() failed to stop server` in `mir_performance_tests` [14:10] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq closed [issue #2012](https://github.com/MirServer/mir/issues/2012): `C++ exception with description "Failed to start server thread" thrown in SetUp().` in `mir_performance_tests` [14:18] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added wmww review required to [issue #2013](https://github.com/MirServer/mir/issues/2013): X11 apps behave strangely when cursor moves outside initial output bounds [14:18] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq closed [issue #2013](https://github.com/MirServer/mir/issues/2013): X11 apps behave strangely when cursor moves outside initial output bounds [14:18] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2022](https://github.com/MirServer/mir/issues/2022): Over-eager triggering of snap rebuilds [14:18] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq edited [issue #2022](https://github.com/MirServer/mir/issues/2022): CI: Over-eager triggering of snap rebuilds [14:19] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq assigned Saviq to [issue #2022](https://github.com/MirServer/mir/issues/2022): CI: Over-eager triggering of snap rebuilds [14:27] I'm starting my day writing tests for #2646 but that'll likely be done before EOD. Should I get on https://github.com/MirServer/mir/issues/2651 if that wraps up? [14:28] * before EOD (considering my solution isn't all borked ๐Ÿ˜‰). Should [14:33] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2028](https://github.com/MirServer/mir/issues/2028): set_window_management_policy() captures arguments by reference [14:33] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2059](https://github.com/MirServer/mir/issues/2059): X11 platform's input device is not threadsafe [14:34] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added RAOF review needed to [issue #2062](https://github.com/MirServer/mir/issues/2062): [eglstream-kms] Exception in Surface::commit() when X windows are appearing and disappearing [14:37] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq assigned AlanGriffiths to [issue #2136](https://github.com/MirServer/mir/issues/2136): Wayland frontend and server hang rendering threads when the screen turns off [14:37] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq unassigned AlanGriffiths from [issue #2136](https://github.com/MirServer/mir/issues/2136): Wayland frontend and server hang rendering threads when the screen turns off [14:37] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added AlanGriffiths review needed to [issue #2136](https://github.com/MirServer/mir/issues/2136): Wayland frontend and server hang rendering threads when the screen turns off [14:47] "I'm starting my day writing..." <- Hey! I don't think it's clear what the solution there is. sophie may have an idea, but IIUC it would require tracking which surface interacts with the input manager, and issuing a disable()+commit() in its name on unfocus (and possibly track whether the app did it on its own). But then you need to enable() again on focusโ€ฆ so you'd need to track whether the app DTRT and act accordingly [14:48] But that feels like abuse to me. [14:50] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2145](https://github.com/MirServer/mir/issues/2145): Support virtual keyboard modifiers [14:50] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added wmww review required to [issue #2145](https://github.com/MirServer/mir/issues/2145): Support virtual keyboard modifiers [14:51] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug and AlanGriffiths review needed to [issue #2148](https://github.com/MirServer/mir/issues/2148): WindowManager::add_display()/remove_display() [14:55] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2164](https://github.com/MirServer/mir/issues/2164): No way for frontend to change non-active window state [14:58] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added RFC to [issue #2173](https://github.com/MirServer/mir/issues/2173): Excessive memory leaked on exit [15:04] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq closed [issue #2198](https://github.com/MirServer/mir/issues/2198): [Mir on X] Resized window not reported to clients [15:04] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2209](https://github.com/MirServer/mir/issues/2209): MirAL extension filter invoked multiple times for the same app and same protocol [15:05] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added wmww review required to [issue #2240](https://github.com/MirServer/mir/issues/2240): Interacting with server-side decorations does not dismiss popups [15:06] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2255](https://github.com/MirServer/mir/issues/2255): [Xwayland] weird focus problems with CLion [15:06] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2256](https://github.com/MirServer/mir/issues/2256): More focus madness [15:15] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2258](https://github.com/MirServer/mir/issues/2258): [gbm-kms] Probing detects unusable Nvidia driver as "PlatformPriority::best" [15:16] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added RAOF review needed to [issue #2258](https://github.com/MirServer/mir/issues/2258): [gbm-kms] Probing detects unusable Nvidia driver as "PlatformPriority::best" [15:17] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added Good first issue and bug to [issue #2264](https://github.com/MirServer/mir/issues/2264): mirtest - no longer publishes test_wlcs_display_server.h [15:17] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added Good first issue and enhancement to [issue #2288](https://github.com/MirServer/mir/issues/2288): Driver probe should check for presence of Wayland extension [15:19] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2309](https://github.com/MirServer/mir/issues/2309): Nonblocking Wayland executor [15:20] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2325](https://github.com/MirServer/mir/issues/2325): [miral-shell] Tiling sometimes fails to resize window when becoming focussed [15:21] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2326](https://github.com/MirServer/mir/issues/2326): [XWayland] CLion popup window is transparent to input [15:21] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added RAOF review needed to [issue #2344](https://github.com/MirServer/mir/issues/2344): miral-shell hangs on shutdown if eglspinner internal client errors [15:21] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added documentation to [issue #2365](https://github.com/MirServer/mir/issues/2365): Generated docs contain blank namespaces [15:21] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added Good first issue to [issue #2365](https://github.com/MirServer/mir/issues/2365): Generated docs contain blank namespaces [15:29] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2401](https://github.com/MirServer/mir/issues/2401): Intermittent in CI: MultiThreadedCompositor.can_schedule_from_display_observer_when_adding_display [15:29] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2403](https://github.com/MirServer/mir/issues/2403): Intermittent WLCS failure: Failed to create Wayland client socket [15:29] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2425](https://github.com/MirServer/mir/issues/2425): mir_unit_tests.MultiplexingDispatchableTest unstable [15:29] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2445](https://github.com/MirServer/mir/issues/2445): [eglstream] Update wayland-eglstream-controller.xml [15:30] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2452](https://github.com/MirServer/mir/issues/2452): Using non-`ld` linker results in broken tests [15:30] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2456](https://github.com/MirServer/mir/issues/2456): X11 platform display configuration racy [15:31] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added RFC to [issue #2462](https://github.com/MirServer/mir/issues/2462): Snapped, nested on Nvidia/eglstream doesn't work [15:31] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added Saviq review needed to [issue #2476](https://github.com/MirServer/mir/issues/2476): Compositor average FPS reported exceeds that of screen refresh on a Pi [15:32] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2480](https://github.com/MirServer/mir/issues/2480): Surface damage notifications do not cover all cases [15:32] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added Saviq review needed to [issue #2501](https://github.com/MirServer/mir/issues/2501): Inclusive language problems [15:40] I'm a bit confused about how to use a mocked `MainLoop` into `tests/miral/runner.h` [15:40] Objective: Test that when an `FdHandle` is released, `GLibMainLoop::unregister_fd_handler()` is successfully called. [15:40] Problem: All of the tests based on `TestDisplayServer` use a real `MirRunner` and not a mock. [15:41] s/into/in/ [15:45] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2502](https://github.com/MirServer/mir/issues/2502): TestWlcsDisplayServer has a copy of mir::Synrchonised [15:51] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2515](https://github.com/MirServer/mir/issues/2515): Dynamic configuration: display brightness [15:52] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq closed [issue #2527](https://github.com/MirServer/mir/issues/2527): Build failure on Launchpad for arm64 at 22.10 [15:52] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2534](https://github.com/MirServer/mir/issues/2534): Change from MAP_SHARED to MAP_PRIVATE in our clients [15:53] grayson-g there's a "Looking into thisโ€ฆ" from you here ๐Ÿ‘†๏ธ [15:53] > <@grayson-g:matrix.org> I'm a bit confused about how to use a mocked `MainLoop` in `tests/miral/runner.h`... (full message at ) [15:54] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq assigned graysonguarino to [issue #2534](https://github.com/MirServer/mir/issues/2534): Change from MAP_SHARED to MAP_PRIVATE in our clients [15:54] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2536](https://github.com/MirServer/mir/issues/2536): miral::ExternalClientLauncher::launch() returns a pid_t [15:55] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added RFC to [issue #2536](https://github.com/MirServer/mir/issues/2536): miral::ExternalClientLauncher::launch() returns a pid_t [15:55] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added enhancement to [issue #2543](https://github.com/MirServer/mir/issues/2543): miral does not expose wait features based on MainLoop [15:55] Saviq: No worries! I'm playing around with Frame's crash screen delay with this addition to Miral and `timerfd` to at least manually test that this all works. [15:55] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq closed [issue #1710](https://github.com/MirServer/mir/issues/1710): HostedGL2MarkWayland.* tests fail on Nvidia [15:56] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added Saviq review needed to [issue #2375](https://github.com/MirServer/mir/issues/2375): Tests failing on focal/riscv64 [15:56] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq added bug to [issue #2573](https://github.com/MirServer/mir/issues/2573): Deadlock while resizing Mir-on-X [15:57] -GitHub[m]:#mir-server- **[MirServer/mir]** Saviq assigned wmww to [issue #2573](https://github.com/MirServer/mir/issues/2573): Deadlock while resizing Mir-on-X [17:28] @[grayson-g] still have questions? Or want to hop on a call? [20:47] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] merged [pull request #2667](https://github.com/MirServer/mir/pull/2667): server: fix unused variable [20:47] -GitHub[m]:#mir-server- **[MirServer/mir]** bors[bot] closed [issue #2663](https://github.com/MirServer/mir/issues/2663): FTBFS: unused_result in run_mir.cpp [23:55] -GitHub[m]:#mir-server- **[MirServer/mir]** wmww opened [pull request #2668](https://github.com/MirServer/mir/pull/2668): Support scaled screenshots [23:55] -GitHub[m]:#mir-server- [23:55] -GitHub[m]:#mir-server- > Fixes #2653, a few systems needed to be refactored. With this PR software buffers now expose their properties without being mapped, render targets expose their size so the renderer doesn't have to query the current EGL surface (something that never worked for screenshots), and our wlr-screencopy implementation requests clients use buffers of the full output resolution rather than the logical size. [23:57] -GitHub[m]:#mir-server- **[MirServer/mir]** RAOF opened [issue #2669](https://github.com/MirServer/mir/issues/2669): buffer_from_wl_shm is unnecessarily complex... (full message at ) [23:57] -GitHub[m]:#mir-server- **[MirServer/mir]** RAOF added enhancement to [issue #2669](https://github.com/MirServer/mir/issues/2669): buffer_from_wl_shm is unnecessarily complex