| === Kuraokami is now known as IchabodCrane | ||
| andrew3 | Hi, I'm trying to use `sensitive_keys` in my cloud-init metadata to redact an access token, but I haven't figured it out yet. My access token is still visible/unredacted in the /run/cloud-init/instance-data.json file. | 03:11 |
|---|---|---|
| andrew3 | Terraform exerpt: https://hastebin.com/raw/mizepubata | 03:11 |
| andrew3 | Just curious if I'm using it wrong? Still working my way through the code. | 03:11 |
| andrew3 | I figured something out that works in the end | 03:40 |
| andrew3 | https://hastebin.com/raw/pacivapoti | 03:40 |
| andrew3 | The security-credentials (sub)key is redacted by default | 03:40 |
| === janitha71 is now known as janitha7 | ||
| === janitha71 is now known as janitha7 | ||
| meena | i can only find two references to credentials, https://cloudinit.readthedocs.io/en/latest/search.html?q=credentials&check_keywords=yes&area=default and they don't look anything like that | 07:14 |
| === janitha73 is now known as janitha7 | ||
| === janitha79 is now known as janitha7 | ||
| meena | has anyone survived the yesterday's holiday? | 18:14 |
| minimal | meena: what holiday? I guess I missed it ;-) | 18:35 |
| meena | minimal: there was a holiday in the US yesterday, which was the reason there was so little activity here | 18:41 |
| minimal | ah ok | 18:41 |
| minimal | I assume there's likely to be a holiday on any day of the year in some country :-) | 18:41 |
| falcojr | heh...most of us are back now | 19:59 |
| meena | converted https://github.com/canonical/cloud-init/pull/1779 to draft | 20:34 |
| -ubottu:#cloud-init- Pull 1779 in canonical/cloud-init "Net: add BSD ifconfig(8) parser" [Open] | 20:34 | |
| meena | but https://github.com/canonical/cloud-init/pull/1759 is very much ready, if someone needs something to do | 20:34 |
| -ubottu:#cloud-init- Pull 1759 in canonical/cloud-init "cc_ntp: add support for BSDs" [Open] | 20:34 | |
| falcojr | I can finish reviewing that one | 20:35 |
| falcojr | meena: re ifconfig, is there anything you can borrow from the netinfo stuff? | 20:36 |
| falcojr | I just remember seeing ifconfig parsing in netinfo.py | 20:36 |
| meena | falcojr: oh, i did, loads | 20:39 |
| meena | that's how I got started | 20:39 |
| meena | but, the netinfo one is, needlessly split into two | 20:39 |
| meena | didn't wanna do that | 20:39 |
| minimal | falcojr: if/when you review and merge 1759 then I can submit a related PR for Alpine | 20:40 |
| meena | minimal: you could already do that, following this pattern: https://github.com/canonical/cloud-init/pull/1778 | 20:41 |
| -ubottu:#cloud-init- Pull 1778 in canonical/cloud-init "Ansible Control Module" [Open] | 20:41 | |
| falcojr | meena: I commented on 1759. I'm not sure why the indirect module changes | 21:18 |
| meena | falcojr: if you scroll back, that's all rharper's finding | 21:24 |
| meena | falcojr: we had mysterious test failures, which rharper traced down | 21:25 |
| meena | falcojr: https://github.com/canonical/cloud-init/pull/1759/commits/f9c8f722ae3b6cbfd6ac31cfa738fe9668d31a5f | 21:25 |
| -ubottu:#cloud-init- Pull 1759 in canonical/cloud-init "cc_ntp: add support for BSDs" [Open] | 21:25 | |
| falcojr | I'd rather we fix our mocks... | 21:31 |
| meena | falcojr: we capitulated before the mocks | 21:32 |
| meena | falcojr: if you can do better, that would be cool, but right now, other distros can't test their manage_service() functions | 21:33 |
| meena | (that includes alpine, so it's not just BSDs ;) | 21:33 |
| * meena needs to build a cloud-init for openbsd | 21:38 | |
| falcojr | meena: which test(s) were failing? | 21:46 |
| meena | falcojr: essentially, the whole_package test was failing, but i don't know what else was failing | 21:48 |
| meena | falcojr: you can back out the change and test it again | 21:49 |
| meena | i dunno if rharper has record of what was failing | 21:49 |
| minimal | falcojr: what I was seeing failing was the ntp | 22:03 |
| minimal | oops, test_ntp_the_whole_package once I implemented a manage_services function in distros/alpine.py | 22:04 |
| * meena might have to give up earlier tonight… | 22:05 | |
| minimal | basically that test was then failing for alpine as it was running "systemctl" rather than "rc-service" as the mock for determining that Alpine was non-systemd wasn't working | 22:06 |
| meena | i wouldn't say that | 22:06 |
| meena | when you looked at the state, uses_systemd was correctly returning false | 22:07 |
| meena | that mock worked fine, as it was freshly overwritten | 22:07 |
| meena | but the distro mock object wasn't entirely … clean, shall we say | 22:07 |
| meena | which is why rharper added m_dsubp.reset_mock() | 22:08 |
| meena | but that wasn't enough, either | 22:08 |
| falcojr | lol...just now realized the_whole_package means a test named that...not literally testing the entire package XD | 22:09 |
| meena | test_everything_and_the_kitchen_sink() | 22:09 |
| * meena → bed | 22:23 | |
| meena | (no more code) | 22:23 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!