holmanblol, thanks for the review meena :)02:15
minimalholmanb: I'd explains to meena how that cc_disk_setup function magic worked about a month or 2 ago lol02:20
holmanbHopefully now we won't need to explain it to anyone else02:39
meenaholmanb: I was looking at one of the functions, locally, and my first instinct was that the dynamic dispatch function was a python standard library function I didn't know about09:31
=== esv_ is now known as esv
holmanbmeena: +115:11
minimalholmanb: just realised I forgot to remove the "WIP:" subject from my Certs PR, I'll do that now. Could you find some time to review it as it is ready to go?15:30
holmanbminimal: sounds good, will do15:36
minimalholmanb: thanks for the review. I'd thought about providing a means to optionally name the stored certs' filenames but wasn't sure how to define this in the user-data in a backward compatible fashion. That's something for another possible future PR I think19:48
holmanb+1 agreed, I don't think that's necessary19:52
holmanberrr, actually zero padding the cert name isn't necessary, is it? If not I guess I'd prefer dropping the zero padding so we don't add a new requirement19:58
minimalholmanb: the zero padding was so that filenames would appear in numerical order, i.e. 1, 2, 3,...10, ...20 rather than 1, 10, 2, 20, 3, 420:03
minimalwhen using the likes of "ls" I mean20:03
holmanbI figured, but that's just for convenience, right?20:05
minimalok, will remove it20:06
meenaheya, I'm planning on working on https://bugs.launchpad.net/cloud-init/+bug/1884609 and https://bugs.launchpad.net/cloud-init/+bug/1884610 in the same PR; any objections?21:00
-ubottu:#cloud-init- Launchpad bug 1884609 in cloud-init "cloudinit.net refactor: get_ib_hwaddrs_by_interface" [Wishlist, In Progress]21:00
-ubottu:#cloud-init- Launchpad bug 1884610 in cloud-init "cloudinit.net refactor: get_ib_interface_hwaddr" [Wishlist, In Progress]21:00
blackboxswmeena: yes please21:00
blackboxswthx for the heads up21:00
blackboxswthose bugs live in the same scope so +121:01
blackboxswin our commit message we just put the footer LP: #ID1  #ID221:01
meenablackboxsw: aye21:03
meenaand they're both the same kind of mess, which mostly seems to used on OpenStack, so it'll have a relatively small blast-radius, i hopeā€¦21:04
meenathe main problem is going to be cloudinit.net.get_interfaces_by_mac_on_linux()21:05
meenawhich is a complete mess of its own21:05
meenainteresting: https://jcalderone.livejournal.com/32837.html !21:09
=== falcojr_ is now known as falcojr

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!