| holmanb | lol, thanks for the review meena :) | 02:15 |
|---|---|---|
| minimal | holmanb: I'd explains to meena how that cc_disk_setup function magic worked about a month or 2 ago lol | 02:20 |
| holmanb | Nice | 02:39 |
| holmanb | Hopefully now we won't need to explain it to anyone else | 02:39 |
| meena | holmanb: I was looking at one of the functions, locally, and my first instinct was that the dynamic dispatch function was a python standard library function I didn't know about | 09:31 |
| === esv_ is now known as esv | ||
| holmanb | meena: +1 | 15:11 |
| minimal | holmanb: just realised I forgot to remove the "WIP:" subject from my Certs PR, I'll do that now. Could you find some time to review it as it is ready to go? | 15:30 |
| holmanb | minimal: sounds good, will do | 15:36 |
| minimal | holmanb: thanks for the review. I'd thought about providing a means to optionally name the stored certs' filenames but wasn't sure how to define this in the user-data in a backward compatible fashion. That's something for another possible future PR I think | 19:48 |
| holmanb | +1 agreed, I don't think that's necessary | 19:52 |
| holmanb | errr, actually zero padding the cert name isn't necessary, is it? If not I guess I'd prefer dropping the zero padding so we don't add a new requirement | 19:58 |
| minimal | holmanb: the zero padding was so that filenames would appear in numerical order, i.e. 1, 2, 3,...10, ...20 rather than 1, 10, 2, 20, 3, 4 | 20:03 |
| minimal | when using the likes of "ls" I mean | 20:03 |
| holmanb | I figured, but that's just for convenience, right? | 20:05 |
| minimal | yeah | 20:05 |
| minimal | ok, will remove it | 20:06 |
| holmanb | thx | 20:07 |
| meena | heya, I'm planning on working on https://bugs.launchpad.net/cloud-init/+bug/1884609 and https://bugs.launchpad.net/cloud-init/+bug/1884610 in the same PR; any objections? | 21:00 |
| -ubottu:#cloud-init- Launchpad bug 1884609 in cloud-init "cloudinit.net refactor: get_ib_hwaddrs_by_interface" [Wishlist, In Progress] | 21:00 | |
| -ubottu:#cloud-init- Launchpad bug 1884610 in cloud-init "cloudinit.net refactor: get_ib_interface_hwaddr" [Wishlist, In Progress] | 21:00 | |
| blackboxsw | meena: yes please | 21:00 |
| blackboxsw | thx for the heads up | 21:00 |
| blackboxsw | those bugs live in the same scope so +1 | 21:01 |
| blackboxsw | in our commit message we just put the footer LP: #ID1 #ID2 | 21:01 |
| meena | blackboxsw: aye | 21:03 |
| meena | and they're both the same kind of mess, which mostly seems to used on OpenStack, so it'll have a relatively small blast-radius, i hope… | 21:04 |
| meena | the main problem is going to be cloudinit.net.get_interfaces_by_mac_on_linux() | 21:05 |
| meena | which is a complete mess of its own | 21:05 |
| meena | interesting: https://jcalderone.livejournal.com/32837.html ! | 21:09 |
| === falcojr_ is now known as falcojr | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!