[02:15] lol, thanks for the review meena :) [02:20] holmanb: I'd explains to meena how that cc_disk_setup function magic worked about a month or 2 ago lol [02:39] Nice [02:39] Hopefully now we won't need to explain it to anyone else [09:31] holmanb: I was looking at one of the functions, locally, and my first instinct was that the dynamic dispatch function was a python standard library function I didn't know about === esv_ is now known as esv [15:11] meena: +1 [15:30] holmanb: just realised I forgot to remove the "WIP:" subject from my Certs PR, I'll do that now. Could you find some time to review it as it is ready to go? [15:36] minimal: sounds good, will do [19:48] holmanb: thanks for the review. I'd thought about providing a means to optionally name the stored certs' filenames but wasn't sure how to define this in the user-data in a backward compatible fashion. That's something for another possible future PR I think [19:52] +1 agreed, I don't think that's necessary [19:58] errr, actually zero padding the cert name isn't necessary, is it? If not I guess I'd prefer dropping the zero padding so we don't add a new requirement [20:03] holmanb: the zero padding was so that filenames would appear in numerical order, i.e. 1, 2, 3,...10, ...20 rather than 1, 10, 2, 20, 3, 4 [20:03] when using the likes of "ls" I mean [20:05] I figured, but that's just for convenience, right? [20:05] yeah [20:06] ok, will remove it [20:07] thx [21:00] heya, I'm planning on working on https://bugs.launchpad.net/cloud-init/+bug/1884609 and https://bugs.launchpad.net/cloud-init/+bug/1884610 in the same PR; any objections? [21:00] -ubottu:#cloud-init- Launchpad bug 1884609 in cloud-init "cloudinit.net refactor: get_ib_hwaddrs_by_interface" [Wishlist, In Progress] [21:00] -ubottu:#cloud-init- Launchpad bug 1884610 in cloud-init "cloudinit.net refactor: get_ib_interface_hwaddr" [Wishlist, In Progress] [21:00] meena: yes please [21:00] thx for the heads up [21:01] those bugs live in the same scope so +1 [21:01] in our commit message we just put the footer LP: #ID1 #ID2 [21:03] blackboxsw: aye [21:04] and they're both the same kind of mess, which mostly seems to used on OpenStack, so it'll have a relatively small blast-radius, i hopeā€¦ [21:05] the main problem is going to be cloudinit.net.get_interfaces_by_mac_on_linux() [21:05] which is a complete mess of its own [21:09] interesting: https://jcalderone.livejournal.com/32837.html ! === falcojr_ is now known as falcojr