| caribou | holmanb: hello, I just read your comment on https://github.com/canonical/cloud-init/pull/2033. When you say "adding to the comment" you mean to the git commit log ? | 15:34 |
|---|---|---|
| -ubottu:#cloud-init- Pull 2033 in canonical/cloud-init "Adapt DataSourceScaleway to IPv6" [Open] | 15:34 | |
| holmanb | caribou: hello o/ commit message would be fine, but I think commenting in the code would be better to help someone reading the code to understand why it is the way that it is | 15:38 |
| caribou | I'm fine with that, I'll fix that up | 15:38 |
| holmanb | thanks! | 15:40 |
| holmanb | also fyi removing the unused keyword in b2220798c0852cae2e created a conflict | 15:40 |
| holmanb | with your branch | 15:40 |
| caribou | holmanb: not sure what you mean about the conflict, sorry | 15:50 |
| caribou | ok, nevermind I found it | 15:57 |
| === nico1 is now known as thoht | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!