sarnoldideally, with some upstream attention on valgrind or -fsanitize=address or coverity or something, to spot more cases like these00:00
-queuebot:#ubuntu-release- New binary: ffcv [amd64] (lunar-proposed/none) [0.0.3-2build1] (no packageset)00:14
-queuebot:#ubuntu-release- New binary: ffcv [arm64] (lunar-proposed/none) [0.0.3-2build1] (no packageset)00:16
-queuebot:#ubuntu-release- New binary: ffcv [ppc64el] (lunar-proposed/none) [0.0.3-2build1] (no packageset)00:16
-queuebot:#ubuntu-release- New binary: ffcv [armhf] (lunar-proposed/none) [0.0.3-2build1] (no packageset)00:16
-queuebot:#ubuntu-release- New binary: ffcv [s390x] (lunar-proposed/none) [0.0.3-2build1] (no packageset)00:18
-queuebot:#ubuntu-release- Unapproved: nextepc (lunar-proposed/universe) [0.3.10+nods-4.2 => 0.3.10+nods-4.2ubuntu1] (no packageset)00:33
-queuebot:#ubuntu-release- Unapproved: accepted nextepc [source] (lunar-proposed) [0.3.10+nods-4.2ubuntu1]00:34
-queuebot:#ubuntu-release- New: accepted ffcv [amd64] (lunar-proposed) [0.0.3-2build1]00:44
-queuebot:#ubuntu-release- New: accepted ffcv [armhf] (lunar-proposed) [0.0.3-2build1]00:44
-queuebot:#ubuntu-release- New: accepted ffcv [arm64] (lunar-proposed) [0.0.3-2build1]00:44
-queuebot:#ubuntu-release- New: accepted ffcv [ppc64el] (lunar-proposed) [0.0.3-2build1]00:44
-queuebot:#ubuntu-release- New: accepted ffcv [s390x] (lunar-proposed) [0.0.3-2build1]00:45
vorlonfyi snakefruit has been turned off.  As far as we know everything has been migrated to the new instance but if anyone sees anything not working, please ping00:47
athosHi! I am about to push a new bug-fix version of ubuntu-advantage-tools. lucasmoura will probably mention additional details for a beta freeze exception request on this one :)00:55
lucasmourayes, we have created this bug to detail the whole reason why thig bug should be a BetaFreezeException: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/201273500:56
-ubottu:#ubuntu-release- Launchpad bug 2012735 in ubuntu-advantage-tools (Ubuntu) "update-manager crashed with uaclient.exceptions.UserFacingError in get_lscpu_arch()" [Critical, New]00:56
lucasmouraPlease let me know if there is any additional detail that I need to provide regarding this release00:56
vorlon"we believe the dpkg command is stable enough" um lol it better be00:57
vorlonlucasmoura, athos: beta freeze exception means you believe the user impact is so critical that it's worth potentially delaying the beta release over; I want to make sure that assessment is correct00:58
lucasmouravorlon, currently, ubuntu-advantage-tools is breaking update-manager on any release that is using a non-english locale. Since we are pushing this fix during beta freeze, that's why we thought the Beta Freeze Exception was needed01:00
vorlonany non-english locale is sufficient for me01:00
vorlonjust wanted to check that this was the scope, since it didn't immediately look like a recent regression01:01
vorlonlucasmoura, athos: upload ASAP so I can review it in the queue, please01:01
vorlonah but in fact, it's a regression from the immediately preceding version, so01:02
vorloncan we PLEASE lose these ~23.04 decorations on version numbers01:02
lucasmouraYep, we have actually discussed about dropping those. We can remove it for the next release01:03
athosvorlon: ^ is this acceptable for this beta freeze?01:04
vorlon<vorlon> any non-english locale is sufficient for me01:04
athosI meant keeping the ~23.04 for this specific upload as suggested by lucasmoura01:05
vorlonathos: yes, as much as I hate it and as easy as I think it ought to be to change I'm not blocking you on version numbers being ugly01:05
vorlonkanashiro_: why is ruby-rackup in unstable if ruby-rack 3.0 is in experimental?01:06
-queuebot:#ubuntu-release- Unapproved: ubuntu-advantage-tools (focal-proposed/main) [27.13.6~20.04.1 => 27.14.2~20.04.1] (core)01:19
-queuebot:#ubuntu-release- Unapproved: ubuntu-advantage-tools (kinetic-proposed/main) [27.13.6~22.10.1 => 27.14.2~22.10.1] (core)01:19
-queuebot:#ubuntu-release- Unapproved: ubuntu-advantage-tools (jammy-proposed/main) [27.13.6~22.04.1 => 27.14.2~22.04.1] (core)01:19
-queuebot:#ubuntu-release- Unapproved: ubuntu-advantage-tools (lunar-proposed/main) [27.14.1~23.04.1 => 27.14.2~23.04.1] (core)01:19
-queuebot:#ubuntu-release- Unapproved: ubuntu-advantage-tools (bionic-proposed/main) [27.13.6~18.04.1 => 27.14.2~18.04.1] (core)01:19
-queuebot:#ubuntu-release- Unapproved: ubuntu-advantage-tools (xenial-proposed/main) [27.13.6~16.04.1 => 27.14.2~16.04.1] (no packageset)01:19
kanashiro[m]vorlon: ruby-rackup in unstable was a mistake. It should have gone to experimental01:19
vorlonkanashiro[m]: fair enough. ruby-rack-session also?01:20
vorlonathos: lucasmoura: so does that run of notifications mean this bug is believed to break update-manager in all series?01:20
lucasmourayes, it will. But 27.14.1 is not yet released on the other releases01:21
athosvorlon: it would with the current pending uploads in those series01:21
vorlonathos, lucasmoura: so there are some corner cases here, that are in no way supported configurations and I don't believe we have to care about them, but I wonder - is there a reason you weren't using the output of `uname -m` for this in the first place?01:33
lucasmouraWe were using lscpu here because Livepatch was also using it to fetch architecture information01:35
lucasmouraAnd we wanted it to be consistent01:35
Trevinho<arraybolt3> "If there are too many problems..." <- None... I think it's better to handle the issues, that were just been ignored or hidden before but for sure were still causing some crashes hard to reproduce01:35
-queuebot:#ubuntu-release- Unapproved: accepted ubuntu-advantage-tools [source] (lunar-proposed) [27.14.2~23.04.1]01:35
vorlonlucasmoura: ok well that's a weird interface for them to have been using too01:36
lucasmouraBut if the question is related to why we are using dpkg --print-architecture instead of uname, I think the decision was made here: https://github.com/canonical/ubuntu-pro-client/issues/91401:37
-ubottu:#ubuntu-release- Issue 914 in canonical/ubuntu-pro-client "Do not use `uname` to determine architecture" [Closed]01:37
lucasmouravorlon, yes I think one of member of the Pro client team has opened an issue on Livepatch we found out about that issue01:37
lucasmouraI will confirm that tomorrow once he is working again01:38
vorlonright.  So the thing I'm thinking of is that it is entirely possible to be running an armhf userspace on an arm64 kernel and in this case dpkg --print-architecture and uname -m (or lscpu) give you two *different* answers.  I don't think we have arm64 livepatch and running ua pro for armhf on arm64 would just be a weird thing to even be trying to do, but it's technically possible01:39
vorlonso IMHO you should all be clear about which you *mean* (from the set of: dpkg userspace architecture; CPU architecture; kernel architecture) and be consistent with that01:40
lucasmouravorlon, we already have a architecture mapping for those differences between dpkg and lscpu: https://github.com/canonical/ubuntu-pro-client/blob/main/uaclient/util.py#L61101:42
lucasmouraBut if the architecture you are mentioned is not there, we can extend that mapping01:43
vorlonlucasmoura: the point is it is not a 1:1 mapping02:50
vorlonand not a fixed mapping02:50
lucasmouravorlon, yes, of course. I am just mentioning that it currently covers the scenarios we expect Livepatch to be covered by. But we can better align with the Livepatch team about how to better handle that mapping in the future02:53
lucasmouraMaybe with us not using lscpu anymore, we don't even need it. Then we could just rely on the output of dpkg. But I will need confirmation from Livepatch that the architectures will be properly handled by the Livepatch API03:02
lucasmouraI will bring that to team tomorrow so we can better discuss this03:02
sarnoldlucasmoura: do we intend to support livepatch on eg ubuntu core systems? do those have a dpkg available?03:03
lucasmourasarnold, this is being discussed. But we would first need to support a snap version of the Pro client. But I don't have an answer right now about dpkg support for that type of system03:05
sarnoldlucasmoura: aha! good enough for me :)03:12
sarnold[ ] a problem for another day :D03:12
-queuebot:#ubuntu-release- Unapproved: papi (lunar-proposed/universe) [7.0.0-2 => 7.0.0-2ubuntu1] (no packageset)04:22
-queuebot:#ubuntu-release- Unapproved: accepted papi [source] (lunar-proposed) [7.0.0-2ubuntu1]04:23
-queuebot:#ubuntu-release- Unapproved: swi-prolog (lunar-proposed/universe) [8.4.2+dfsg-2ubuntu1 => 9.0.4+dfsg-1ubuntu1] (no packageset)04:41
-queuebot:#ubuntu-release- Unapproved: accepted swi-prolog [source] (lunar-proposed) [9.0.4+dfsg-1ubuntu1]04:42
-queuebot:#ubuntu-release- New binary: graph-tool [riscv64] (lunar-proposed/universe) [2.45+ds-10ubuntu1] (no packageset)05:23
vorlon-ifneq (,$(filter $(DEB_HOST_ARCH),arm hppa))05:24
vorlonlovin' it05:24
-queuebot:#ubuntu-release- New: accepted graph-tool [amd64] (lunar-proposed) [2.45+ds-10ubuntu1]05:30
-queuebot:#ubuntu-release- New: accepted graph-tool [ppc64el] (lunar-proposed) [2.45+ds-10ubuntu1]05:30
-queuebot:#ubuntu-release- New: accepted graph-tool [s390x] (lunar-proposed) [2.45+ds-10ubuntu1]05:30
-queuebot:#ubuntu-release- New: accepted graph-tool [arm64] (lunar-proposed) [2.45+ds-10ubuntu1]05:30
-queuebot:#ubuntu-release- New: accepted graph-tool [riscv64] (lunar-proposed) [2.45+ds-10ubuntu1]05:30
-queuebot:#ubuntu-release- Unapproved: vectorscan (lunar-proposed/universe) [5.4.8-2.1 => 5.4.9-1] (no packageset) (sync)05:45
-queuebot:#ubuntu-release- Unapproved: accepted vectorscan [sync] (lunar-proposed) [5.4.9-1]05:46
vorlontest results are in for mesa on arm64.  s390x is not but s390x is behind and is not an interesting mesa architecture generally (and regressions wouldn't affect s390x beta images).  Unblocking mesa, preparing for mass-respins06:06
-queuebot:#ubuntu-release- Unapproved: newsboat (lunar-proposed/universe) [2.21-1.5 => 2.21-1.5ubuntu1] (no packageset)06:29
-queuebot:#ubuntu-release- Unapproved: accepted newsboat [source] (lunar-proposed) [2.21-1.5ubuntu1]06:29
-queuebot:#ubuntu-release- Unapproved: gmenuharness (lunar-proposed/universe) [0.1.4-5 => 0.1.4-5ubuntu1] (no packageset)06:52
-queuebot:#ubuntu-release- Unapproved: accepted gmenuharness [source] (lunar-proposed) [0.1.4-5ubuntu1]06:53
-queuebot:#ubuntu-release- Unapproved: accepted xorg-server [source] (focal-proposed) [2:1.20.13-1ubuntu1~20.04.7]07:16
-queuebot:#ubuntu-release- Unapproved: sphinx (lunar-proposed/main) [5.3.0-3 => 5.3.0-3ubuntu1] (i386-whitelist, ubuntu-desktop, ubuntu-server)07:38
-queuebot:#ubuntu-release- Unapproved: bioxtasraw (lunar-proposed/universe) [2.1.1-4build1 => 2.1.1-4build2] (no packageset)07:59
-queuebot:#ubuntu-release- Unapproved: accepted bioxtasraw [source] (lunar-proposed) [2.1.1-4build2]08:00
ricotzhello, please accept libreoffice/lunar, its autopkgtests passed https://ubuntu-archive-team.ubuntu.com/proposed-migration/update_excuses.html#libreoffice08:30
-queuebot:#ubuntu-release- Builds: Ubuntu Core amd64 edge [Lunar Beta] has been updated (20230329)08:46
-queuebot:#ubuntu-release- Builds: Kubuntu Desktop amd64 [Lunar Beta] has been updated (20230329)09:33
-queuebot:#ubuntu-release- Builds: Ubuntu Desktop (Legacy) amd64 [Lunar Beta] has been updated (20230329)09:36
-queuebot:#ubuntu-release- Builds: Edubuntu Desktop amd64 [Lunar Beta] has been updated (20230329)09:39
-queuebot:#ubuntu-release- Unapproved: snapd (lunar-proposed/main) [2.58.3+23.04ubuntu1 => 2.59.1+23.04] (desktop-core, ubuntu-server)09:41
-queuebot:#ubuntu-release- Builds: Ubuntu MATE Desktop amd64 [Lunar Beta] has been updated (20230329)09:43
-queuebot:#ubuntu-release- Builds: Xubuntu Desktop amd64 [Lunar Beta] has been updated (20230329)09:44
-queuebot:#ubuntu-release- Builds: Ubuntu Budgie Desktop amd64 [Lunar Beta] has been updated (20230329)09:45
-queuebot:#ubuntu-release- Builds: Ubuntu Kylin Desktop amd64 [Lunar Beta] has been updated (20230329)09:47
-queuebot:#ubuntu-release- Builds: Ubuntu Studio DVD amd64 [Lunar Beta] has been updated (20230329)09:51
-queuebot:#ubuntu-release- Builds: Ubuntu Desktop arm64+raspi [Lunar Beta] has been updated (20230329)10:18
-queuebot:#ubuntu-release- Builds: Ubuntu Desktop amd64 [Lunar Beta] has been updated (20230329)10:30
-queuebot:#ubuntu-release- Builds: Ubuntu Desktop arm64 [Lunar Beta] has been updated (20230329)10:30
-queuebot:#ubuntu-release- Unapproved: accepted studio-controls [source] (jammy-backports) [2.3.9-0ubuntu2~bpo22.04.1]10:38
-queuebot:#ubuntu-release- Unapproved: accepted borgmatic [source] (jammy-backports) [1.7.9-0ubuntu1~bpo22.04.1]10:41
-queuebot:#ubuntu-release- Unapproved: tzdata (lunar-proposed/main) [2023b-1exp1ubuntu1 => 2023c-1exp1ubuntu1] (core)10:42
-queuebot:#ubuntu-release- Builds: Ubuntu WSL [Lunar Beta] (4552871144) has been added10:44
-queuebot:#ubuntu-release- Builds: Ubuntu Base amd64 [Lunar Beta] has been updated (20230329)10:54
-queuebot:#ubuntu-release- Builds: Ubuntu Base arm64 [Lunar Beta] has been updated (20230329)10:54
-queuebot:#ubuntu-release- Builds: Ubuntu Base armhf [Lunar Beta] has been updated (20230329)10:54
-queuebot:#ubuntu-release- Builds: Ubuntu Base ppc64el [Lunar Beta] has been updated (20230329)10:54
-queuebot:#ubuntu-release- Builds: Ubuntu Base riscv64 [Lunar Beta] has been updated (20230329)10:54
-queuebot:#ubuntu-release- Builds: Ubuntu Base s390x [Lunar Beta] has been updated (20230329)10:54
-queuebot:#ubuntu-release- Unapproved: tzdata (kinetic-proposed/main) [2023b-0ubuntu0.22.10.0 => 2023c-0ubuntu0.22.10.0] (core)11:04
-queuebot:#ubuntu-release- Unapproved: tzdata (jammy-proposed/main) [2023b-0ubuntu0.22.04.0 => 2023c-0ubuntu0.22.04.0] (core)11:10
-queuebot:#ubuntu-release- Unapproved: tzdata (focal-proposed/main) [2023b-0ubuntu0.20.04.0 => 2023c-0ubuntu0.20.04.0] (core)11:16
-queuebot:#ubuntu-release- Unapproved: python-certbot (lunar-proposed/universe) [2.1.0-2 => 2.1.0-3] (no packageset) (sync)11:22
-queuebot:#ubuntu-release- Unapproved: accepted python-certbot [sync] (lunar-proposed) [2.1.0-3]11:23
-queuebot:#ubuntu-release- Unapproved: tzdata (bionic-proposed/main) [2023b-0ubuntu0.18.04.0 => 2023c-0ubuntu0.18.04.0] (core)11:25
bdrungrbasak, bdmurray: The new SRUs for tzdata 2023c are ready. I reused https://bugs.launchpad.net/ubuntu/+source/tzdata/+bug/201259911:32
-ubottu:#ubuntu-release- Launchpad bug 2012599 in tzdata (Ubuntu Lunar) "tzdata 2023a/2023b/2023c release - Egypt restoring DST" [Critical, Fix Committed]11:32
-queuebot:#ubuntu-release- Unapproved: fsarchiver (lunar-proposed/universe) [0.8.6-2ubuntu1 => 0.8.7-1] (no packageset) (sync)12:36
-queuebot:#ubuntu-release- Unapproved: therion (lunar-proposed/universe) [6.1.6-2 => 6.1.6-3] (no packageset) (sync)12:37
-queuebot:#ubuntu-release- Unapproved: accepted fsarchiver [sync] (lunar-proposed) [0.8.7-1]12:37
-queuebot:#ubuntu-release- Unapproved: accepted therion [sync] (lunar-proposed) [6.1.6-3]12:37
-queuebot:#ubuntu-release- Builds: Ubuntu Server arm64+raspi [Lunar Beta] has been updated (20230329)13:02
-queuebot:#ubuntu-release- Builds: Ubuntu Server armhf+raspi [Lunar Beta] has been updated (20230329)13:02
-queuebot:#ubuntu-release- Builds: Ubuntu Server riscv64+icicle [Lunar Beta] has been updated (20230329)13:02
-queuebot:#ubuntu-release- Builds: Ubuntu Server riscv64+licheerv [Lunar Beta] has been updated (20230329)13:02
-queuebot:#ubuntu-release- Builds: Ubuntu Server riscv64+nezha [Lunar Beta] has been updated (20230329)13:02
-queuebot:#ubuntu-release- Builds: Ubuntu Server riscv64+visionfive [Lunar Beta] has been updated (20230329)13:02
AlsoItzSwirlzIt looks like Cinnamon didn't build yesterday, did something fail or is it building through everything13:14
rbasakbdrung: "The SRUs to the stable include the recent changes for generating the debconf template and the timezone mappings in convert_timezone(). Previous SRUs did forget to update them for the changes from upstream." -> shouldn't this be in a Test Plan somewhere for SRU verification?13:48
ginggsAlsoItzSwirlz: no build yesterday or today, I'll look into it13:48
rbasakIt seems still relevant now since AFAICT that change hasn't landed in updates yet.13:48
AlsoItzSwirlzginggs: thx13:48
adrienhi, can someone unblock strace 6.2? it cannot migrate due to the FF but exception has been granted (and in the future, it will probably follow the kernel freeze instead)13:49
adrienthanks :)13:49
rbasakbdrung: and I think this upload needs a -v2022g-0ubuntu0.22.10.1 to cover everything that hasn't landed yet.13:49
rbasakI've only been looking at Kinetic - I assume the older stable release uploads are identical and will need the equivalent stuff done there too.13:50
ginggsadrien: strace is blocked from migration due to beta freeze, please ping me on Friday13:51
adrienok, will do, thanks13:52
bdrungrbasak, regarding the test plan: the SRUs got enhanced with autopkgtest test cases (with all things that i could come up with)14:04
bdrungrbasak, good point for the -v parameter. do i need to re-upload them?14:05
-queuebot:#ubuntu-release- Builds: Ubuntu Server Subiquity amd64 [Lunar Beta] has been updated (20230329)14:07
-queuebot:#ubuntu-release- Builds: Ubuntu Cinnamon amd64 [Lunar Beta] (20230327) has been added14:08
-queuebot:#ubuntu-release- Builds: Ubuntu Server Subiquity arm64 [Lunar Beta] has been updated (20230329)14:08
-queuebot:#ubuntu-release- Builds: Ubuntu Server Subiquity ppc64el [Lunar Beta] has been updated (20230329)14:08
-queuebot:#ubuntu-release- Builds: Ubuntu Server Subiquity riscv64 [Lunar Beta] has been updated (20230329)14:08
-queuebot:#ubuntu-release- Builds: Ubuntu Server Subiquity s390x [Lunar Beta] has been updated (20230329)14:08
rbasakbdrung: I appreciate the new dep8 tests - thanks! Do they cover the debconf templates?14:12
ginggsAlsoItzSwirlz: cinnamon spinning now...14:13
AlsoItzSwirlzginggs: thanks14:13
rbasakbdrung: also I have no issue with fixing debconf templates lagging behind by autogenerating them instead, including in an SRU. I just want to make sure that given we're touching them, we're checking that they don't regress something. I don't mind if that's automatic or manual - just that it's not missed.14:14
rbasakbdrung: yes - please re-upload with -v.14:19
bdrungrbasak, yes. see debian/tests/debconf14:20
rbasakOh great. Sorry I missed tat.14:21
bdrungrbasak, the debconf template was generated in bash before but is now done using Python14:23
bdrungthe combination of generating them and the debconf test case ensure that they are in good shape.14:26
rbasakbdrung: I think https://wiki.ubuntu.com/StableReleaseUpdates#tzdata could do with an explanation of that. Otherwise SRU reviewers will see an unexplained diff.14:27
rbasak(which is usually an error)14:27
bdrunglet's see if I can log-in to the wiki14:28
rbasakOh, hang on. Is it being generated before upload or as part of the build?14:29
rbasakIf the latter, then it wouldn't result in unexplained diffs (except this time, and this time it is explained in the SRU bug which I very much appreciate!)14:30
bdrungYes. it's the latter. the generated debconf template is part of the source package14:32
bdrungrbasak, I checked it again. People can forget to include the template update in the source package. In this case lintian will complain about an outdated template in the source package.14:38
rbasakbdrung: the SRU team doesn't check lintian output. At least I'm not aware that anyone does.14:39
bdrungrbasak, at least I am doing that. So if I miss to include it, I will notice it before the upload.14:40
rbasakbdrung: could we stick steps into the wiki to verify that the mistake isn't made somehow maybe? Like ask for lintian to be run explicitly, or something in a standard Test Plan, or an additional dep8 test maybe.14:40
rbasakFor this time it's fine. I'd just like to make the process smoother for everyone in the future.14:40
-queuebot:#ubuntu-release- Unapproved: swtpm (lunar-proposed/main) [0.6.3-0ubuntu5 => 0.7.3-0ubuntu1] (no packageset)14:45
rbasak^ FFe approved and it's not in an image14:45
-queuebot:#ubuntu-release- Unapproved: accepted swtpm [source] (lunar-proposed) [0.7.3-0ubuntu1]14:47
-queuebot:#ubuntu-release- Unapproved: vim (lunar-proposed/main) [2:9.0.1000-4ubuntu2 => 2:9.0.1000-4ubuntu3] (core, i386-whitelist)14:52
bdrungrbasak, I am not sure if not having the debconf generation in the debdiff is really a problem. Let me explain the debconf issue with some examples: Kiev was renamed Kyiv. Without any change, both names could be selected in debconf. if you add kiev to the conversion list in tzdata.config, you will get an inconsistency which will not detected by test_timezone_conversions14:56
bdrungrbasak, explaining this now makes me think that the debconf template generation should have a allow list for symlinks as well. Then it will fail in this Kiev to Kyiv rename case if both could be selected.14:58
rbasakbdrung: I'm not saying it's a problem. I'm just saying that whatever changes are made, they should be verified - either automatically or manually. And for review, everything that appears in the debdiff should have an explanation. If there's automated stuff happening, then that's fine, but we should explain it in the wiki, so that it doesn't get held up by confused reviewers.14:58
* bdrung agrees.14:59
vorlonricotz: libreoffice/lunar should not be accepted today, it's not beta-critical and does not warrant media respins and re-testing15:41
jbichaubuntu-release: please promote the Ubuntu Desktop amd64 iso from pending/ to current/ since the isotracker download link points to current/15:45
jbichapromoting from pending to current is manual currently, after the switch to the new installer15:46
-queuebot:#ubuntu-release- Unapproved: swi-prolog (lunar-proposed/universe) [9.0.4+dfsg-1ubuntu1 => 9.0.4+dfsg-1ubuntu2] (no packageset)15:49
-queuebot:#ubuntu-release- Unapproved: accepted swi-prolog [source] (lunar-proposed) [9.0.4+dfsg-1ubuntu2]15:50
-queuebot:#ubuntu-release- Unapproved: logol (lunar-proposed/universe) [1.7.9+dfsg-6 => 1.7.9+dfsg-6build1] (no packageset)15:52
-queuebot:#ubuntu-release- Unapproved: accepted logol [source] (lunar-proposed) [1.7.9+dfsg-6build1]15:53
-queuebot:#ubuntu-release- Unapproved: ppl (lunar-proposed/universe) [1:1.2-8.1build1 => 1:1.2-8.1build2] (no packageset)15:53
ricotzvorlon, I see, ack (unfortunately the autopkgtests were slow again)15:53
-queuebot:#ubuntu-release- Unapproved: accepted ppl [source] (lunar-proposed) [1:1.2-8.1build2]15:54
rbasakbdrung: are you planning re-uploads of tzdata today with the -v?16:00
schopinubuntu-release: vim isn't beta critical either, I kinda forgot about the beta freeze, sorry :/16:01
vorlonschopin: no worries, we can just not look at the unapproved queue for anything people aren't screaming for16:09
orndorffgrantlucasmoura, vorlon: following up on the lscpu vs dpkg arch differences conversation. I've submitted an issue for livepatch-client here to discuss moving away from parsing lscpu outpu: https://github.com/canonical/livepatch-client/issues/348 and for pro-client I made this issue for using uname -m for livepatch related things16:17
-ubottu:#ubuntu-release- Issue 2517 in canonical/ubuntu-pro-client "livepatch support should be queried with kernel architecture, not user-space package arch" [Open]16:17
vorlonorndorffgrant: cheers16:18
bdrungrbasak, yes. Do you need to drop the current version or can I just do the upload?16:21
rbasakYou can just upload on top.16:21
rbasakI'm reviewing from what's there currently so it's easier to keep it there for now if you don't mind. I'll clean up after.16:22
rbasakNo need to change the version strings.16:22
-queuebot:#ubuntu-release- Unapproved: tzdata (kinetic-proposed/main) [2023b-0ubuntu0.22.10.0 => 2023c-0ubuntu0.22.10.0] (core)16:26
-queuebot:#ubuntu-release- Unapproved: tzdata (jammy-proposed/main) [2023b-0ubuntu0.22.04.0 => 2023c-0ubuntu0.22.04.0] (core)16:26
bdrungrbasak, re-upload done16:27
-queuebot:#ubuntu-release- Unapproved: tzdata (bionic-proposed/main) [2023b-0ubuntu0.18.04.0 => 2023c-0ubuntu0.18.04.0] (core)16:27
-queuebot:#ubuntu-release- Unapproved: tzdata (focal-proposed/main) [2023b-0ubuntu0.20.04.0 => 2023c-0ubuntu0.20.04.0] (core)16:27
jbichavorlon: are you able to do the iso promotion or do you know who we could ask?16:35
vorlonjbicha: what do you mean by "iso promotion"16:36
jbichavorlon: copy the Ubuntu Desktop amd64 daily-live iso from pending/ to current/16:37
vorlonthat's supposed to happen automatically based on test results16:38
jbichait doesn't work yet16:38
vorlon(or the absence of test results if none are defined)16:38
vorlonwell that seems bad!16:38
vorlonjbicha: daily-live/current has a bunch of symlinks pointing to today's build16:39
vorlonah but not for amd64 which is at 2023032416:39
vorlonso if that one was promoted but 20230329 was not does that mean tests *did* pass but have regressed?16:39
vorlonjbicha: I would note that none of this is relevant for beta16:40
jbichavorlon: maybe there is a different bug but http://iso.qa.ubuntu.com/qatracker/milestones/444/builds/275082/testcases "link to the download information" is pointing to current16:41
vorlonwell that's silly, it should point to the serial16:41
jbichaso I'm concerned that we could get test reports for the wrong iso16:41
jbichait did for previous milestones 🤷16:42
vorlonlet me check that16:42
jbichamy understanding is that previous amd64 ISOs since the switch to subiquity have been promoted to current manually ☹️16:43
vorlondon't know who did that16:43
vorlonok well I'm not touching manual promotion given that the beta problem is fixed.  Someone on Desktop Team needs to either own getting the auto tests fixed, or own regressing auto test coverage16:43
vorlon(and it would be ideal if QA Team were resourced to address sorting this out, but in the meantime-)16:44
bdmurrayvorlon: you may have fixed bug 201234516:46
-ubottu:#ubuntu-release- Bug 2012345 in Ubuntu QA Website "Links for Ubuntu Lunar ISO downloads are incomplete" [Undecided, New] https://launchpad.net/bugs/201234516:46
rbasakArgh. tzdata Focal and Bionic are *differently different*? :-/16:47
seb128vorlon, I'm working with paride on getting the ISO tests working with the new installer, the provisioning got updated to switch from d-i preseeding style to subiquity autoinstall but there are some problems still so we have been relying on Lukasz to promote our images from pending to current on a semi regular basis through pings after rounds of manual testing16:49
vorlonstill not relevant for beta (anymore) ;)16:51
vorlonbdmurray: partial fix.  This new product was set up without all the usual auxiliary links, as mentioned16:51
vorlonqueuing that to maybe finish today16:51
AlsoItzSwirlzginggs: sorry, but is everything ok with the cinnamon image? the qa tracker says its rebuilding, i don't see a 3/29 build and if an image is taking 3 hours to build, I don't think its just installing cinnamon17:37
AlsoItzSwirlzis it installing every single flavor package? lol17:37
-queuebot:#ubuntu-release- Unapproved: sphinx (lunar-proposed/main) [5.3.0-3 => 5.3.0-4] (i386-whitelist, ubuntu-desktop, ubuntu-server) (sync)17:40
vorlonItzSwirlz: you can always check here if an image build has been successfully dispatched https://launchpad.net/~ubuntu-cdimage/+livefs/ubuntu/lunar/ubuntucinnamon17:42
-queuebot:#ubuntu-release- Unapproved: libsigc++-3.0 (lunar-proposed/universe) [3.4.0-1 => 3.4.0-1ubuntu1] (no packageset)17:42
AlsoItzSwirlz30 seconds left supposedly?17:43
vorlonin this case we ran into some hangups with the image builds actually getting dispatched; owing to ubuntucinnamon being a new product17:43
AlsoItzSwirlzno problem, it's alright17:43
vorlonyes, the build was only kicked off a few minutes ago when bdmurray noticed it17:43
AlsoItzSwirlzno problem17:43
-queuebot:#ubuntu-release- Unapproved: accepted libsigc++-3.0 [source] (lunar-proposed) [3.4.0-1ubuntu1]17:43
vorlonnote that this is the eta for the squashfs build - it then has to be wrapped into an ISO and rsynced over to the web frontend. I'd say give it 10-15 minutes17:44
AlsoItzSwirlzno problem, i got a free period right now17:44
AlsoItzSwirlzlooks like, according to the logs it isn't installing firefox17:45
vorlonthe snap?17:46
bdmurrayAlsoItzSwirlz: per a previous private conversation I'l be adding the test cases "nstall (entire-disk) and Live Session" for Ubuntu Cinnamon17:46
AlsoItzSwirlzbdmurray: thank you!17:46
AlsoItzSwirlzvorlon: yeah, in the seed it's there: https://git.launchpad.net/~ubuntucinnamon-dev/ubuntu-seeds/+git/ubuntucinnamon/tree/desktop17:47
vorlonAlsoItzSwirlz: livecd-rootfs probably needs to be updated to know to look in this seed for snaps17:47
AlsoItzSwirlzvorlon: or could it be that i think i put snap as a recommend [(snap:firefox) instead of snap:fierfox]17:47
vorlonI mean, that's quite possible17:48
vorlonit's meaningless to 'recommend' a snap from a seed since they're not expressed via dpkg deps17:49
AlsoItzSwirlzlet me check other seeds17:49
vorlonand yeah I checked livecd-rootfs and the code is generic with respect to picking up snaps from 'desktop'17:49
arraybolt3[m]I'm almost positive Lubuntu doesn't attempt to "recommends" the Firefox snap, it just includes it.17:49
AlsoItzSwirlzYep. Studio's code highlights it well, putting the parens around "firefox" and later saying specifically snap:firefox17:50
vorlonis this... the first image build17:50
vorlonah no there were builds before but they've been expired out17:51
AlsoItzSwirlzi'm trusting snap:gnome-42-2204 is necessary17:53
AlsoItzSwirlzalong with gtk-common-themes17:53
-queuebot:#ubuntu-release- Builds: Ubuntu Cinnamon Desktop amd64 [Lunar Beta] (20230327) has been added17:55
bdmurrayAlsoItzSwirlz: https://iso.qa.ubuntu.com/qatracker/milestones/444/builds/275105/testcases17:57
bdmurrayThe latest build didn't actually get published on the isotracker, I could rebuild it now or wait for the firefox issue. AlsoItzSwirlz what do you think?17:57
AlsoItzSwirlzI didn't push the firefox fix yet so dont worry17:58
AlsoItzSwirlzThere's a few more packages I want to check17:58
AlsoItzSwirlzokay now it pushed but dw about it17:58
bdmurrayrebuilding now then (good thing its nice and quick!)17:59
AlsoItzSwirlzits going to take as long as it will to download the current most recent file on school wifi but no problem17:59
-queuebot:#ubuntu-release- Unapproved: libsigc++-3.0 (lunar-proposed/universe) [3.4.0-1 => 3.4.0-1ubuntu2] (no packageset)18:01
-queuebot:#ubuntu-release- Unapproved: accepted libsigc++-3.0 [source] (lunar-proposed) [3.4.0-1ubuntu2]18:02
-queuebot:#ubuntu-release- Unapproved: libsigc++-3.0 (lunar-proposed/universe) [3.4.0-1 => 3.4.0-1ubuntu3] (no packageset)18:08
-queuebot:#ubuntu-release- Unapproved: accepted libsigc++-3.0 [source] (lunar-proposed) [3.4.0-1ubuntu3]18:09
AlsoItzSwirlzubiquity "try or install" screen still has debian wallpaper, so note #118:14
bdmurrayRespinning xubuntu-minimal since its rebuild request failed18:16
-queuebot:#ubuntu-release- Builds: Ubuntu Cinnamon Desktop amd64 [Lunar Beta] has been updated (20230329.1)18:18
-queuebot:#ubuntu-release- Builds: Xubuntu Minimal amd64 [Lunar Beta] has been updated (20230329.1)18:33
bdmurrayvorlon: did you fix the libevernt issue? lubuntu failed to build earlier because of that18:42
vorlonbdmurray: yes, libevent migrated last night18:43
vorlonbdmurray: so hopefully "earlier" means before that18:43
bdmurrayearlier means the 28th - so rebuilding lubuntu too18:44
seb128vorlon, could you promote pending to current anyway? it's not an iso for the iso tracker and beta but we still have users testing current and we would like that pointing to an uptodate image18:45
seb128not an issue...18:45
-queuebot:#ubuntu-release- Unapproved: otf2 (lunar-proposed/universe) [3.0.2-1 => 3.0.2-1ubuntu1] (no packageset)18:46
-queuebot:#ubuntu-release- Unapproved: accepted otf2 [source] (lunar-proposed) [3.0.2-1ubuntu1]18:47
vorlonrebuilding ubuntu-unity after fixing the seed for snaps18:47
vorlonseb128: not a priority from my side, sorry18:48
seb128vorlon, sorry I though that was a one command 5s type of job, if it's creating work it can wait18:49
vorlonseb128: 5 minutes to figure out what the command is, 5s to run it18:49
seb128fair enough, sounds like something to document in the team process for the next person to figure it out18:50
seb128Lukasz know how to do it but he doesn't seem to be around or at least not on IRC?18:52
vorlonsure; it's past EOD18:52
vorlon(also today is a sick day for him)18:53
seb128right, I meant he was not there earlier, I checked hr.c.c but that didn't reflect it18:53
vorlonseb128: what I *DO* know how to do offhand is to disable waiting for test results before promoting to current, if you want that18:56
seb128vorlon, the end result is the same right?18:57
seb128I just want to avoid confusion of people thinking they test beta by fetching current18:57
vorlonthe difference is whether you're pinging the release team daily, or only once you're ready to turn the gating back on18:57
seb128I think at this point of the cycle that's what we want so please do it18:58
-queuebot:#ubuntu-release- Builds: Lubuntu Desktop amd64 [Lunar Beta] (20230329) has been added19:08
bdmurrayOkay, lubuntu built19:15
arraybolt3Ah, and Unity is already fixed. Very nice.19:23
arraybolt3Guess this is "test like crazy" day.19:23
vorlonseb128: ok I've marked it as not-blocked by test results.  (Would be nice to block the legacy images instead by those same tests but I assume code needs changed in 5 other places to handle that, given the discontinuity)  I don't know that this will cause the currently-pending image to be promoted, if you don't see it promoted in the next hour I can sort out a manual promotion19:32
vorlonbdmurray, jbicha, seb128: fixed the download links, http://iso.qa.ubuntu.com/qatracker/milestones/444/builds/275082/downloads19:39
-queuebot:#ubuntu-release- Unapproved: otf2 (lunar-proposed/universe) [3.0.2-1ubuntu1 => 3.0.2-1ubuntu2] (no packageset)19:49
-queuebot:#ubuntu-release- Unapproved: accepted otf2 [source] (lunar-proposed) [3.0.2-1ubuntu2]19:50
rbasakbdrung: what was the purpose of https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/commit/?h=ubuntu/kinetic&id=fb5ab09a595b2a7eeeddd6630adae99471a8828e? Was that generated by something?19:57
-ubottu:#ubuntu-release- Commit fb5ab09 in ~ubuntu-core-dev/ubuntu/+source/tzdata "d/tzdata.config: Use convert_timezone from 2023g-1"19:57
arraybolt3https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/2013236 Looks like something has broken with ubuntu-drivers or possibly Broadcom firmware.20:11
-ubottu:#ubuntu-release- Launchpad bug 2013236 in ubiquity (Ubuntu) "Failed to install bcmwl wireless driver during the install" [Undecided, Confirmed]20:11
arraybolt3wget-ing the Ubuntu Desktop Legacy image to confirm that this affects that too.20:12
arraybolt3uh... tar, I actually no longer have the hardware to test taht.20:14
vorlonarraybolt3: thanks.  Probably not something we're fixing for beta.  May be an ubuntu-drivers issue wrt replacing bcmwl source package with broadcom-sta.  Logs on the bug show no evidence of ubuntu-drivers installing broadcom-sta-dkms20:18
arraybolt3+1, figured it was worth mentioning since it's been happening for a while.20:19
arraybolt3(btw, for bugs that I think will probably hang things up but that are going unnoticed, what's a good way to bring them up *before* we're in a time crunch?)20:19
vorlonlogs do confirm broadcom-sta-dkms is present on the ISO. apt show confirms that it has Modaliases consistent with the previous bcmwl package20:20
vorlonarraybolt3: good way> flagging them here works as well as anyt20:20
arraybolt3Nice, will do.20:21
* arraybolt3 vanishes back into other work20:21
vorlonarraybolt3: kernel logs don't show a pci dev matching what's supported by either bcmwl or broadcom-sta20:22
arraybolt3Try looking at the logs of my duplicate bug report, I have a chip in a laptop I used to use for testing that I *know* works with the bcmwl driver.20:23
vorlonarraybolt3: confirmed, *your* dev matches modaliases (14e4:4359)20:24
arraybolt3[m]Oh weird.20:25
vorlonarraybolt3: I suggest deduping the bugs based on this20:25
vorlonarraybolt3: yeah on the parent bug, the device in question wouldn't have had bcmwl loaded in jammy either20:28
arraybolt3[m]That's weird, since it used to work for him. Are there multiple Broadcom drivers or something?20:29
arraybolt3[m]Oh, actually there are. The STA driver, the new STA driver, and the b43 driver...20:29
vorlonarraybolt3: he asserts "bcmwl was installed correctly" but I doubt this is true20:29
vorlonhe probably had wifi *working*, with a different driver20:29
arraybolt3[m]Which would make sense since I think Macbooks have different Broadcom chips than normal laptops at least in some instances.20:30
vorlonarraybolt3: from the live env, please run 'ubuntu-drivers devices', 'ubuntu-drivers list' and paste to the bug20:34
vorlonubuntu-unity build failed, saying it couldn't download the very snap I just seeded20:34
arraybolt3[m]Unfortunately, the laptop I reproduced the bug on had to be put into normal use and isn't available for testing right this second. I might be able to boot it into a live env in a bit though.20:34
vorlonarraybolt3: 'ubuntu-drivers' probably works in a chroot fwiw20:35
arraybolt3Hmm, not a bad idea, but I have Jammy installed on the machine right now, not sure if that's helpful?20:36
arraybolt3But if it's just the live env, no big deal, I can just flash a USB, boot it, do the test, then boot it back into the normal OS.20:36
vorlonI'm saying if it's easier than taking your current workload down for rebooting, you can mk-sbuild yourself a lunar chroot, install ubuntu-drivers-common into that, and see what it says20:37
vorlontrying the ubuntu-unity build again in case this is a fluke with the store20:38
arraybolt3Ah, that makes sense. It's not that hard though (that alternative is actually harder :P)20:38
arraybolt3(It's not being used as my PC, I'm turning it into a weird server of sorts.)20:38
arraybolt3OK, booting a legacy Desktop ISO on it now.20:52
rbasakbdrung: also, what's the upstream source for debian/icu?20:52
-queuebot:#ubuntu-release- Unapproved: ubuntu-unity-backgrounds (lunar-proposed/universe) [22.10.1-0ubuntu1 => 23.04-0ubuntu1] (no packageset)20:52
rbasakI found https://github.com/unicode-org/icu/tree/main/icu4c/source/data/misc, but it isn't clear to me if that's where you're getting it from. I don't see a matching tag.20:52
arraybolt3vorlon: Info added to report.20:52
-queuebot:#ubuntu-release- Builds: Ubuntu Server riscv64+unmatched [Lunar Beta] has been updated (20230329.2)21:04
vorlonfound the ubuntu-unity issue, it was my dumb editing mistake21:08
-queuebot:#ubuntu-release- Unapproved: qtcreator (lunar-proposed/universe) [9.0.2-1 => 9.0.2-2] (qt5) (sync)21:25
bdmurrayrbasak: icu-data upstream is here https://github.com/unicode-org/icu-data/tree/main/tzdata/icunew21:25
vorlonblaaaahhhh ubuntu-unity still failed because livecd-rootfs pulls the seeds from archive-team.internal which hadn't refreshed yet21:26
vorlonshould've waited 5 minutes21:26
bdrungrbasak, see update-icu from debian/rules21:31
vorlonjbicha: looking at reports I don't check up on often, I see that gnome-remote-desktop in jammy-updates has had phasing at 0 since January 5.  Are you aware of this, have you reviewed the errors that caused phasing to halt?21:35
rbasakbdrung: ah thanks! I looked for a debian/README* or similar and in debian/watch, debian/upstream/ etc  but didn't think to look for a custom rule.21:47
vorlonsince it's under debian/ unfortunately a debian/watch wouldn't dtrt21:48
rbasakyeah but I was looking for a comment or something21:50
rbasakI had also looked in debian/copyright21:50
rbasakjust for a pointer21:50
rbasakbdrung: debian/icu/zoneinfo64.txt seems to mismatch?21:50
LocutusOfBorgplease reject sphinx/5.3.0-3ubuntu1 in unapproved queue21:50
rbasakOnly on version, but is that expected?21:50
LocutusOfBorg5.3.0-4 in the same queue has a proper fix21:50
-queuebot:#ubuntu-release- Builds: Ubuntu Unity Desktop amd64 [Lunar Beta] (20230329.3) has been added21:51
rbasakbdrung: https://paste.ubuntu.com/p/g9JScs3rRK/21:51
rbasakI don't know if a version mismatching the expected one might cause an issue21:52
rbasakbdrung: also did you see my earlier question? What was the purpose of https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/commit/?h=ubuntu/kinetic&id=fb5ab09a595b2a7eeeddd6630adae99471a8828e? Was that generated by something?21:54
-ubottu:#ubuntu-release- Commit fb5ab09 in ~ubuntu-core-dev/ubuntu/+source/tzdata "d/tzdata.config: Use convert_timezone from 2023g-1"21:54
rbasakOh, I see:   * Update the ICU timezone data to 2023a (2023b is not available yet)22:02
rbasakOK so just the tzdata.config question remaining right now. I'll continue to review.22:03
bdrungrbasak, the convert_timezone function is used to update obsolete timezones (e.g. rename kiev to kyiv) to timezones that can also be selected by debconf.22:09
bdrungThe use of convert_timezone from 2023g-1 ensures that the conversion is consistent with all the updates.22:10
bdrungcommit 09c572f98c4d55478ab163488ee2ad12e2fdc24b ("Build timezones that differ pre-1970"), da07a111db15f0f70957fb6aa68cac6ee1a9b051 ("Update conversion targets to America/Indiana/Indianapolis"), 5c6c755c00842a77dc7c186a4b8622f8b7f1fa99 ("Do not update US/* timezones to their America/* counterparts"), 4c2b898ef99c134a9d202405643136d4b0d38048 ("Drop wrong conversion of the Pacific/Enderbury timezone")22:13
rbasakbdrung: I don't understand how that relates to the diff22:13
-queuebot:#ubuntu-release- Unapproved: unity-tweak-tool (lunar-proposed/universe) [0.0.7+-0ubuntu10 => 0.0.7+-0ubuntu11] (no packageset)22:13
rbasakLooks like a bunch of refactoring with no functional change? Where did that come from?22:14
-queuebot:#ubuntu-release- Unapproved: livecd-rootfs (lunar-proposed/main) [2.817 => 2.818] (desktop-core, i386-whitelist)22:14
-queuebot:#ubuntu-release- Unapproved: ubuntu-settings (lunar-proposed/main) [23.04.3 => 23.04.4] (ubuntu-desktop)22:15
bdrungrbasak, since i took the whole function from 2023g-1 it includes the refactorings as well: be005c0482bd45d676e9ab85beb8a89f584dee0e ("d/tzdata.config: Sort timezone case matches alphabetical"), 6648a42324af7e4a27e65640e383a99c70445bc5 ("d/tzdata.config: Group matches by target timzones")22:16
bdrungand commit 41a71b73947165a26583218421ece599b3009b6a ("d/tzdata.config: Make case statement format consistent")22:17
rbasakI see :-/22:17
* rbasak isn't sure how to review this then22:17
rbasakNormally I wouldn't expect an SRU to do refactoring.22:18
rbasakhttps://wiki.ubuntu.com/StableReleaseUpdates#tzdata also says that we don't expect to change packaging in tzdata SRUs22:18
rbasakWhat about stuff like the removal of "Enderbury" -> "Pacific/Kanton"?22:21
bdrungtzdata SRUs include addition and renames of timezones. That causes changes to the convert_timezone function and also to the debconf template generation code. That's why I backported the changes to those parts to the SRU, but kept the remaining part of tzdata.config unchanged.22:21
rbasakBut isn't stuff being removed, too?22:23
rbasakWhich is particularly hard to see because of the reordering refactor, but "Enderbury" is a concrete example.22:24
bdrungrbasak, the timezone "Enderbury" did not exist, the replacement was meant to be "Pacific/Enderbury"22:27
rbasakOh OK so that one came from https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/tzdata/commit/?id=4c2b898ef99c134a9d202405643136d4b0d3804822:27
-ubottu:#ubuntu-release- Commit 4c2b898 in ~ubuntu-core-dev/ubuntu/+source/tzdata "Drop wrong conversion of the Pacific/Enderbury timezone"22:27
rbasakBut that's a change that might regress users, no?22:27
rbasakFine for a development release, but not for a stable release?22:27
bdrungnot really, since the timezone "Enderbury" did / does not exist and users could not set it and it would have been broken. On upgrades these broken timezone would not be changed to "Pacific/Kanton".22:30
bdrunguser could have set the timezone to Pacific/Enderbury.22:30
rbasakHow can I confirm that for my review?22:31
bdrungYou could check that no package ships /usr/share/zoneinfo/Enderbury. You could dpkg-reconfigure tzdata to Pacific -> Enderbury. Then upgrade the package.22:33
rbasakAre there other changes like this one that need similar consideration?22:36
rbasakThis kind of thing is what SRU documentation is supposed to be used for, and why we don't expect unrelated changes to be backported without an SRU bug to explain it :-/22:36
rbasakIt might all be correct, but what's the point of an SRU review if not to check, and in that case, surely this isn't a reasonable way to present it to the SRU team for review?22:37
bdrungwould it have been better to cherry pick all those changes to the tzdata.config file separately?22:38
rbasakFrom a review perspective it's easier not to cherry-pick unnecessary changes at all. SRU policy is to keep changes minimal, and I think this thread is one good explanation as to why.22:39
rbasakThe same goes for the bash -> Python template generation refactoring really.22:41
rbasakIt should at least have been explained in an SRU bug22:42
rbasakLike maybe it is a better approach and we do want it in an SRU. But that decision is supposed presented for review by the SRU team.22:42
rbasaksupposed *to be* presented22:43
rbasakI haven't finished reviewing that part either FWIW. I was working breadth-first - trying to understand what bits were changed for what reason first.22:44
bdrungThe Python code is simple to read/write than Shell code and more robust compared to the "find | egrep | sort" construct that needs to be touched.22:45
bdrungrbasak, do you look at the git repository? the commits have some explanation.22:45
rbasak"Drop wrong conversion of the Pacific/Enderbury timezone" isn't really an explanation!22:47
rbasakI mean I can see it's a conversion from the diff. So that might as well say "Fix wrong thing".22:47
bdrung"Drop wrong conversion of the Pacific/Enderbury timezone" -> "Pacific/Enderbury" != "Enderbury"22:48
rbasakThe Python code is simple...> sure, but that's not normally what we do in SRUs.22:49
rbasakTo review such an SRU, it's then required to review all of that, rather than what might be small diffs.22:49
rbasakSee "In line with this, the requirements for stable updates..." in https://wiki.ubuntu.com/StableReleaseUpdates22:50
rbasakThat's my expectation when reviewing an SRU, and I would expect deviation from that to come with an explanation as to why this case is exceptional.22:50
rbasakI'll ask other SRU team members for an opinion on how to proceed here.22:50
rbasakAnd move on for now.22:50
bdrungrbasak, I extended the [ Other Info ] section in bug #201259922:58
-ubottu:#ubuntu-release- Bug 2012599 in tzdata (Ubuntu Lunar) "tzdata 2023a/2023b/2023c release - Egypt restoring DST" [Critical, Fix Committed] https://launchpad.net/bugs/201259922:58
bdrungrbasak, including the changes for "Build timezones that differ pre-1970" makes the diff bigger. Maybe it would have been better to split that into two SRUs.23:01
tewardubuntu-archive: spotcheck my knowledge please - the builders for releases, release-updates, and release-security (where release is any given release name) do NOT include the backports repo in available libraries in the build envs, correct?23:18
teward(it was my understanding that only -backports targeted things get -backports included in the builder at build time)23:18
cjwatsonteward: correct, see https://git.launchpad.net/launchpad/tree/lib/lp/soyuz/adapters/archivedependencies.py#n7223:19
tewardEickmeyer: ^ relevant to the pinging in #ubuntustudio-devel you're doing for me23:19
cjwatson(and just to be clear, they're all the same builders, just with different job configuration dispatched to them)23:20
Eickmeyerteward: ack, kindof knew that.23:24
tewardcjwatson: ack, i knew they're the same builders but I was implying in the *environment* within the builder at build time (hence the different job confs)23:25
tewardcjwatson: thanks for confirming what I already knew ;)23:25
-queuebot:#ubuntu-release- Unapproved: xdg-terminal-exec (lunar-proposed/universe) [0~20221120-1 => 0~20230318-1] (no packageset) (sync)23:26
tewardthis came up as a q from Eickmeyer about backporting libzita-alsa-pcmi which would cause an ABI bump and be incompatible with the current version in LTS if backported so then it'd be NCR(s) against "backported" but that's not a thing, hence the question to confirm my knowledge of the builder envs23:26
-queuebot:#ubuntu-release- Unapproved: accepted xdg-terminal-exec [sync] (lunar-proposed) [0~20230318-1]23:26
teward(so the only way that'd work would be to backport the library, and then backport all the tools that depend on it) cc ddstreet_away mapreri23:27
EickmeyerI'd have no problem with backporting any of those tools since it's only a handful so long as I get everything to build correctly in a PPA first.23:28
EickmeyerAnd of course, submitting as separate backport requests.23:28
EickmeyerThe biggest issue is that it doesn't qualify for SRU since it's two versions ahead and several changes, not a simple bugfix, nor can it be cherry-picked without opening a can of worms.23:29
vorlonTrevinho: it would have been helpful to have some follow-through from the Desktop side on the gtk4 promotion of libgtk-4-media-gstreamer to a Recommends:, Recommends are not enforced by proposed-migration so users who install the beta will not have it because libgtk-4-media-gstreamer is not yet in main and wasn't included on the candidate images23:46
Trevinhovorlon: oh, I thought seb128 had handled that main inclusion23:48
vorlonnot according to https://ubuntu-archive-team.ubuntu.com/component-mismatches.html23:48

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!