| meena | holmanb: https://github.com/canonical/cloud-init/pull/2168#discussion_r1191234847 | 14:17 |
|---|---|---|
| -ubottu:#cloud-init- Pull 2168 in canonical/cloud-init "FreeBSD (and friends): better identify MBR slices" [Open] | 14:17 | |
| meena | https://github.com/canonical/cloud-init/issues/3250 i thought i had all FreeBSD issues assigned to myself | 16:21 |
| -ubottu:#cloud-init- Issue 3250 in canonical/cloud-init "Cloud init rsyslog module will not start on FreeBSD" [Open] | 16:21 | |
| meena | which reminds me, how do you assign issues in GitHub? | 16:22 |
| falcojr | There's the assignees section on the right side of the PR, under the reviewers | 16:34 |
| holmanb | Except for minimal, who can't be assigned to PRs in Github for some reason | 16:56 |
| holmanb | (at least by me) | 16:56 |
| minimal | oh? am I special? ;-) | 17:00 |
| holmanb | you are indeed :) | 17:01 |
| holmanb | that's why I'll leave your name in a comment any time I need your review | 17:01 |
| minimal | the is_virtual function stuff that was implemented as part of handling Openstack on bare metal, it's gone now? | 17:21 |
| minimal | only place I see it currently is in test_openstack.py | 17:21 |
| meena | minimal: yeah, they decided there's a better way to do the whole thing, and since is_virtual() was only used for that code that was reverted, it was reverted with it | 17:24 |
| meena | holmanb: can i? | 17:24 |
| meena | (be assigned bugs) | 17:24 |
| holmanb | meena: yes | 17:25 |
| meena | holmanb: yeah, someone did something special to my account, so i could sort of do reviews? | 17:25 |
| meena | but my reviews still show up as grey, not green | 17:25 |
| holmanb | ahh | 17:26 |
| minimal | finally found some time to update my local patches for git master, I had a patch for adding is_virtual to alpine.py, so that's obviously unneeded now, though detect_virt is still present so I still need to patch ds-identify for Alpine VM-detection support | 17:26 |
| meena | falcojr: it woulda been nice (maybe) to turn mentions of people to the GitHub mappings (at least the bugs that are still open) | 18:21 |
| falcojr | Yeah, I considered something like that but the API is fairly limited in what it can do. | 18:29 |
| meena | can we assign all open BSD bugs to me? | 21:23 |
| meena | https://github.com/canonical/cloud-init/issues/3250 | 21:27 |
| -ubottu:#cloud-init- Issue 3250 in canonical/cloud-init "Cloud init rsyslog module will not start on FreeBSD" [Open] | 21:27 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!