[14:08] does anyone have an experience with growpart on Oracle Linux 7? when I run `growpart` myself interactively it works. but it never seems to run from cloud-init and I'm not sure how to tell what's going on. there's nothing in the logs, it goes right from write-files to resizefs and nothing from growpart [14:10] bdean: have you debugging enabled for cloud-init logs? [14:10] if so then there should be several lines written to /var/log/cloud-init.log by cc_growpart showing what is going on [14:12] also are there any entries relating to growpart in your user-data or in /etc/cloud/cloud.cfg or /etc/cloud/cloud.cfg.d/* ? [14:12] there are logs that say DEBUG, but I see nothing from cc_growpart [14:12] I have a file in cloud.cfg.d [14:13] what does it say about growpart? [14:14] not sure how to do multiline in irc, but it's `growpart: { mode: growpart, devices: ['/'], ignore_growroot_disabled: true }` [14:14] also what about: grep "Running module growpart" /var/log/cloud-init.log ? [14:15] sure ... [14:17] just this: [14:17] 2023-05-18 14:06:26,086 - util.py[DEBUG]: Reading from /etc/cloud/cloud.cfg.d/06_growpart.cfg (quiet=False) [14:17] 2023-05-18 14:06:26,086 - util.py[DEBUG]: Read 97 bytes from /etc/cloud/cloud.cfg.d/06_growpart.cfg [14:17] and that's all [14:18] that's from `grep growpart /var/log/cloud-init.log` [14:18] so then it doesn't seem to be running the module [14:18] yeah, but why? [14:19] try: grep "Skipping modules" /var/log/cloud-init.log [14:19] it's in the list in /etc/cloud/cloud.cfg too [14:19] cloud_init_modules: [14:19]  - disk_setup [14:19]  - migrator [14:19]  - bootcmd [14:19]  - write-files [14:20]  - growpart [14:20]  - resizefs [14:20]  - set_hostname [14:20]  - update_hostname [14:20]  - update_etc_hosts [14:20]  - rsyslog [14:20]  - users-groups [14:20]  - ssh [14:21] Skipping set-hostname, Skipping module named bootcmd, Skipping module named disable-ec2-metadata [14:22] does "cloud_init_modules" appear in any other file inside /etc/cloud/ ? [14:22] rgrep "cloud_init_modules" /etc/cloud/* [14:32] sorry, one second, was in a meeting [14:34] we've got a winner! /etc/cloud/cloud.cfg.d/99_oci_cloud.cfg [14:35] f-ing OCI [14:35] # The growpart module is disabled by default. To enable automatic boot volume resizing, uncomment [14:35] # the below entry for '- growpart' and reboot. All the dependent packages for the growpart [14:35] # module to work such as cloud-utils-growpart and gdisk are already included in the image. [14:35] #- growpart [14:37] that makes zero sense to me. Why would they make images where you have to do extra steps just to resize the root volume [14:37] bdean: and that 99_oci_cloud.cfg file has a "cloud_init_modules" section? assuming it does then that overrides the list in /etc/cloud.cfg [14:37] yeah [14:37] it's like a whole copy of /etc/cloud.cfg with various bits commented out [14:39] I'm already making a custom image (their version of an AMI) so I can just use sed on this to uncomment it, but it's just annoying [14:39] thanks for the help though [14:41] perhaps they want you to manually use oci-growfs? [14:41] I mean .. they certainly don't seem to mind requiring manual steps to get things going [14:42] yeah it makes no sense [14:42] I'm doing a diff to the standard cloud.cfg to see what else they changed, this one is fun: [14:42] #disable_vmware_customization: false [14:42] gotta comment out it being false [14:43] oh well [14:43] thanks again [14:43] why? aren't you using the Oracle datasource? [14:43] it adds that, yes [14:43] in why case why would a VMware datasource setting be relevant? [14:44] s/why/which/ [14:44] maybe they don't know what they're doing [14:48] bdean: they're trying to save you from yourself ;-) [14:48] ;_; [15:25] any help to figure out why a single test is failing for #4128? I can't see what the problem actually is [19:06] minimal: I'll take a look [19:24] Thanks. I found a few other places in testcases to correct modules names (though none of those affect testcase) so I'll be updating the PR shortly [19:37] minimal: You can just remove this line https://github.com/canonical/cloud-init/blob/main/tests/integration_tests/modules/test_combined.py/#L228 [19:38] the test itself was wrong...it was expecting apt-pipelining to have been run even though it never should have [19:38] but used the name apt_pipelining, which is why the test passed. Since you changed the name of the module, it failed as it now matched correctly [19:40] ah, that's why I didn't spot the issue, was staring intently at the code with my changes, not the original code, lol [22:34] https://github.com/canonical/cloud-init/pull/4129 [22:34] -ubottu:#cloud-init- Pull 4129 in canonical/cloud-init "BSD: simplify finding MBR partitions" [Open] [22:44] can soeone re-run tests here? https://github.com/canonical/cloud-init/pull/2146 — some of them have been cancelled, no idea why [22:44] -ubottu:#cloud-init- Pull 2146 in canonical/cloud-init "FreeBSD fix parsing of mount and mount options" [Open] [22:52] wow, i just realized: Python stuff gets installed without junk like tests. [22:52] can somebody at NPM please cop on.